[Bug c++/110114] [13/14 Regression] ICE on calling overloaded function in case of incomplete argument type and C++ designated initializers
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110114 --- Comment #5 from CVS Commits --- The trunk branch has been updated by Marek Polacek : https://gcc.gnu.org/g:2cb0dc866e8f95151df5d759157708108e850dd9 commit r14-2677-g2cb0dc866e8f95151df5d759157708108e850dd9 Author: Marek Polacek Date: Wed Jul 19 08:47:29 2023 -0400 c++: fix ICE with designated initializer [PR110114] r13-1227 added an assert checking that the index in a CONSTRUCTOR is a FIELD_DECL. That's a reasonable assumption but in this case we never called reshape_init due to the type being incomplete, and so the index remained an identifier node: get_class_binding never got around to looking up the FIELD_DECL. We can avoid the crash by returning early in implicit_conversion_1; we'd return NULL anyway due to: if (i < CONSTRUCTOR_NELTS (ctor)) return NULL; in build_aggr_conv. PR c++/110114 gcc/cp/ChangeLog: * call.cc (implicit_conversion_1): Return early if the type isn't complete. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/initlist100.C: Adjust expected diagnostic. * g++.dg/cpp2a/desig28.C: New test. * g++.dg/cpp2a/desig29.C: New test.
[Bug c++/110114] [13/14 Regression] ICE on calling overloaded function in case of incomplete argument type and C++ designated initializers
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110114 --- Comment #4 from Marek Polacek --- This should work; I'll test it tomorrow. --- a/gcc/cp/call.cc +++ b/gcc/cp/call.cc @@ -986,6 +986,11 @@ build_aggr_conv (tree type, tree ctor, int flags, tsubst_flags_t complain) tree empty_ctor = NULL_TREE; hash_set pset; + /* We've called complete_type on TYPE before calling this function, but + perhaps it wasn't successful. */ + if (!COMPLETE_TYPE_P (type)) +return nullptr; + /* We already called reshape_init in implicit_conversion, but it might not have done anything in the case of parenthesized aggr init. */
[Bug c++/110114] [13/14 Regression] ICE on calling overloaded function in case of incomplete argument type and C++ designated initializers
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110114 Marek Polacek changed: What|Removed |Added Priority|P3 |P2 Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org Status|NEW |ASSIGNED
[Bug c++/110114] [13/14 Regression] ICE on calling overloaded function in case of incomplete argument type and C++ designated initializers
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110114 Marek Polacek changed: What|Removed |Added CC||jason at gcc dot gnu.org, ||mpolacek at gcc dot gnu.org --- Comment #3 from Marek Polacek --- Started with r13-1227: commit 6c72f1bfc3469422460d86314a081353632d4bcb Author: Jason Merrill Date: Thu Jun 23 14:41:19 2022 -0400 c++: designated init cleanup [PR105925]
