[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[schnetter at aei dot mpg dot de]

--- Comment #10 from schnetter at aei dot mpg dot de  2006-01-24 21:09 
---
Yes, I am able to compile the code with that version:

$ ~/gcc/bin/g++ --version
g++ (GCC) 4.2.0 20051129 (experimental)

$ ~/gcc/bin/g++ -o lamtest *.ii -L/sw/lib -llammpio -llammpi++ -lmpi -llam


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #11 from pinskia at gcc dot gnu dot org  2006-01-24 22:53 
---
It was broken before 20051231.  So we are done to a month.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #12 from pinskia at gcc dot gnu dot org  2006-01-25 00:04 
---
It worked in 20051203.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #13 from pinskia at gcc dot gnu dot org  2006-01-25 01:06 
---
It was broken in 20051217. so only two weeks now.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #14 from pinskia at gcc dot gnu dot org  2006-01-25 01:10 
---
Nathan sorry for CCing you (that was accident).


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 CC|nathan at gcc dot gnu dot   |
   |org |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #15 from pinskia at gcc dot gnu dot org  2006-01-25 02:14 
---
Fails in 20051210.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #16 from pinskia at gcc dot gnu dot org  2006-01-25 03:40 
---
Before the breakage:
.globl __ZTV1f
.weak_definition __ZTV1f
.section __DATA,__const_coal,coalesced

After:
.globl __ZTV1f
.const_data

We are doing two things wrong, not marking this as weak and then not putting it
into the coalesced section.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #17 from pinskia at gcc dot gnu dot org  2006-01-25 03:51 
---
Caused by:
(machopic_select_section): Return the selected section rather than
emitting assembly code.  Replace the static function table with
inline conditional expressions.  Update the tests of last_text_section
and move them into the FUNCTION_DECL block.


I have to figure out why.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #18 from pinskia at gcc dot gnu dot org  2006-01-25 03:58 
---
Or maybe not.  More likely the TARGET_CXX_CLASS_DATA_ALWAYS_COMDAT changes.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #19 from pinskia at gcc dot gnu dot org  2006-01-25 04:07 
---
I might need some C++ help on this one but I think this is valid as the virtual
function is marked as inline so it is vague but can that be a key function?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #20 from pinskia at gcc dot gnu dot org  2006-01-25 04:39 
---
Found the problem and a way to fix it.  The problem is that the key function
needs to be changed to the  arm-eabi way and not the IA64 C++ ABI way.

See http://gcc.gnu.org/ml/gcc-patches/2004-08/msg02645.html for the ARM-eabi
way.


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
   |dot org |org
 Status|NEW |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908

[Bug c++/25908] [4.2 Regression] vtables with vague linkage is not being marked as vague on darwin

[pinskia at gcc dot gnu dot org]

--- Comment #21 from pinskia at gcc dot gnu dot org  2006-01-25 04:44 
---
To remind me, I should enable g++.dg/abi/key1.C on *-darwin.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25908