[Bug c++/31754] Improve column number accuracy in error messages

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31754

Manuel López-Ibáñez manu at gcc dot gnu.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #23 from Manuel López-Ibáñez manu at gcc dot gnu.org 2012-04-12 
21:23:51 UTC ---
Please open new PRs for each issue that you find. Closing this one as fixed.

[Bug c++/31754] Improve column number accuracy in error messages

[dodji at gcc dot gnu dot org]

--- Comment #22 from dodji at gcc dot gnu dot org  2010-02-22 17:46 ---
Not working on this right now.


-- 

dodji at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|dodji at gcc dot gnu dot org|unassigned at gcc dot gnu
   ||dot org
 Status|ASSIGNED|NEW


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31754

[Bug c++/31754] Improve column number accuracy in error messages

[manu at gcc dot gnu dot org]

--- Comment #21 from manu at gcc dot gnu dot org  2009-08-05 12:09 ---
Are there any failing testcases for this PR? Perhaps we can turn this into a
meta-bug, or if there are no testcases right now, it would be better to close
it (we have already enough open PRs).


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31754

[Bug c++/31754] Improve column number accuracy in error messages

[manu at gcc dot gnu dot org]

--- Comment #20 from manu at gcc dot gnu dot org  2008-07-21 16:32 ---
(In reply to comment #19)
 Okay, so the two patches are now committed to trunk in changesets 
 r137716 and r137721.
 
 However, given the nature of this enhancement request, I think it will take
 some on going work to have perfect column number information in the C++ front
 end when using -fshow-column and eventually enabling that option by default.
 

Dodji, thanks for tackling this issue. 

In the long run, all diagnostic functions should take a location parameter.
Currently there is a patch to add warning_at() by Rafael Espindola. However,
the goal is to replace warning/error/pedwarn/etc by versions that take a
location as the first parameter, thus making obsolote the use of %H. 

I see that you are adding a lot of %H to the code, so I was wondering whether
wouldn't it be better to add instead error_at, pedwarn_at and etc. In the
future it will be easier to change those to just error, pedwarn and etc, than
to change all those %H.


-- 

manu at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||manu at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31754

[Bug c++/31754] Improve column number accuracy in error messages

[dodji at gcc dot gnu dot org]

--- Comment #19 from dodji at gcc dot gnu dot org  2008-07-11 16:50 ---
Okay, so the two patches are now committed to trunk in changesets 
r137716 and r137721.

However, given the nature of this enhancement request, I think it will take
some on going work to have perfect column number information in the C++ front
end when using -fshow-column and eventually enabling that option by default.

I will therefore leave the bug open so that we can track the progress of this
task.

I have also changed the title of the bug to make it more generic.

Thanks for reporting this.


-- 

dodji at gcc dot gnu dot org changed:

   What|Removed |Added

  Component|other   |c++
Summary|Include column number along |Improve column number
   |line in error messages  |accuracy in error messages
   |main.cpp:5:38   |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31754