[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #5 from pcarlini at suse dot de 2007-08-17 10:22 --- This is now fixed both in mainline and in 4_2-branch: 32190.C: In function 'int main()': 32190.C:5: error: template argument 1 is invalid at this point, not being a regression, I think we can close it. -- pcarlini at suse dot de changed: What|Removed |Added Known to work||4.2.1 4.3.0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #6 from manu at gcc dot gnu dot org 2007-08-17 10:24 --- (In reply to comment #5) This is now fixed both in mainline and in 4_2-branch: 32190.C: In function 'int main()': 32190.C:5: error: template argument 1 is invalid at this point, not being a regression, I think we can close it. Is there a testcase for this? If not, perhaps we can close this *after* the testcase is added. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #7 from pcarlini at suse dot de 2007-08-17 10:26 --- Sure, I'll take care of that... -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #8 from manu at gcc dot gnu dot org 2007-08-17 10:28 --- Ivan, would you like to write, test and post the testcase? Once it is approved I can commit it for you (with your name of course!). A starting point will be http://gcc.gnu.org/wiki/HowToPrepareATestcase, if you need further help, please contact me. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #9 from igodard at pacbell dot net 2007-08-17 10:37 --- Subject: Re: wrong error recovery on parsing template arguments Begging your pardon, but what's wrong with the one I put in already? Ivan manu at gcc dot gnu dot org wrote: --- Comment #8 from manu at gcc dot gnu dot org 2007-08-17 10:28 --- Ivan, would you like to write, test and post the testcase? Once it is approved I can commit it for you (with your name of course!). A starting point will be http://gcc.gnu.org/wiki/HowToPrepareATestcase, if you need further help, please contact me. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #10 from manu at gcc dot gnu dot org 2007-08-17 10:50 ---
(In reply to comment #9)
Subject: Re: wrong error recovery on parsing template arguments
Begging your pardon, but what's wrong with the one I put in already?
Nothing is wrong, but to be useful for GCC testsuite, we need to add some
markers (for example, // { dg-error template argument 1 is invalid }) and
then run an old version and check that the test fails and run it for mainline
and check that the test passes. Then the patch adding the testcase is submitted
to gcc-patches for review with an appropriate changelog, approved and
committed. I think it would be a feasible contribution from you, letting more
advance developers like Paolo to focus on more complex stuff.
But if you don't want to do it just say so, no problem at all.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #11 from igodard at pacbell dot net 2007-08-17 17:25 ---
Subject: Re: wrong error recovery on parsing template arguments
Seems impractical. I don't have access to the old versions or mainline,
and don't know what magic to put in the source for your system to use.
I'm sure all that could be fixed, but it's more likely to take more of
someone's time holding my hand than it would be to do it themselves. If
I were doing a hundred of them it would be worth the investment, but for
a one-off it seems hardly useful.
Ivan
manu at gcc dot gnu dot org wrote:
--- Comment #10 from manu at gcc dot gnu dot org 2007-08-17 10:50 ---
(In reply to comment #9)
Subject: Re: wrong error recovery on parsing template arguments
Begging your pardon, but what's wrong with the one I put in already?
Nothing is wrong, but to be useful for GCC testsuite, we need to add some
markers (for example, // { dg-error template argument 1 is invalid }) and
then run an old version and check that the test fails and run it for mainline
and check that the test passes. Then the patch adding the testcase is
submitted
to gcc-patches for review with an appropriate changelog, approved and
committed. I think it would be a feasible contribution from you, letting more
advance developers like Paolo to focus on more complex stuff.
But if you don't want to do it just say so, no problem at all.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #12 from paolo at gcc dot gnu dot org 2007-08-17 21:31 --- Subject: Bug 32190 Author: paolo Date: Fri Aug 17 21:31:40 2007 New Revision: 127597 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=127597 Log: 2007-08-17 Paolo Carlini [EMAIL PROTECTED] PR c++/32190 * g++.dg/parse/error31.C: New. Added: trunk/gcc/testsuite/g++.dg/parse/error31.C Modified: trunk/gcc/testsuite/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #13 from paolo at gcc dot gnu dot org 2007-08-17 21:38 --- Subject: Bug 32190 Author: paolo Date: Fri Aug 17 21:38:19 2007 New Revision: 127598 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=127598 Log: 2007-08-17 Paolo Carlini [EMAIL PROTECTED] PR c++/32190 * g++.dg/parse/error31.C: New. Added: branches/gcc-4_2-branch/gcc/testsuite/g++.dg/parse/error31.C -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #14 from paolo at gcc dot gnu dot org 2007-08-17 21:38 --- Subject: Bug 32190 Author: paolo Date: Fri Aug 17 21:38:40 2007 New Revision: 127599 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=127599 Log: 2007-08-17 Paolo Carlini [EMAIL PROTECTED] PR c++/32190 * g++.dg/parse/error31.C: New. Modified: branches/gcc-4_2-branch/gcc/testsuite/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #15 from pcarlini at suse dot de 2007-08-17 21:40 --- Already fixed in 4_2-branch and mainline. -- pcarlini at suse dot de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #3 from manu at gcc dot gnu dot org 2007-06-04 13:51 --- Likely, the code for parsing template arguments is not clever enough to stop as soon as something goes awry and report it correctly. -- manu at gcc dot gnu dot org changed: What|Removed |Added CC||manu at gcc dot gnu dot org Summary|bad diagnostic |wrong error recovery on ||parsing template arguments http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
[Bug c++/32190] wrong error recovery on parsing template arguments
--- Comment #4 from igodard at pacbell dot net 2007-06-04 14:27 --- Well, in my ignorance, I'd say that the symptoms are consistent with scanning forward to the next , regardless of what gets scanned over, such an unmatched or statement-lists. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32190
