[Bug c++/83045] [8 Regression] -Wreturn-type regression in C++
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83045 Jakub Jelinek changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org --- Comment #4 from Jakub Jelinek --- Fixed.
[Bug c++/83045] [8 Regression] -Wreturn-type regression in C++
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83045 --- Comment #3 from Jakub Jelinek --- Author: jakub Date: Tue Nov 21 17:40:34 2017 New Revision: 255018 URL: https://gcc.gnu.org/viewcvs?rev=255018=gcc=rev Log: PR c++/83045 * tree-cfg.c (pass_warn_function_return::execute): Formatting fix. Also warn if seen __builtin_unreachable () call with BUILTINS_LOCATION. Use LOCATION_LOCUS when comparing against UNKNOWN_LOCATION. * c-c++-common/pr61405.c (fn0, fn1): Add return stmts. * c-c++-common/Wlogical-op-2.c (fn): Likewise. * g++.dg/debug/pr53466.C: Add -Wno-return-type to dg-options. * g++.dg/opt/combine.C: Likewise. * g++.dg/ubsan/return-3.C: Likewise. * g++.dg/pr59445.C: Likewise. * g++.dg/pr49847.C: Likewise. * g++.dg/ipa/pr61800.C: Likewise. * g++.dg/ipa/pr63470.C: Likewise. * g++.dg/ipa/pr68672-1.C: Likewise. * g++.dg/pr58438.C: Likewise. * g++.dg/torture/pr59265.C: Likewise. * g++.dg/tree-ssa/ssa-dse-2.C: Likewise. * g++.old-deja/g++.eh/catch13.C: Likewise. * g++.old-deja/g++.eh/crash1.C: Likewise. * g++.dg/tm/pr60004.C: Expect -Wreturn-type warning. * g++.dg/torture/pr55740.C: Likewise. * g++.dg/torture/pr43257.C: Likewise. * g++.dg/torture/pr64280.C: Likewise. * g++.dg/torture/pr54684.C: Likewise. * g++.dg/torture/pr56694.C: Likewise. * g++.dg/torture/pr68470.C: Likewise. * g++.dg/torture/pr60648.C: Likewise. * g++.dg/torture/pr71281.C: Likewise. * g++.dg/torture/pr52772.C: Add -Wno-return-type dg-additional-options. * g++.dg/torture/pr64669.C: Likewise. * g++.dg/torture/pr58369.C: Likewise. * g++.dg/torture/pr33627.C: Likewise. * g++.dg/torture/predcom-1.C: Add #pragma GCC diagnostic ignored "-Wreturn-type". * g++.dg/lto/20090221_0.C: Likewise. * g++.dg/lto/20091026-1_1.C: Likewise. * g++.dg/lto/pr54625-1_1.C: Likewise. * g++.dg/warn/pr83045.C: New test. Added: trunk/gcc/testsuite/g++.dg/warn/pr83045.C Modified: trunk/gcc/ChangeLog trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/c-c++-common/Wlogical-op-2.c trunk/gcc/testsuite/c-c++-common/pr61405.c trunk/gcc/testsuite/g++.dg/debug/pr53466.C trunk/gcc/testsuite/g++.dg/ipa/pr61800.C trunk/gcc/testsuite/g++.dg/ipa/pr63470.C trunk/gcc/testsuite/g++.dg/ipa/pr68672-1.C trunk/gcc/testsuite/g++.dg/lto/20090221_0.C trunk/gcc/testsuite/g++.dg/lto/20091026-1_1.C trunk/gcc/testsuite/g++.dg/lto/pr54625-1_1.C trunk/gcc/testsuite/g++.dg/opt/combine.C trunk/gcc/testsuite/g++.dg/pr49847.C trunk/gcc/testsuite/g++.dg/pr58438.C trunk/gcc/testsuite/g++.dg/pr59445.C trunk/gcc/testsuite/g++.dg/tm/pr60004.C trunk/gcc/testsuite/g++.dg/torture/pr33627.C trunk/gcc/testsuite/g++.dg/torture/pr43257.C trunk/gcc/testsuite/g++.dg/torture/pr52772.C trunk/gcc/testsuite/g++.dg/torture/pr54684.C trunk/gcc/testsuite/g++.dg/torture/pr55740.C trunk/gcc/testsuite/g++.dg/torture/pr56694.C trunk/gcc/testsuite/g++.dg/torture/pr58369.C trunk/gcc/testsuite/g++.dg/torture/pr59265.C trunk/gcc/testsuite/g++.dg/torture/pr60648.C trunk/gcc/testsuite/g++.dg/torture/pr64280.C trunk/gcc/testsuite/g++.dg/torture/pr64669.C trunk/gcc/testsuite/g++.dg/torture/pr68470.C trunk/gcc/testsuite/g++.dg/torture/pr71281.C trunk/gcc/testsuite/g++.dg/torture/predcom-1.C trunk/gcc/testsuite/g++.dg/tree-ssa/ssa-dse-2.C trunk/gcc/testsuite/g++.dg/ubsan/return-3.C trunk/gcc/testsuite/g++.old-deja/g++.eh/catch13.C trunk/gcc/testsuite/g++.old-deja/g++.eh/crash1.C trunk/gcc/tree-cfg.c
[Bug c++/83045] [8 Regression] -Wreturn-type regression in C++
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83045 Jakub Jelinek changed: What|Removed |Added CC||jakub at gcc dot gnu.org --- Comment #2 from Jakub Jelinek --- Created attachment 42665 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=42665=edit gcc8-pr83045.patch Patch I wrote for this. Unfortunately it shows up various new warnings, so I'll need to adjust the testsuite for it tomorrow.
[Bug c++/83045] [8 Regression] -Wreturn-type regression in C++
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83045
Martin Liška changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last reconfirmed||2017-11-20
Ever confirmed|0 |1
--- Comment #1 from Martin Liška ---
Confirmed, problem is following: before the patch we emitted return statement
that was caught in tree-cfg.c. Now we end up with:
test2 (int a)
{
:
if (a != 0)
goto ; [INV]
else
goto ; [INV]
:
__builtin_abort ();
:
__builtin_unreachable ();
}
Thus the warnings in tree-cfg can't see that. On the other hand, having a
function that doesn't do an abnormal return:
test2 (int a)
{
:
if (a != 0)
goto ; [INV]
else
goto ; [INV]
:
foo ();
:
__builtin_unreachable ();
}
C++ FE warning is triggered:
/home/marxin/Programming/testcases/pr83045-2.c: In function ‘int test2(int)’:
/home/marxin/Programming/testcases/pr83045-2.c:15:1: warning: no return
statement in function returning non-void [-Wreturn-type]
That said, I don't know how to fix that properly?
[Bug c++/83045] [8 Regression] -Wreturn-type regression in C++
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83045 Richard Biener changed: What|Removed |Added Keywords||diagnostic Target Milestone|--- |8.0 Summary|-Wreturn-type regression in |[8 Regression] |C++ |-Wreturn-type regression in ||C++
