[Bug c++/90010] [8/9 Regression] valgrind error with snprintf and -Wall

2019-04-10 Thread jakub at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90010

--- Comment #5 from Jakub Jelinek  ---
Author: jakub
Date: Wed Apr 10 07:27:20 2019
New Revision: 270246

URL: https://gcc.gnu.org/viewcvs?rev=270246=gcc=rev
Log:
PR c++/90010
* gimple-ssa-sprintf.c (target_to_host): Fix handling of targstr
with strlen in between hostsz-3 and hostsz-1 inclusive when no
translation is needed, and when translation is needed, only append
... if the string length is hostsz or more bytes long.  Avoid using
strncpy or strcat.

* gcc.dg/pr90010.c: New test.

Added:
trunk/gcc/testsuite/gcc.dg/pr90010.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/gimple-ssa-sprintf.c
trunk/gcc/testsuite/ChangeLog

[Bug c++/90010] [8/9 Regression] valgrind error with snprintf and -Wall

2019-04-09 Thread jakub at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90010

Jakub Jelinek  changed:

   What|Removed |Added

   Keywords|ice-on-valid-code   |diagnostic

--- Comment #4 from Jakub Jelinek  ---
Not an ICE actually, just printing random bytes (1/2/3 at most) at the end of
the %qs string instead of the bytes that should be there.

[Bug c++/90010] [8/9 Regression] valgrind error with snprintf and -Wall

2019-04-09 Thread jakub at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90010

--- Comment #3 from Jakub Jelinek  ---
Created attachment 46113
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=46113=edit
gcc9-pr90010.patch

Untested fix.

[Bug c++/90010] [8/9 Regression] valgrind error with snprintf and -Wall

2019-04-09 Thread jakub at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90010

Jakub Jelinek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jakub at gcc dot gnu.org
   Assignee|unassigned at gcc dot gnu.org  |jakub at gcc dot gnu.org

[Bug c++/90010] [8/9 Regression] valgrind error with snprintf and -Wall

2019-04-09 Thread rguenth at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90010

Richard Biener  changed:

   What|Removed |Added

   Keywords||ice-on-valid-code
   Priority|P3  |P2

[Bug c++/90010] [8/9 Regression] valgrind error with snprintf and -Wall

2019-04-09 Thread marxin at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90010

Martin Liška  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2019-04-09
 CC||marxin at gcc dot gnu.org,
   ||msebor at gcc dot gnu.org
  Known to work||7.3.0
   Target Milestone|--- |8.4
Summary|valgrind error with |[8/9 Regression] valgrind
   |snprintf and -Wall  |error with snprintf and
   ||-Wall
 Ever confirmed|0   |1
  Known to fail||8.3.0, 9.0

--- Comment #2 from Martin Liška  ---
Confirmed, started with r247401.