[Bug c++/94250] valgrind error for ./g++.dg/ipa/remref-1.C

2020-03-21 Thread marxin at gcc dot gnu.org 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94250

Martin Liška  changed:

   What|Removed |Added

   Last reconfirmed||2020-03-21
   Assignee|unassigned at gcc dot gnu.org  |marxin at gcc dot 
gnu.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED

--- Comment #3 from Martin Liška  ---
A nice catch David! I've got a patch for it.

[Bug c++/94250] valgrind error for ./g++.dg/ipa/remref-1.C

2020-03-21 Thread xerofoify at gmail dot com 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94250

--- Comment #2 from Nicholas Krause  ---
(In reply to Nicholas Krause from comment #1)
> After looking through the git history that last time this functions in your
> trace were changed is by commit id,
> db30281f0b2ff6dfc0c4146291baf020a27e4065. Martin Liska  was the original
> committer so he should comment on this.
> https://gcc.gnu.org/git/?p=gcc.git;a=commit;
> h=db30281f0b2ff6dfc0c4146291baf020a27e4065
> 
> However this was changed:
> summary->duplicate (edge1, edge2, edge1_summary,
>   summary->get_create (edge2));

and it appears to be assuming based on the above lines:
if (summary->m_initialize_when_cloning)
 edge1_summary = summary->get_create (edge1);
else
 edge1_summary = summary->get (edge1);

That this can never occur for edge2. Martin is edge2 assumed to be good by this
comment?

[Bug c++/94250] valgrind error for ./g++.dg/ipa/remref-1.C

2020-03-21 Thread xerofoify at gmail dot com 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94250

Nicholas Krause  changed:

   What|Removed |Added

 CC||mliska at suse dot cz,
   ||xerofoify at gmail dot com

--- Comment #1 from Nicholas Krause  ---
After looking through the git history that last time this functions in your
trace were changed is by commit id,
db30281f0b2ff6dfc0c4146291baf020a27e4065. Martin Liska  was the original
committer so he should comment on this.
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=db30281f0b2ff6dfc0c4146291baf020a27e4065

However this was changed:
summary->duplicate (edge1, edge2, edge1_summary,
  summary->get_create (edge2));