[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 --- Comment #12 from CVS Commits --- The master branch has been updated by Martin Uecker : https://gcc.gnu.org/g:3057d7928c0dbc78dbf748c9621ccd102e06beee commit r13-6127-g3057d7928c0dbc78dbf748c9621ccd102e06beee Author: Martin Uecker Date: Wed Feb 8 15:02:43 2023 +0100 Fix ICE related to implicit access attributes for VLA arguments [PR105660] When constructing the specifier string when merging an access attribute that encodes information about VLA arguments, the string was constructed in random order by iterating through a hash table. Fix this by iterating though the list of arguments. gcc/c-family/Changelog: PR c/105660 * c-attribs.cc (append_access_attr): Use order of arguments when construction string. (append_access_attr_idxs): Rename and make static. * c-warn.cc (warn_parm_array_mismatch): Add assertion. gcc/testsuite/ChangeLog: PR c/105660 * gcc.dg/pr105660-1.c: New test. * gcc.dg/pr105660-2.c: New test.
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 --- Comment #11 from Martin Uecker --- PATCH: https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611817.html
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 --- Comment #10 from Martin Uecker --- I do not think the suggested change is correct. I am looking into it.
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 --- Comment #9 from Alex Coplan --- (In reply to Romain Dolbeau from comment #8) > Hello, > > I only posted the patch to the (web) bug report, I'm not sure if that > automatically notify the ML or not... No, you will need to submit the patch yourself to gcc-patc...@gcc.gnu.org, see the contribution guidelines here: https://gcc.gnu.org/contribute.html
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 --- Comment #8 from Romain Dolbeau --- Hello, I only posted the patch to the (web) bug report, I'm not sure if that automatically notify the ML or not... Cordially,
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 Alex Coplan changed: What|Removed |Added CC||acoplan at gcc dot gnu.org --- Comment #7 from Alex Coplan --- (In reply to Romain Dolbeau from comment #3) > Created attachment 53191 [details] > Patch to resolve the issue by moving strchr to strrchr Hi Romain, have you submitted the patch to the gcc-patches mailing list for review?
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 --- Comment #6 from Romain Dolbeau --- Please consider this for 12.2, it's a trivial bug with a trivial fix that's been available for two months.
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 Richard Biener changed: What|Removed |Added Target Milestone|12.2|12.3 --- Comment #5 from Richard Biener --- GCC 12.2 is being released, retargeting bugs to GCC 12.3.
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 --- Comment #4 from Romain Dolbeau --- It seems the issue was an 'r' dropped from the name of 'strrchr' in the offending commit. Fixing this resolves the bug for us. See the attached patch.
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 Romain Dolbeau changed: What|Removed |Added CC||romain at dolbeau dot org --- Comment #3 from Romain Dolbeau --- Created attachment 53191 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53191=edit Patch to resolve the issue by moving strchr to strrchr
[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660 Richard Biener changed: What|Removed |Added Priority|P3 |P2
