[Bug c/67820] Move obscure warning about null pointers into prime time
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67820 --- Comment #4 from David Binderman --- >Did you grep for -W ? $ fgrep -l -e "-W " fedora/pass78/2015122*/* | wc -l 50 $ fgrep -l -e "-W " fedora/pass77/201512*/* | wc -l 590 $ So -W gets about as much use as -Wextra Both together are 14% in the first case and 19% in the second case. Still look like low numbers to me. It seems that most Fedora developers don't use -W or -Wextra. Hence my bug report.
[Bug c/67820] Move obscure warning about null pointers into prime time
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67820
Jakub Jelinek changed:
What|Removed |Added
CC||jakub at gcc dot gnu.org
--- Comment #5 from Jakub Jelinek ---
-Wall is used by default in Fedora at least when packages honor the rpm opt
flags they are provided:
%__global_cflags-O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches %{_hardened_cflags}
-W/-Wextra is used only when the packages use it explicitly.
[Bug c/67820] Move obscure warning about null pointers into prime time
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67820 Andrew Pinski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Andrew Pinski --- I have almost always seen people use -Wall -W (-W is another name for -Wextra) so it is already in the prime time as far as I know.
[Bug c/67820] Move obscure warning about null pointers into prime time
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67820 --- Comment #2 from David Binderman --- >I have almost always seen people use -Wall -W Doubtful. Looking at a bunch of recent Fedora package builds $ fgrep -l Wextra fedora/pass78/201512*/* | wc -l 35 $ fgrep -l Wall fedora/pass78/201512*/* | wc -l 589 On an earlier and bigger set of builds: $ fgrep -l Wextra fedora/pass77/2015*/* | wc -l 523 $ fgrep -l Wall fedora/pass77/2015*/* | wc -l 5983 $ So about 6% in the first case and 9% in the second case. Even allowing for the -W to -Wextra change, neither of these numbers look to me like "almost always". It looks to me like lots of folks use -Wall, but few folks use -Wextra.
[Bug c/67820] Move obscure warning about null pointers into prime time
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67820 --- Comment #3 from Andrew Pinski --- (In reply to David Binderman from comment #2) > >I have almost always seen people use -Wall -W > > Doubtful. Looking at a bunch of recent Fedora package builds > > $ fgrep -l Wextra fedora/pass78/201512*/* | wc -l > 35 > $ fgrep -l Wall fedora/pass78/201512*/* | wc -l > 589 > > On an earlier and bigger set of builds: > > $ fgrep -l Wextra fedora/pass77/2015*/* | wc -l > 523 > $ fgrep -l Wall fedora/pass77/2015*/* | wc -l > 5983 > $ > Did you grep for -W ? Because I bet there are a lot more people who use that instead of -Wextra. Seriously -W has been wildly in use for years (over 20 years now) and people would use that over -Wextra because the code is older than -Wextra was added to GCC.
