[Bug d/107592] ICE: gdc segfault on label continue
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107592 Iain Buclaw changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #6 from Iain Buclaw --- Fix committed and backported to release branches.
[Bug d/107592] ICE: gdc segfault on label continue
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107592 --- Comment #5 from CVS Commits --- The releases/gcc-10 branch has been updated by Iain Buclaw : https://gcc.gnu.org/g:f3cfcde3d69e2e8d305c4d4d662a26cd25e8398c commit r10-11103-gf3cfcde3d69e2e8d305c4d4d662a26cd25e8398c Author: Iain Buclaw Date: Sat Nov 12 00:54:47 2022 +0100 d: Fix ICE on named continue label in an unrolled loop [PR107592] Continue labels in an unrolled loop require a unique label per iteration. Previously this used the Statement body node for each unrolled iteration to generate a new entry in the label hash table. This does not work when the continue label has an identifier, as said named label is pointing to the outer UnrolledLoopStatement node. What would happen is that during the lowering of `continue label', an automatic label associated with the unrolled loop would be generated, and a jump to that label inserted, but because it was never pushed by the visitor for the loop itself, it subsequently never gets emitted. To fix, correctly use the UnrolledLoopStatement as the key to look up and store the break/continue label pair, but remove the continue label from the value entry after every loop to force a new label to be generated by the next call to `push_continue_label' PR d/107592 gcc/d/ChangeLog: * toir.cc (IRVisitor::push_unrolled_continue_label): New method. (IRVisitor::pop_unrolled_continue_label): New method. (IRVisitor::visit (UnrolledLoopStatement *)): Use them instead of push_continue_label and pop_continue_label. gcc/testsuite/ChangeLog: * gdc.dg/pr107592.d: New test. (cherry picked from commit 031d3f095520f0e1ee03e29b7ad5067c2a3f96e0)
[Bug d/107592] ICE: gdc segfault on label continue
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107592 --- Comment #4 from CVS Commits --- The releases/gcc-11 branch has been updated by Iain Buclaw : https://gcc.gnu.org/g:7bb5b326796af7d688c9976fba7ba3c2706481a0 commit r11-10402-g7bb5b326796af7d688c9976fba7ba3c2706481a0 Author: Iain Buclaw Date: Sat Nov 12 00:54:47 2022 +0100 d: Fix ICE on named continue label in an unrolled loop [PR107592] Continue labels in an unrolled loop require a unique label per iteration. Previously this used the Statement body node for each unrolled iteration to generate a new entry in the label hash table. This does not work when the continue label has an identifier, as said named label is pointing to the outer UnrolledLoopStatement node. What would happen is that during the lowering of `continue label', an automatic label associated with the unrolled loop would be generated, and a jump to that label inserted, but because it was never pushed by the visitor for the loop itself, it subsequently never gets emitted. To fix, correctly use the UnrolledLoopStatement as the key to look up and store the break/continue label pair, but remove the continue label from the value entry after every loop to force a new label to be generated by the next call to `push_continue_label' PR d/107592 gcc/d/ChangeLog: * toir.cc (IRVisitor::push_unrolled_continue_label): New method. (IRVisitor::pop_unrolled_continue_label): New method. (IRVisitor::visit (UnrolledLoopStatement *)): Use them instead of push_continue_label and pop_continue_label. gcc/testsuite/ChangeLog: * gdc.dg/pr107592.d: New test. (cherry picked from commit 031d3f095520f0e1ee03e29b7ad5067c2a3f96e0)
[Bug d/107592] ICE: gdc segfault on label continue
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107592 --- Comment #3 from CVS Commits --- The releases/gcc-12 branch has been updated by Iain Buclaw : https://gcc.gnu.org/g:2909464c405b79559c5507cde382df05d2d2fa41 commit r12-8951-g2909464c405b79559c5507cde382df05d2d2fa41 Author: Iain Buclaw Date: Sat Nov 12 00:54:47 2022 +0100 d: Fix ICE on named continue label in an unrolled loop [PR107592] Continue labels in an unrolled loop require a unique label per iteration. Previously this used the Statement body node for each unrolled iteration to generate a new entry in the label hash table. This does not work when the continue label has an identifier, as said named label is pointing to the outer UnrolledLoopStatement node. What would happen is that during the lowering of `continue label', an automatic label associated with the unrolled loop would be generated, and a jump to that label inserted, but because it was never pushed by the visitor for the loop itself, it subsequently never gets emitted. To fix, correctly use the UnrolledLoopStatement as the key to look up and store the break/continue label pair, but remove the continue label from the value entry after every loop to force a new label to be generated by the next call to `push_continue_label' PR d/107592 gcc/d/ChangeLog: * toir.cc (IRVisitor::push_unrolled_continue_label): New method. (IRVisitor::pop_unrolled_continue_label): New method. (IRVisitor::visit (UnrolledLoopStatement *)): Use them instead of push_continue_label and pop_continue_label. gcc/testsuite/ChangeLog: * gdc.dg/pr107592.d: New test. (cherry picked from commit 031d3f095520f0e1ee03e29b7ad5067c2a3f96e0)
[Bug d/107592] ICE: gdc segfault on label continue
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107592 --- Comment #2 from CVS Commits --- The master branch has been updated by Iain Buclaw : https://gcc.gnu.org/g:031d3f095520f0e1ee03e29b7ad5067c2a3f96e0 commit r13-4413-g031d3f095520f0e1ee03e29b7ad5067c2a3f96e0 Author: Iain Buclaw Date: Sat Nov 12 00:54:47 2022 +0100 d: Fix ICE on named continue label in an unrolled loop [PR107592] Continue labels in an unrolled loop require a unique label per iteration. Previously this used the Statement body node for each unrolled iteration to generate a new entry in the label hash table. This does not work when the continue label has an identifier, as said named label is pointing to the outer UnrolledLoopStatement node. What would happen is that during the lowering of `continue label', an automatic label associated with the unrolled loop would be generated, and a jump to that label inserted, but because it was never pushed by the visitor for the loop itself, it subsequently never gets emitted. To fix, correctly use the UnrolledLoopStatement as the key to look up and store the break/continue label pair, but remove the continue label from the value entry after every loop to force a new label to be generated by the next call to `push_continue_label' PR d/107592 gcc/d/ChangeLog: * toir.cc (IRVisitor::push_unrolled_continue_label): New method. (IRVisitor::pop_unrolled_continue_label): New method. (IRVisitor::visit (UnrolledLoopStatement *)): Use them instead of push_continue_label and pop_continue_label. gcc/testsuite/ChangeLog: * gdc.dg/pr107592.d: New test.
[Bug d/107592] ICE: gdc segfault on label continue
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107592
--- Comment #1 from Iain Buclaw ---
Generated function:
---
void foo (struct _param_0)
{
void label = <<< error >>>;
label:;
while (1)
{
{
struct thing;
thing = _param_0;
goto ;
}
goto ;
}
:;
}
