[Bug debug/54177] [4.8 Regression]: Segfault in cselib_lookup due to NULL_RTX passed from vt_add_function_parameter

2012-10-02 Thread aoliva at gcc dot gnu.org 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54177



--- Comment #6 from Alexandre Oliva aoliva at gcc dot gnu.org 2012-10-02 
19:58:41 UTC ---

Author: aoliva

Date: Tue Oct  2 19:58:37 2012

New Revision: 191999



URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=191999

Log:

PR debug/54177

* var-tracking.c (vt_add_function_parameter): Bail if

var_lowpart fails.



Modified:

trunk/gcc/ChangeLog

trunk/gcc/var-tracking.c

[Bug debug/54177] [4.8 Regression]: Segfault in cselib_lookup due to NULL_RTX passed from vt_add_function_parameter

2012-08-07 Thread aoliva at gcc dot gnu.org 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54177

--- Comment #3 from Alexandre Oliva aoliva at gcc dot gnu.org 2012-08-07 
20:08:27 UTC ---
Having reviewed teh other uses of var_lowpart, I hereby approve the patch if it
passes regstrap.  Thanks!

[Bug debug/54177] [4.8 Regression]: Segfault in cselib_lookup due to NULL_RTX passed from vt_add_function_parameter

2012-08-07 Thread ubizjak at gmail dot com 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54177

--- Comment #4 from Uros Bizjak ubizjak at gmail dot com 2012-08-07 21:07:53 
UTC ---
Author: uros
Date: Tue Aug  7 20:57:56 2012
New Revision: 190212

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=190212
Log:
* var-tracking.c (var_lowpart): Exit early for matched modes.


Modified:
trunk/gcc/ChangeLog
trunk/gcc/var-tracking.c

[Bug debug/54177] [4.8 Regression]: Segfault in cselib_lookup due to NULL_RTX passed from vt_add_function_parameter

2012-08-07 Thread ubizjak at gmail dot com 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54177

Uros Bizjak ubizjak at gmail dot com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
URL||http://gcc.gnu.org/ml/gcc-p
   ||atches/2012-08/msg00387.htm
   ||l
 Resolution||FIXED

--- Comment #5 from Uros Bizjak ubizjak at gmail dot com 2012-08-07 21:09:07 
UTC ---
Fixed.

[Bug debug/54177] [4.8 Regression]: Segfault in cselib_lookup due to NULL_RTX passed from vt_add_function_parameter

2012-08-05 Thread ubizjak at gmail dot com 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54177

Uros Bizjak ubizjak at gmail dot com changed:

   What|Removed |Added

 CC||aoliva at gcc dot gnu.org
   Target Milestone|--- |4.8.0

--- Comment #1 from Uros Bizjak ubizjak at gmail dot com 2012-08-05 06:34:19 
UTC ---
Adding CC.

[Bug debug/54177] [4.8 Regression]: Segfault in cselib_lookup due to NULL_RTX passed from vt_add_function_parameter

2012-08-05 Thread ubizjak at gmail dot com 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54177

--- Comment #2 from Uros Bizjak ubizjak at gmail dot com 2012-08-05 06:46:03 
UTC ---
Following patch fixes the failure:

--cut here--
Index: var-tracking.c
===
--- var-tracking.c  (revision 190140)
+++ var-tracking.c  (working copy)
@@ -5086,12 +5086,12 @@ var_lowpart (enum machine_mode mode, rtx loc)
 {
   unsigned int offset, reg_offset, regno;

+  if (GET_MODE (loc) == mode)
+return loc;
+
   if (!REG_P (loc)  !MEM_P (loc))
 return NULL;

-  if (GET_MODE (loc) == mode)
-return loc;
-
   offset = byte_lowpart_offset (mode, GET_MODE (loc));

   if (MEM_P (loc))
--cut here--