[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #11 from pault at gcc dot gnu dot org 2006-11-06 17:18 --- Subject: Bug 29373 Author: pault Date: Mon Nov 6 17:18:03 2006 New Revision: 118522 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=118522 Log: 2006-11-06 Paul Thomas [EMAIL PROTECTED] PR fortran/29373 * decl.c (get_proc_name, gfc_match_function_decl): Add attr.implicit_type to conditions that throw error for existing explicit interface and that allow new type- spec to be applied. PR fortran/29407 * resolve.c (resolve_fl_namelist): Do not check for namelist/procedure conflict, if the symbol corresponds to a good local variable declaration. PR fortran/27701 * decl.c (get_proc_name): Replace the detection of a declared procedure by the presence of a formal argument list by the attributes of the symbol and the presence of an explicit interface. PR fortran/29232 * resolve.c (resolve_fl_variable): See if the host association of a derived type is blocked by the presence of another type I object in the current namespace. PR fortran/29364 * resolve.c (resolve_fl_derived): Check for the presence of the derived type for a derived type component. PR fortran/24398 * module.c (gfc_use_module): Check that the first words in a module file are 'GFORTRAN module'. PR fortran/29115 * resolve.c (resolve_structure_cons): It is an error if the pointer component elements of a derived type constructor are not pointer or target. PR fortran/29211 * trans-stmt.c (generate_loop_for_temp_to_lhs, generate_loop_for_rhs_to_temp): Provide a string length for the temporary by copying that of the other side of the scalar assignment. PR fortran/29098 * resolve.c (resolve_structure_cons): Do not return FAILURE if component expression is NULL. 2006-11-06 Paul Thomas [EMAIL PROTECTED] PR fortran/29373 * gfortran.dg/implicit_9.f90: New test. PR fortran/29407 * gfortran.dg/namelist_25.f90: New test. PR fortran/27701 * gfortran.dg/same_name_2.f90: New test. PR fortran/29232 * gfortran.dg/host_assoc_types_1.f90: New test. PR fortran/29364 * gfortran.dg/missing_derived_type_1.f90: New test. * gfortran.dg/implicit_actual.f90: Comment out USE GLOBAL. PR fortran/29115 * gfortran.dg/derived_constructor_comps_2.f90: New test. PR fortran/29211 * gfortran.dg/forall_char_dependencies_1.f90: New test. PR fortran/29098 * gfortran.dg/default_initialization_2.f90: New test. Added: branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/default_initialization_2.f90 branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/derived_constructor_comps_2.f90 branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/forall_char_dependencies_1.f90 branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/host_assoc_types_1.f90 branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/implicit_9.f90 branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/missing_derived_type_1.f90 branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/namelist_25.f90 branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/same_name_2.f90 Modified: branches/gcc-4_1-branch/gcc/fortran/ChangeLog branches/gcc-4_1-branch/gcc/fortran/decl.c branches/gcc-4_1-branch/gcc/fortran/module.c branches/gcc-4_1-branch/gcc/fortran/resolve.c branches/gcc-4_1-branch/gcc/fortran/trans-stmt.c branches/gcc-4_1-branch/gcc/testsuite/ChangeLog branches/gcc-4_1-branch/gcc/testsuite/gfortran.dg/implicit_actual.f90 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #10 from pault at gcc dot gnu dot org 2006-10-14 08:17 --- Fixed in trunk Paul -- pault at gcc dot gnu dot org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #9 from pault at gcc dot gnu dot org 2006-10-13 12:51 --- Subject: Bug 29373 Author: pault Date: Fri Oct 13 12:51:07 2006 New Revision: 117692 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=117692 Log: 2006-10-13 Paul Thomas [EMAIL PROTECTED] PR fortran/29373 * decl.c (get_proc_name, gfc_match_function_decl): Add attr.implicit_type to conditions that throw error for existing explicit interface and that allow new type- spec to be applied. PR fortran/29407 * resolve.c (resolve_fl_namelist): Do not check for namelist/procedure conflict, if the symbol corresponds to a good local variable declaration. PR fortran/27701 * decl.c (get_proc_name): Replace the detection of a declared procedure by the presence of a formal argument list by the attributes of the symbol and the presence of an explicit interface. PR fortran/29232 * resolve.c (resolve_fl_variable): See if the host association of a derived type is blocked by the presence of another type I object in the current namespace. PR fortran/29364 * resolve.c (resolve_fl_derived): Check for the presence of the derived type for a derived type component. PR fortran/24398 * module.c (gfc_use_module): Check that the first words in a module file are 'GFORTRAN module'. PR fortran/29422 * resolve.c (resolve_transfer): Test functions for suitability for IO, as well as variables. PR fortran/29428 * trans-expr.c (gfc_trans_scalar_assign): Remove nullify of rhs expression. 2006-10-13 Paul Thomas [EMAIL PROTECTED] PR fortran/29373 * gfortran.dg/implicit_9.f90: New test. PR fortran/29407 * gfortran.dg/namelist_25.f90: New test. PR fortran/27701 * gfortran.dg/same_name_2.f90: New test. PR fortran/29232 * gfortran.dg/host_assoc_types_1.f90: New test. PR fortran/29364 * gfortran.dg/missing_derived_type_1.f90: New test. * gfortran.dg/implicit_actual.f90: Comment out USE GLOBAL. PR fortran/29422 * gfortran.dg/alloc_comp_constraint_4.f90: New test. PR fortran/29428 * gfortran.dg/alloc_comp_assign_5.f90: New test. Added: trunk/gcc/testsuite/gfortran.dg/alloc_comp_assign_5.f90 trunk/gcc/testsuite/gfortran.dg/alloc_comp_constraint_4.f90 trunk/gcc/testsuite/gfortran.dg/host_assoc_types_1.f90 trunk/gcc/testsuite/gfortran.dg/implicit_9.f90 trunk/gcc/testsuite/gfortran.dg/missing_derived_type_1.f90 trunk/gcc/testsuite/gfortran.dg/namelist_25.f90 trunk/gcc/testsuite/gfortran.dg/same_name_2.f90 Modified: trunk/gcc/fortran/ChangeLog trunk/gcc/fortran/decl.c trunk/gcc/fortran/module.c trunk/gcc/fortran/resolve.c trunk/gcc/fortran/trans-expr.c trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/gfortran.dg/implicit_actual.f90 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #6 from tobi at gcc dot gnu dot org 2006-10-11 16:07 --- You're working too fast, Paul. Before I even got to read your answer you already bring forward a patch. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #7 from patchapp at dberlin dot org 2006-10-11 17:00 --- Subject: Bug number PR29373 A patch for this bug has been added to the patch tracker. The mailing list url for the patch is http://gcc.gnu.org/ml/gcc-patches/2006-10/msg00620.html -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #8 from paulthomas2 at wanadoo dot fr 2006-10-11 17:05 --- Subject: Re: implicit type declaration and contained function clash tobi at gcc dot gnu dot org wrote: --- Comment #6 from tobi at gcc dot gnu dot org 2006-10-11 16:07 --- You're working too fast, Paul. Before I even got to read your answer you already bring forward a patch. Better still, I just submitted it! :-D I have been child-minding today. Since the poor little soul is sick, I have insisted that she be properly sick in bed; meanwhile, I have had the portable on my lap in the garden, catching up on pending submissions. How are you? That resubmitted PR29431 has an interesting effect on other compilers - only g95 gets it right. ifort seems to make it up as it's going along and pgf crashes in cloud of smoke, Paul -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #4 from pault at gcc dot gnu dot org 2006-10-10 12:41 --- Created an attachment (id=12403) -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12403action=view) Fix for the problem Regtested on FC5/Athlon Will submit asap. Paul -- pault at gcc dot gnu dot org changed: What|Removed |Added AssignedTo|unassigned at gcc dot gnu |pault at gcc dot gnu dot org |dot org | Status|NEW |ASSIGNED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #5 from pault at gcc dot gnu dot org 2006-10-10 12:47 --- (In reply to comment #4) Created an attachment (id=12403) -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12403action=view) [edit] Fix for the problem Sorry, I should have said that this gets rid of the TWO problems that prevent this from responding in the same way as removing the IMPLICIT NONE: pr29373.f90:8: fatal error: gfc_todo: Not Implemented: complex character array constructors compilation terminated. I will submit asap and will submit a new PR for this latter. Paul -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #2 from tobi at gcc dot gnu dot org 2006-10-09 11:34 --- As I said, I ran into this when playing around with PR29267, and it was ugly enough to warrant a PR of its own. Glad you share my opinion :-) Just to make this clear: I would never do something this ugly outside bugzilla! (BTW I added you to the CC list, it is kinda hard to answer in the right place otherwise) -- tobi at gcc dot gnu dot org changed: What|Removed |Added CC||pault at gcc dot gnu dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #3 from paulthomas2 at wanadoo dot fr 2006-10-09 20:11 --- Subject: Re: implicit type declaration and contained function clash tobi at gcc dot gnu dot org wrote: (BTW I added you to the CC list, it is kinda hard to answer in the right place otherwise) Oh s**t - next thing is that you'll want me to fix it too? Paul -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373
[Bug fortran/29373] implicit type declaration and contained function clash
--- Comment #1 from pault at gcc dot gnu dot org 2006-10-08 20:06 --- Tobi, This is a very unpleasant and venemous bug! Removing the implicit character*32 (a-z) results in pr29373.f90: In function 'MAIN__': pr29373.f90:8: fatal error: gfc_todo: Not Implemented: complex character array onstructors compilation terminated. Uuughhh! Besides which, did you really want to fold your char*32 into a (1,2) char*255? Paul -- pault at gcc dot gnu dot org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Last reconfirmed|-00-00 00:00:00 |2006-10-08 20:06:45 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29373