[Bug fortran/48543] Collapse identical strings

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48543

--- Comment #8 from Thomas Koenig  ---
Author: tkoenig
Date: Fri Jan  4 10:42:12 2019
New Revision: 267572

URL: https://gcc.gnu.org/viewcvs?rev=267572=gcc=rev
Log:
2019-01-04  Thomas Koenig  

PR fortran/48543
* gfortran.dg/const_chararacter_merge.f90: Actually remove.
* gfortran.dg/merge_char_const.f90: Restore.


Added:
trunk/gcc/testsuite/gfortran.dg/merge_char_const.f90
Removed:
trunk/gcc/testsuite/gfortran.dg/const_chararacter_merge.f90
Modified:
trunk/gcc/testsuite/ChangeLog

[Bug fortran/48543] Collapse identical strings

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48543

--- Comment #7 from Thomas Koenig  ---
Author: tkoenig
Date: Thu Jan  3 12:32:34 2019
New Revision: 267553

URL: https://gcc.gnu.org/viewcvs?rev=267553=gcc=rev
Log:
2019-01-02  Thomas Koenig  

PR fortran/48543
* gfortran.dg/const_chararacter_merge.f90: Remove.

Removed:
trunk/gcc/testsuite/gfortran.dg/merge_char_const.f90
Modified:
trunk/gcc/testsuite/ChangeLog

[Bug fortran/48543] Collapse identical strings

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48543

Dominique d'Humieres  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #6 from Dominique d'Humieres  ---
See https://gcc.gnu.org/ml/fortran/2019-01/msg00010.html.

[Bug fortran/48543] Collapse identical strings

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48543

Tamar Christina  changed:

   What|Removed |Added

 CC||tnfchris at gcc dot gnu.org

--- Comment #5 from Tamar Christina  ---
Hi,

The testcase seems to fail on 
aarch64-none-linux-gnu and  arm-none-linux-gnueabihf.

with

gfortran.dg/const_chararacter_merge.f90   -O  : Supercalifragilis found 2 times

[Bug fortran/48543] Collapse identical strings

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48543

Thomas Koenig  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Thomas Koenig  ---
Fixed (by whoever did this, thanks!) and test case committed, closing.

[Bug fortran/48543] Collapse identical strings

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48543

--- Comment #3 from Thomas Koenig  ---
Author: tkoenig
Date: Wed Jan  2 15:25:47 2019
New Revision: 267517

URL: https://gcc.gnu.org/viewcvs?rev=267517=gcc=rev
Log:
2019-01-02  Thomas Koenig  

PR fortran/48543
* gfortran.dg/const_chararacter_merge.f90: New test.


Added:
trunk/gcc/testsuite/gfortran.dg/const_chararacter_merge.f90
Modified:
trunk/gcc/testsuite/ChangeLog

[Bug fortran/48543] Collapse identical strings

[tkoenig at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48543

--- Comment #2 from Thomas Koenig tkoenig at gcc dot gnu.org 2012-06-07 
14:58:38 UTC ---
I'll do a bit of work on that, because it can also be useful
for reducing memcpy/memset pairs.

Consider

  character(len=3) :: a
  character(len=4) :: b
  a = 'a'
  b = 'a'

This could be changed into (in a first pass)

  a = 'a   '
  b = 'a'

for a simple assignment, but this would mean duplicate strings.
Better to change this into

  a = 'a'
  b = 'a'

[Bug fortran/48543] Collapse identical strings

[fxcoudert at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48543

Francois-Xavier Coudert fxcoudert at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2011-11-08
 CC||fxcoudert at gcc dot
   ||gnu.org
 Ever Confirmed|0   |1

[Bug fortran/48543] Collapse identical strings

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48543

Janne Blomqvist jb at gcc dot gnu.org changed:

   What|Removed |Added

 CC||jb at gcc dot gnu.org

--- Comment #1 from Janne Blomqvist jb at gcc dot gnu.org 2011-04-11 10:04:50 
UTC ---
For string constants, I agree, though I doubt whether it's worth the bother.

For string variables, I think this would be a mistake. Review the long and
sordid history of COW implementations of the C++ std::string type for arguments
why.