[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

Dominique d'Humieres  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #18 from Dominique d'Humieres  ---
> Unreopen.

Doing so;-)

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #17 from Steve Kargl  ---
On Wed, Nov 25, 2015 at 09:15:04AM +, jgreenhalgh at gcc dot gnu.org wrote:
> > 
> > Of course.  As I stated, it won't hurt anything.
> > FAILs in the testsuite are not a problem.  The
> > issue with EXPR_FUNCTION and cshift is a problem.
> 
> The hurt is for those of us investigating the new regressions... That was 10
> minutes of my time to investigate, multiply that by the number of people
> watching for FAILs on their favourite targets (particularly with trunk as it 
> is
> at the end of stage 1) there is certainly enough hurt to go round.
> 
> Please revert the broken testcase and leave it for when you fix pr68227.
> 

It took you 10 minutes to type 68227 into bugzilla's search feature?

I intend to commit the fix today.  Unfortunately, I have a real job
and fixing gfortran is a hobby.  Unnecessary code churn in the 
repo is well unnecessary.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[jgreenhalgh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

James Greenhalgh  changed:

   What|Removed |Added

 CC||jgreenhalgh at gcc dot gnu.org

--- Comment #16 from James Greenhalgh  ---
(In reply to Steve Kargl from comment #15)
> On Tue, Nov 24, 2015 at 07:48:19PM +, dominiq at lps dot ens.fr wrote:
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486
> > 
> > --- Comment #14 from Dominique d'Humieres  ---
> > > Not sure how the gcc/testsuite got on the end.  Oh well, the
> > > testcase won't hurt anything.
> > 
> > [Book15] f90/bug% gfca /opt/gcc/_clean/gcc/testsuite/gfortran.dg/pr68227.f90
> > /opt/gcc/_clean/gcc/testsuite/gfortran.dg/pr68227.f90:21:0:
> > 
> > forall (i=1:n) y(i)%a = x
> > 
> > 
> > internal compiler error: in gfc_do_allocate, at fortran/trans-stmt.c:3130
> > 
> > without your fix for pr68227.
> > 
> 
> Of course.  As I stated, it won't hurt anything.
> FAILs in the testsuite are not a problem.  The
> issue with EXPR_FUNCTION and cshift is a problem.

The hurt is for those of us investigating the new regressions... That was 10
minutes of my time to investigate, multiply that by the number of people
watching for FAILs on their favourite targets (particularly with trunk as it is
at the end of stage 1) there is certainly enough hurt to go round.

Please revert the broken testcase and leave it for when you fix pr68227.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #14 from Dominique d'Humieres  ---
> Not sure how the gcc/testsuite got on the end.  Oh well, the
> testcase won't hurt anything.

[Book15] f90/bug% gfca /opt/gcc/_clean/gcc/testsuite/gfortran.dg/pr68227.f90
/opt/gcc/_clean/gcc/testsuite/gfortran.dg/pr68227.f90:21:0:

forall (i=1:n) y(i)%a = x


internal compiler error: in gfc_do_allocate, at fortran/trans-stmt.c:3130

without your fix for pr68227.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #15 from Steve Kargl  ---
On Tue, Nov 24, 2015 at 07:48:19PM +, dominiq at lps dot ens.fr wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486
> 
> --- Comment #14 from Dominique d'Humieres  ---
> > Not sure how the gcc/testsuite got on the end.  Oh well, the
> > testcase won't hurt anything.
> 
> [Book15] f90/bug% gfca /opt/gcc/_clean/gcc/testsuite/gfortran.dg/pr68227.f90
> /opt/gcc/_clean/gcc/testsuite/gfortran.dg/pr68227.f90:21:0:
> 
> forall (i=1:n) y(i)%a = x
> 
> 
> internal compiler error: in gfc_do_allocate, at fortran/trans-stmt.c:3130
> 
> without your fix for pr68227.
> 

Of course.  As I stated, it won't hurt anything.
FAILs in the testsuite are not a problem.  The
issue with EXPR_FUNCTION and cshift is a problem.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #9 from Dominique d'Humieres  ---
> This one fails for me with -O2 ...

You don't need any optimization to reproduce. The ICE comes from the nested
CSHIFT.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #10 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Tue Nov 24 18:58:28 2015
New Revision: 230832

URL: https://gcc.gnu.org/viewcvs?rev=230832=gcc=rev
Log:
2015-11-24  Steven G. Kargl  

PR fortran/68486
* simplify.c (gfc_simplify_cshift): Allow all EXPR_*.

2015-11-24  Steven G. Kargl  

PR fortran/68486
* gfortran.dg/simplify_cshift_3.f90

Added:
trunk/gcc/testsuite/gfortran.dg/pr68227.f90
trunk/gcc/testsuite/gfortran.dg/simplify_cshift_3.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/simplify.c
trunk/gcc/testsuite/ChangeLog

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #11 from kargl at gcc dot gnu.org ---
Unreopen.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #12 from Dominique d'Humieres  ---
> Added:
> trunk/gcc/testsuite/gfortran.dg/pr68227.f90

Is it intended?

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #13 from Steve Kargl  ---
On Tue, Nov 24, 2015 at 07:07:44PM +, dominiq at lps dot ens.fr wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486
> 
> --- Comment #12 from Dominique d'Humieres  ---
> > Added:
> > trunk/gcc/testsuite/gfortran.dg/pr68227.f90
> 
> Is it intended?
> 

Of course, not.  Hmmm, seems I fat-fingered commit.

% svn commit gcc/fortran/ChangeLog gcc/fortran/simplify.c \
  gcc/testsuite/gfortran.dg/simplify_cshift_3.f90 gcc/testsuite/

Not sure how the gcc/testsuite got on the end.  Oh well, the
testcase won't hurt anything.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #7 from Steve Kargl  ---
On Tue, Nov 24, 2015 at 01:03:16PM +, hjl.tools at gmail dot com wrote:
> --- Comment #6 from H.J. Lu  ---
> 187.facerec in SPEC CPU 2000 still fails:
> 

Need an example the code causing the problem.  I don't have
access to SPEC CPU 2000.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

H.J. Lu  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #6 from H.J. Lu  ---
187.facerec in SPEC CPU 2000 still fails:

Breakpoint 1, gfc_simplify_cshift (array=0x2042670, shift=0x2042880, 
dim=) at ../../src-trunk/gcc/fortran/simplify.c:1824
1824gcc_unreachable ();
(gdb) p array->expr_type
$1 = EXPR_FUNCTION
(gdb) bt
#0  gfc_simplify_cshift (array=0x2042670, shift=0x2042880, dim=)
at ../../src-trunk/gcc/fortran/simplify.c:1824
#1  0x0060c252 in do_simplify (specific=specific@entry=0x1ff9c98, 
e=e@entry=0x20414d0) at ../../src-trunk/gcc/fortran/intrinsic.c:4150
#2  0x00615b4d in gfc_intrinsic_func_interface (
expr=expr@entry=0x20414d0, error_flag=error_flag@entry=1)
at ../../src-trunk/gcc/fortran/intrinsic.c:4499
#3  0x0065a1ab in resolve_unknown_f (expr=0x20414d0)
at ../../src-trunk/gcc/fortran/resolve.c:2707
#4  resolve_function (expr=0x20414d0)
at ../../src-trunk/gcc/fortran/resolve.c:3002
#5  gfc_resolve_expr (e=0x20414d0)
at ../../src-trunk/gcc/fortran/resolve.c:6334
#6  0x00657aa6 in resolve_operator (e=0x2043020)

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[izamyatin at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

Igor Zamyatin  changed:

   What|Removed |Added

 CC||izamyatin at gmail dot com

--- Comment #8 from Igor Zamyatin  ---
This one fails for me with -O2

Subroutine Foo ()

Real(4), Allocatable, Save :: tmp (:, :)
Real(4), Pointer, Save :: arr (:, :, :)

Integer :: l, m, n


tmp = (CSHIFT(CSHIFT(arr (:,:,l),m,2),n,1))

End Subroutine Foo

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

Richard Biener  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Richard Biener  ---
Fixed.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #3 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Sun Nov 22 19:41:20 2015
New Revision: 230726

URL: https://gcc.gnu.org/viewcvs?rev=230726=gcc=rev
Log:
2015-11-22  Steven G. Kargl  

PR fortran/68486
* simplify.c (gfc_simplify_cshift):  Add EXPR_OP to mix.

2015-11-22  Steven G. Kargl  

PR fortran/68486
* gfortran.dg/simplify_cshift_2.f90: New test.

Added:
trunk/gcc/testsuite/gfortran.dg/simplify_cshift_2.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/simplify.c
trunk/gcc/testsuite/ChangeLog

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

kargl at gcc dot gnu.org changed:

   What|Removed |Added

   Target Milestone|--- |6.0

--- Comment #4 from kargl at gcc dot gnu.org ---
Fixed on trunk with r230726.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

Dominique d'Humieres  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2015-11-22
 CC||kargl at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #2 from Dominique d'Humieres  ---
Confirmed. I have attached a test case. I think that the gcc_unreachable ();
should be replaced with a fallback to the intrinsic version in the library when
possible.

[Bug fortran/68486] [6 Regression] 187.facerec in SPEC CPU 2000 failed to build

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68486

--- Comment #1 from Dominique d'Humieres  ---
Created attachment 36804
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=36804=edit
Test showing the problem