[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[toon at moene dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

--- Comment #13 from Toon Moene  ---
On 07/11/2016 10:26 PM, tkoenig at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783
>
> Thomas Koenig  changed:
>
>What|Removed |Added
> 
>  Status|WAITING |RESOLVED
>  Resolution|--- |FIXED
>
> --- Comment #12 from Thomas Koenig  ---
> (In reply to Martin Liška from comment #11)
>> (In reply to Thomas Koenig from comment #10)
>>> Fixed on 5/6/7.  I don't have a working 4.9 compiler at the moment.
>>>
>>> Could anybody check if the fix also needs to be applied there?
>>
>> 4.9 is not affected by the PR.
>
> Thanks.
>
> Closing.
>

Thanks for working on this !

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

Thomas Koenig  changed:

   What|Removed |Added

 Status|WAITING |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Thomas Koenig  ---
(In reply to Martin Liška from comment #11)
> (In reply to Thomas Koenig from comment #10)
> > Fixed on 5/6/7.  I don't have a working 4.9 compiler at the moment.
> > 
> > Could anybody check if the fix also needs to be applied there?
> 
> 4.9 is not affected by the PR.

Thanks.

Closing.

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

--- Comment #11 from Martin Liška  ---
(In reply to Thomas Koenig from comment #10)
> Fixed on 5/6/7.  I don't have a working 4.9 compiler at the moment.
> 
> Could anybody check if the fix also needs to be applied there?

4.9 is not affected by the PR.

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

Thomas Koenig  changed:

   What|Removed |Added

 Status|NEW |WAITING

--- Comment #10 from Thomas Koenig  ---
Fixed on 5/6/7.  I don't have a working 4.9 compiler at the moment.

Could anybody check if the fix also needs to be applied there?

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

--- Comment #9 from Thomas Koenig  ---
Author: tkoenig
Date: Mon Jul 11 20:08:51 2016
New Revision: 238225

URL: https://gcc.gnu.org/viewcvs?rev=238225=gcc=rev
Log:
2016-07-11  Thomas Koenig  

Backport from trunk:
PR fortran/71783
* frontend-passes.c (create_var):  Always allocate a charlen
for character variables.

2016-07-11  Thomas Koenig  

Backport from trunk:
PR fortran/71783
* gfortran.dg/dependency_46.f90:  New test.


Added:
branches/gcc-5-branch/gcc/testsuite/gfortran.dg/dependency_46.f90
Modified:
branches/gcc-5-branch/gcc/fortran/ChangeLog
branches/gcc-5-branch/gcc/fortran/frontend-passes.c
branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

--- Comment #8 from Thomas Koenig  ---
Author: tkoenig
Date: Sun Jul 10 21:26:28 2016
New Revision: 238198

URL: https://gcc.gnu.org/viewcvs?rev=238198=gcc=rev
Log:
2016-07-09  Thomas Koenig  

Backport from trunk:
PR fortran/71783
* frontend-passes.c (create_var):  Always allocate a charlen
for character variables.

2016-07-09  Thomas Koenig  

Backport from trunk:
PR fortran/71783
* gfortran.dg/dependency_46.f90:  New test.


Added:
branches/gcc-6-branch/gcc/testsuite/gfortran.dg/dependency_46.f90
Modified:
branches/gcc-6-branch/gcc/fortran/ChangeLog
branches/gcc-6-branch/gcc/fortran/frontend-passes.c
branches/gcc-6-branch/gcc/testsuite/ChangeLog

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

--- Comment #7 from Thomas Koenig  ---
Author: tkoenig
Date: Sat Jul  9 22:18:29 2016
New Revision: 238192

URL: https://gcc.gnu.org/viewcvs?rev=238192=gcc=rev
Log:
2016-07-09  Thomas Koenig  

PR fortran/71783
* frontend-passes.c (create_var):  Always allocate a charlen
for character variables.

2016-07-09  Thomas Koenig  

PR fortran/71783
* gfortran.dg/dependency_46.f90:  New test.


Added:
trunk/gcc/testsuite/gfortran.dg/dependency_46.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/frontend-passes.c
trunk/gcc/testsuite/ChangeLog

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[toon at moene dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

--- Comment #6 from Toon Moene  ---
On 07/08/2016 11:15 PM, tkoenig at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783
>
> --- Comment #3 from Thomas Koenig  ---
> The solution turns that fixes the ICE turns out to be reasonably simple: We
> were missing a charlen for the allocatable case.
>
> What I do not yet understand is why this code was reached in the first place;
> the temporary assignment should never happen for this case.
>
> Index: frontend-passes.c
> ===
> --- frontend-passes.c   (Revision 237949)
> +++ frontend-passes.c   (Arbeitskopie)
> @@ -665,12 +665,10 @@ create_var (gfc_expr * e, const char *vname)
>  {
>gfc_expr *length;
>
> +  symbol->ts.u.cl = gfc_new_charlen (ns, NULL);
>length = constant_string_length (e);
>if (length)
> -   {
> - symbol->ts.u.cl = gfc_new_charlen (ns, NULL);
> - symbol->ts.u.cl->length = length;
> -   }
> +   symbol->ts.u.cl->length = length;
>else
> symbol->attr.allocatable = 1;
>  }
>
> Toon, does this fix the ICE for you as well?

This works for me on trunk - it is hard to see whether it invokes 
regressions, because those have been varying with various targets ...

Nevertheless, looks OK as a solution.

Thanks,

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

--- Comment #5 from Dominique d'Humieres  ---
> Toon, does this fix the ICE for you as well?

It does for me without regression.

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

kargl at gcc dot gnu.org changed:

   What|Removed |Added

 CC||brad.finney at humboldt dot edu

--- Comment #4 from kargl at gcc dot gnu.org ---
*** Bug 71782 has been marked as a duplicate of this bug. ***

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

--- Comment #3 from Thomas Koenig  ---
The solution turns that fixes the ICE turns out to be reasonably simple: We
were missing a charlen for the allocatable case.

What I do not yet understand is why this code was reached in the first place;
the temporary assignment should never happen for this case.

Index: frontend-passes.c
===
--- frontend-passes.c   (Revision 237949)
+++ frontend-passes.c   (Arbeitskopie)
@@ -665,12 +665,10 @@ create_var (gfc_expr * e, const char *vname)
 {
   gfc_expr *length;

+  symbol->ts.u.cl = gfc_new_charlen (ns, NULL);
   length = constant_string_length (e);
   if (length)
-   {
- symbol->ts.u.cl = gfc_new_charlen (ns, NULL);
- symbol->ts.u.cl->length = length;
-   }
+   symbol->ts.u.cl->length = length;
   else
symbol->attr.allocatable = 1;
 }

Toon, does this fix the ICE for you as well?

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

Richard Biener  changed:

   What|Removed |Added

   Priority|P3  |P4

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

--- Comment #2 from Richard Biener  ---
As the comment says the FE is failing to put 'cline' into a BIND_EXPR.  It has
a
'.cline' but not 'cline'.

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

Martin Liška  changed:

   What|Removed |Added

 CC||marxin at gcc dot gnu.org
   Target Milestone|--- |5.5

[Bug fortran/71783] [5/6/7 Regression ] ICE on valid code in gimplify_var_or_parm_decl at gimplify.c:1801

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71783

Martin Liška  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2016-07-06
Summary|ICE on valid code.  |[5/6/7 Regression ] ICE on
   ||valid code in
   ||gimplify_var_or_parm_decl
   ||at gimplify.c:1801
 Ever confirmed|0   |1

--- Comment #1 from Martin Liška  ---
Confirmed, started with GCC 5 branch.