[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

Thomas Koenig  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Thomas Koenig  ---
Fixed on all affected branches, closing.

[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

--- Comment #14 from Thomas Koenig  ---
Author: tkoenig
Date: Sun Feb 25 09:30:04 2018
New Revision: 257969

URL: https://gcc.gnu.org/viewcvs?rev=257969=gcc=rev
Log:
2018-02-25  Thomas Koenig  

PR fortran/78238
Backport from trunk
* gfortran.h (gfc_integer_4_kind): Define.
* resolve.c (resolve_select_type): Make sure that the
kind of c->high is gfc_integer_4_kind.

2018-02-25  Thomas Koenig  

PR fortran/78238
Backport from trunk
* gfortran.dg/select_type_40.f90: New test.


Added:
branches/gcc-7-branch/gcc/testsuite/gfortran.dg/select_type_40.f90
Modified:
branches/gcc-7-branch/gcc/fortran/ChangeLog
branches/gcc-7-branch/gcc/fortran/gfortran.h
branches/gcc-7-branch/gcc/fortran/resolve.c
branches/gcc-7-branch/gcc/testsuite/ChangeLog

[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

--- Comment #13 from Thomas Koenig  ---
Author: tkoenig
Date: Sun Feb 25 09:02:32 2018
New Revision: 257968

URL: https://gcc.gnu.org/viewcvs?rev=257968=gcc=rev
Log:
2018-02-25  Thomas Koenig  

PR fortran/78238
* gfortran.h (gfc_integer_4_kind): Define.
* resolve.c (resolve_select_type): Make sure that the
kind of c->high is gfc_integer_4_kind.

2018-02-25  Thomas Koenig  

PR fortran/78238
* gfortran.dg/select_type_40.f90: New test.


Added:
trunk/gcc/testsuite/gfortran.dg/select_type_40.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/resolve.c
trunk/gcc/testsuite/ChangeLog

[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

Thomas Koenig  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |tkoenig at gcc dot 
gnu.org

--- Comment #12 from Thomas Koenig  ---
_hash is an integer(4) in all cases:

$ gfortran -fdefault-integer-8 -fdump-fortran-original a.f90 2>/dev/null  |
grep hash
(_hash (INTEGER 4) () PRIVATE) 
(_hash (INTEGER 4) () PRIVATE) 
$ gfortran -fdump-fortran-original a.f90 2>/dev/null  | grep hash
(_hash (INTEGER 4) () PRIVATE) 
(_hash (INTEGER 4) () PRIVATE)

Probably the constant has the wrong type.

[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

Thomas Koenig  changed:

   What|Removed |Added

 CC||tkoenig at gcc dot gnu.org

--- Comment #11 from Thomas Koenig  ---
At the place where the ICE happens:

 gcc_checking_assert (precision == x.get_precision ());

(gdb) p precision
$1 = 64
(gdb) p x
$2 = (const generic_wide_int &) @0x7fffca10:
{ = {val = {-1, 140737340585456, 140737340585456}, len = 1, 
precision = 32}, static is_sign_extended = }

Looking up the call chain, the following can be found:

gimple_simplify_174 (res_code=0x7fffcbcc, res_ops=0x7fffcbd0,
type=0x77168b28, captures=0x7fffcad0, cmp=EQ_EXPR, 
valueize=0xad6320 , seq=0x7fffcd18) at
gimple-match.c:7605

so it can be assumed that the type of a comparison goes wrong.

Hmm... there is no difference visible in the tree dumps. However,
there is the line

  if (x->_vptr->_hash == 64409183)

in the dump. Maybe the types on the left and right hand sides do
not agree?

[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

Richard Biener  changed:

   What|Removed |Added

   Target Milestone|7.3 |7.4

--- Comment #10 from Richard Biener  ---
GCC 7.3 is being released, adjusting target milestone.

[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[gs...@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

G. Steinmetz  changed:

   What|Removed |Added

 CC||gs...@t-online.de

--- Comment #9 from G. Steinmetz  ---
While gcc configured with --enable-checking=yes,
the ICE has changed between 20170924 (ICE: verify_gimple failed)
and 20171015 (ICE in decompose), today :


$ gfortran-8-20171126 -fdefault-integer-8 -c z1.f90
z1.f90:1:0:

 program p

internal compiler error: in decompose, at wide-int.h:935
0x617319 wi::int_traits::decompose(long*,
unsigned int, generic_wide_int const&)
../../gcc/wide-int.h:935
0x1061853 wi::int_traits::decompose(long*,
unsigned int, generic_wide_int const&)
../../gcc/tree.h:3472
0x1061853 wide_int_ref_storage::wide_int_ref_storage(generic_wide_int const&, unsigned int)
../../gcc/wide-int.h:983
0x1061853 generic_wide_int
>::generic_wide_int(generic_wide_int const&, unsigned int)
../../gcc/wide-int.h:760
0x1061853 wi::binary_traits
>, generic_wide_int,
wi::int_traits >
>::precision_type, wi::int_traits::precision_type>::result_type
wi::bit_and_not >,
generic_wide_int
>(generic_wide_int > const&,
generic_wide_int const&)
../../gcc/wide-int.h:2250
0x1061853 gimple_simplify_10
/gcc/gimple-match.c:1311
0x10e2111 gimple_simplify_EQ_EXPR
/gcc/gimple-match.c:62577
0x106b725 gimple_simplify
/gcc/gimple-match.c:72958
0x106cc0b gimple_resimplify2(gimple**, code_helper*, tree_node*, tree_node**,
tree_node* (*)(tree_node*))
../../gcc/gimple-match-head.c:165
0x11405ba gimple_simplify(gimple*, code_helper*, tree_node**, gimple**,
tree_node* (*)(tree_node*), tree_node* (*)(tree_node*))
../../gcc/gimple-match-head.c:763
0xa0b041 fold_stmt_1
../../gcc/gimple-fold.c:4631
0xa2d7f2 gimplify_cond_expr
../../gcc/gimplify.c:4009
0xa23fe4 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:11297
0xa28816 gimplify_stmt(tree_node**, gimple**)
../../gcc/gimplify.c:6556
0xa23a1b gimplify_statement_list
../../gcc/gimplify.c:1736
0xa23a1b gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:11769
0xa28816 gimplify_stmt(tree_node**, gimple**)
../../gcc/gimplify.c:6556
0xa29b0d gimplify_bind_expr
../../gcc/gimplify.c:1294
0xa241aa gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
../../gcc/gimplify.c:11541
0xa28816 gimplify_stmt(tree_node**, gimple**)
../../gcc/gimplify.c:6556

[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

Richard Biener  changed:

   What|Removed |Added

   Target Milestone|7.2 |7.3

[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

Richard Biener  changed:

   What|Removed |Added

   Target Milestone|7.2 |7.3

--- Comment #9 from Richard Biener  ---
GCC 7.2 is being released, adjusting target milestone.

[Bug fortran/78238] [7/8 Regression] [OOP] ICE: verify_gimple failed, with -fdefault-integer-8

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78238

Jakub Jelinek  changed:

   What|Removed |Added

   Target Milestone|7.0 |7.2

--- Comment #8 from Jakub Jelinek  ---
GCC 7.1 has been released.