[Bug fortran/80254] Windows test failure: dec_io_2.f90

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

Thomas Koenig  changed:

   What|Removed |Added

 Status|WAITING |RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Thomas Koenig  ---
Fixed, closing.

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

--- Comment #10 from Thomas Koenig  ---
Author: tkoenig
Date: Wed Mar 29 17:30:58 2017
New Revision: 246573

URL: https://gcc.gnu.org/viewcvs?rev=246573=gcc=rev
Log:
2017-03-28  Thomas Koenig  

PR fortran/80254
* gfortran.dg/dec_io_2.f90:  Do not run on MINGW, run
* gfortran.dg/dec_io_2a.f90:  instead (new test).


Added:
trunk/gcc/testsuite/gfortran.dg/dec_io_2a.f90
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gfortran.dg/dec_io_2.f90

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[nightstrike at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

--- Comment #9 from nightstrike  ---
Ok, your new _2a test just for mingw works like a champ:

# of expected passes12

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[nightstrike at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

--- Comment #8 from nightstrike  ---
(In reply to nightstrike from comment #7)
> (In reply to Thomas Koenig from comment #6)
> > Created attachment 41077 [details]
> > Patch for failing test case
> > 
> > The patch works for me on linux (i.e. the test is still
> > execuated, and doesn't fail).  The _2a test case is not
> > executed, as expected.
> > 
> > How do the two work out on a mingw system?
> 
> On mingw (I tested x86_64-w64-mingw32), the tests switch from FAIL to
> UNSUPPORTED.
> 
> On cygwin, they go from PASS to PASS (as expected).
> 
> But what about Janne's comment here:
> https://gcc.gnu.org/ml/fortran/2017-03/msg00141.html
> 
> ?

Sorry, I was being dumb.  I tested that the disabled testcase is actually
disabled.  I didn't notice that you added a new one just for mingw.  Testing
that now.

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[nightstrike at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

--- Comment #7 from nightstrike  ---
(In reply to Thomas Koenig from comment #6)
> Created attachment 41077 [details]
> Patch for failing test case
> 
> The patch works for me on linux (i.e. the test is still
> execuated, and doesn't fail).  The _2a test case is not
> executed, as expected.
> 
> How do the two work out on a mingw system?

On mingw (I tested x86_64-w64-mingw32), the tests switch from FAIL to
UNSUPPORTED.

On cygwin, they go from PASS to PASS (as expected).

But what about Janne's comment here:
https://gcc.gnu.org/ml/fortran/2017-03/msg00141.html

?

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

--- Comment #6 from Thomas Koenig  ---
Created attachment 41077
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41077=edit
Patch for failing test case

The patch works for me on linux (i.e. the test is still
execuated, and doesn't fail).  The _2a test case is not
executed, as expected.

How do the two work out on a mingw system?

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

--- Comment #5 from Thomas Koenig  ---
Created attachment 41076
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41076=edit
Proposed test case for mingw

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[nightstrike at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

--- Comment #4 from nightstrike  ---
(In reply to nightstrike from comment #3)
> The cygwin default line ending style is UNIX like.

This test currently passes on cygwin as-is.

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[nightstrike at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

--- Comment #3 from nightstrike  ---
The cygwin default line ending style is UNIX like.

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

Thomas Koenig  changed:

   What|Removed |Added

 CC||tkoenig at gcc dot gnu.org

--- Comment #2 from Thomas Koenig  ---
It is probably best to run this test case only on Unixoid
systems, and create a separate one for Windows where the
output that is checked.

So, add something like

! { dg-do run { target { ! { *-*-mingw* *-*-cygwin* spu-*-* } } } }

to dec_io_2.f90

(check what SPU is, though)

and create a new test case with something like

! { dg-do run { target  *-*-mingw* *-*-cygwin* spu-*-* } }

...

character(*), parameter :: output_cclist = &
  "+ first"//CHAR(13)//CHAR(10)//&
  "-second line"//CHAR(13)//CHAR(10)//&
  "0now you know"//CHAR(13)//CHAR(10)//&
  "1this is the fourth line"//CHAR(13)//CHAR(10)//&
  "$finally we have a new challenger for the final line"//CHAR(13)//CHAR(10)//&
  CHAR(0)//"this is the end"//CHAR(13)//CHAR(10)//&
  " this is a plain old line"//CHAR(13)//CHAR(10)

[Bug fortran/80254] Windows test failure: dec_io_2.f90

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80254

Dominique d'Humieres  changed:

   What|Removed |Added

 Status|UNCONFIRMED |WAITING
   Last reconfirmed||2017-03-29
 CC||foreese at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #1 from Dominique d'Humieres  ---
CCed Fritz Reese.