[Bug fortran/91717] ICE on concatenating deferred-length character and character literal

2019-09-12 Thread pault at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91717

Paul Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Paul Thomas  ---
Fixed on trunk

Thanks for the PR

Paul

[Bug fortran/91717] ICE on concatenating deferred-length character and character literal

2019-09-12 Thread pault at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91717

--- Comment #5 from Paul Thomas  ---
Author: pault
Date: Fri Sep 13 05:41:01 2019
New Revision: 275696

URL: https://gcc.gnu.org/viewcvs?rev=275696=gcc=rev
Log:
2019-09-13  Paul Thomas  

PR fortran/91717
* dependency.c (gfc_dep_resolver): Flag identical components
and exit with return value 1 if set and no array refs.

2019-09-13  Paul Thomas  

PR fortran/91717
* gfortran.dg/dependency_55.f90 : New test.


Added:
trunk/gcc/testsuite/gfortran.dg/dependency_55.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/dependency.c
trunk/gcc/testsuite/ChangeLog

[Bug fortran/91717] ICE on concatenating deferred-length character and character literal

2019-09-12 Thread paul.richard.thomas at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91717

--- Comment #4 from paul.richard.thomas at gmail dot com  ---
Yes it is - the .false. on entry comes about because the allocatable
component must be deallocated on entry to scope. The reallocation on
assignment takes care of the rest.

Cheers

Paul

On Thu, 12 Sep 2019 at 11:03, dominiq at lps dot ens.fr
 wrote:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91717
>
> --- Comment #3 from Dominique d'Humieres  ---
> The patch at https://gcc.gnu.org/ml/fortran/2019-09/msg00027.html
> fixes the ICE and the test
>
>   type core
> character (len=:), allocatable :: msg
>   end type
>
>   type(core) :: my_core
>
>   print *, allocated(my_core%msg)
>
>   type core
> character (len=:), allocatable :: msg
>   end type
>
>   type(core) :: my_core
>
>   print *, allocated(my_core%msg)
>
>   my_core%msg = "test"
>   print *, allocated(my_core%msg), len(my_core%msg)
>
>   my_core%msg = my_core%msg//"message"
>
>   print *, allocated(my_core%msg)
>   print *, ">", my_core%msg, "<"
>
> end
>
> gives
>
>  F
>  T   4
>  T
>  >testmessage<
>
> Is this the expected result?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
> You are the assignee for the bug.

[Bug fortran/91717] ICE on concatenating deferred-length character and character literal

2019-09-12 Thread dominiq at lps dot ens.fr
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91717

--- Comment #3 from Dominique d'Humieres  ---
The patch at https://gcc.gnu.org/ml/fortran/2019-09/msg00027.html
fixes the ICE and the test

  type core
character (len=:), allocatable :: msg
  end type

  type(core) :: my_core

  print *, allocated(my_core%msg)

  type core
character (len=:), allocatable :: msg
  end type

  type(core) :: my_core

  print *, allocated(my_core%msg)

  my_core%msg = "test"
  print *, allocated(my_core%msg), len(my_core%msg)

  my_core%msg = my_core%msg//"message"

  print *, allocated(my_core%msg)
  print *, ">", my_core%msg, "<"

end

gives

 F
 T   4
 T
 >testmessage<

Is this the expected result?

[Bug fortran/91717] ICE on concatenating deferred-length character and character literal

2019-09-09 Thread pault at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91717

Paul Thomas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2019-09-10
 CC||pault at gcc dot gnu.org
   Assignee|unassigned at gcc dot gnu.org  |pault at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #2 from Paul Thomas  ---
Created attachment 46858
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=46858=edit
Fix for the PR

Thanks for the report, Damian,

The attached regests OK.

Paul

[Bug fortran/91717] ICE on concatenating deferred-length character and character literal

2019-09-09 Thread damian at sourceryinstitute dot org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91717

--- Comment #1 from Damian Rouson  ---
FYI, this reproducer was developed by Paul Thomas based on my report that the
gfortran trunk is unable to build the json-fortran repository
(https://jacobwilliams.github.io/json-fortran/).