[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 Andrew Benson changed: What|Removed |Added CC||abensonca at gcc dot gnu.org Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #12 from Andrew Benson --- No - this can be resolved - PR87103 was resolved which fixed the remaining issue with this PR. Apologies for not resolving sooner.
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 --- Comment #11 from anlauf at gcc dot gnu.org --- Anything left to do? I looked at the gcc-testresults, and it appears things are fixed now, e.g. for Solaris or aarch64.
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 --- Comment #10 from Andrew Benson --- PR87103 is now resolved, which should also solve this problem.
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 Christophe Lyon changed: What|Removed |Added CC||clyon at gcc dot gnu.org --- Comment #9 from Christophe Lyon --- (In reply to Rainer Orth from comment #7) > The new testcase ICEs on i386-pc-solaris2.11 and sparc-sun-solaris2.11 (both > 32 > and 64-bit) as well as powerpc64-unknown-linux-gnu and > powerpc64le-unknown-linux-gnu: > > +FAIL: gfortran.dg/pr93473.f90 -O (internal compiler error) > +FAIL: gfortran.dg/pr93473.f90 -O (test for excess errors) > Fails on arm and aarch64 too.
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 --- Comment #8 from Andrew Benson --- I think this is PR87103 causing this problem. There's a patch in that PR (simply removing the check for the overlong symbol name also works as the symbol name length is already checked elsewhere). The patch has not been approved though as there's a better fix in the works -see https://gcc.gnu.org/ml/fortran/2018-09/msg00016.html
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 Rainer Orth changed: What|Removed |Added Status|RESOLVED|REOPENED CC||ro at gcc dot gnu.org Resolution|FIXED |--- --- Comment #7 from Rainer Orth --- The new testcase ICEs on i386-pc-solaris2.11 and sparc-sun-solaris2.11 (both 32 and 64-bit) as well as powerpc64-unknown-linux-gnu and powerpc64le-unknown-linux-gnu: +FAIL: gfortran.dg/pr93473.f90 -O (internal compiler error) +FAIL: gfortran.dg/pr93473.f90 -O (test for excess errors) Excess errors: f951: internal compiler error: new_symbol(): Symbol name too long 0x8b450a2 gfc_report_diagnostic /vol/gcc/src/hg/master/local/gcc/fortran/error.c:782 0x8b450a2 gfc_internal_error(char const*, ...) /vol/gcc/src/hg/master/local/gcc/fortran/error.c:1402 0x8bebb58 gfc_new_symbol(char const*, gfc_namespace*) /vol/gcc/src/hg/master/local/gcc/fortran/symbol.c:3139 0x8b8bb5b read_module /vol/gcc/src/hg/master/local/gcc/fortran/module.c:5398 0x8b8bb5b gfc_use_module /vol/gcc/src/hg/master/local/gcc/fortran/module.c:7192 0x8b8e216 gfc_use_modules() /vol/gcc/src/hg/master/local/gcc/fortran/module.c:7316 0x8b9e6bc use_modules /vol/gcc/src/hg/master/local/gcc/fortran/parse.c:114 0x8baa73a parse_module /vol/gcc/src/hg/master/local/gcc/fortran/parse.c:6111 0x8baab4c gfc_parse_file() /vol/gcc/src/hg/master/local/gcc/fortran/parse.c:6428 0x8bfbffd gfc_be_parse_file /vol/gcc/src/hg/master/local/gcc/fortran/f95-lang.c:210
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 Andrew Benson changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Andrew Benson --- Fixed by https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=commit;h=a83b5cc5828ee34471de415e8893242dd3b0a91b
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 --- Comment #5 from CVS Commits --- The master branch has been updated by Andrew Benson : https://gcc.gnu.org/g:a83b5cc5828ee34471de415e8893242dd3b0a91b commit r10-6295-ga83b5cc5828ee34471de415e8893242dd3b0a91b Author: Andrew Benson Date: Tue Jan 28 17:58:40 2020 + Allow concatenated module+submodule names. Increase length of char variables "parent1" and "parent2" in set_syms_host_assoc() to allow them to hold concatenated module + submodule names. PR fortran/93473 * parse.c: Increase length of char variables to allow them to hold a concatenated module + submodule name. * gfortran.dg/pr93473.f90: New test.
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 --- Comment #4 from Andrew Benson --- @Martin - yes, thanks for the reminder, I'll send the updated patch to the GCC mailing list.
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 Martin Liška changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed||2020-01-28 CC||marxin at gcc dot gnu.org Assignee|unassigned at gcc dot gnu.org |abensonca at gmail dot com Ever confirmed|0 |1 --- Comment #3 from Martin Liška --- @Andrew: Can you please send a patch to GCC ML?
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 --- Comment #2 from Andrew Benson --- Problem occurs in set_syms_host_assoc() where the "parent1" and "parent2" variables have a maximum length of GFC_MAX_SYMBOL_LEN+1. This is insufficient when the parent names are a module+submodule name concatenated with a ".". The patch above fixes this by increasing their length to 2*GFC_MAX_SYMBOL_LEN+2.
[Bug fortran/93473] ICE on valid with long module + submodule names
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93473 --- Comment #1 from Andrew Benson --- Created attachment 47722 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=47722=edit Proposed patch
