[Bug go/89019] LTO and gccgo cause ICE during free_lang_data

[nikhil.benesch at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89019

Nikhil Benesch  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Nikhil Benesch  ---
This is fixed for me now.

[Bug go/89019] LTO and gccgo cause ICE during free_lang_data

[ian at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89019

--- Comment #3 from ian at gcc dot gnu.org  ---
Author: ian
Date: Wed Feb  6 04:48:35 2019
New Revision: 268572

URL: https://gcc.gnu.org/viewcvs?rev=268572=gcc=rev
Log:
gcc/go:
PR go/89019
* go-gcc.cc (Gcc_backend::placeholder_struct_type): Mark
placeholder structs as requiring structural equality.
(Gcc_backend::set_placeholder_pointer_type): Propagate the
canonical type from the desired pointer type to the placeholder
pointer type.
gcc/testsuite/:
* lib/go-torture.exp: Test compiling with -flto.

Modified:
trunk/gcc/go/ChangeLog
trunk/gcc/go/go-gcc.cc
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/lib/go-torture.exp

[Bug go/89019] LTO and gccgo cause ICE during free_lang_data

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89019

--- Comment #2 from Ian Lance Taylor  ---
Thanks for looking into this.  The patch looks fine, want to send it to
gcc-patches with a ChangeLog entry?  CC i...@golang.org.  Thanks.

[Bug go/89019] LTO and gccgo cause ICE during free_lang_data

[nikhil.benesch at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89019

Nikhil Benesch  changed:

   What|Removed |Added

  Attachment #45515|0   |1
is obsolete||

--- Comment #1 from Nikhil Benesch  ---
Created attachment 45516
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=45516=edit
complete patch

I tracked down the ICE revealed by names-1.go. The problem was quite similar;
placeholder structs, and not just placeholder pointers, need special handling
of TYPE_CANONICAL.