[Bug ipa/65059] [5 Regression] Chrome LTO: lto1: internal compiler error: in ipa_comdats, at ipa-comdats.c:360

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65059

--- Comment #3 from Martin Liška marxin at gcc dot gnu.org ---
Author: marxin
Date: Mon Feb 16 12:28:40 2015
New Revision: 220733

URL: https://gcc.gnu.org/viewcvs?rev=220733root=gccview=rev
Log:
Fix PR ipa/65059.

PR ipa/65059
* ipa-comdats.c (ipa_comdats): Do not categorize thunks to
external functions.


Modified:
trunk/gcc/ChangeLog
trunk/gcc/ipa-comdats.c

[Bug ipa/65059] [5 Regression] Chrome LTO: lto1: internal compiler error: in ipa_comdats, at ipa-comdats.c:360

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65059

Marek Polacek mpolacek at gcc dot gnu.org changed:

   What|Removed |Added

 CC||mpolacek at gcc dot gnu.org

--- Comment #4 from Marek Polacek mpolacek at gcc dot gnu.org ---
So fixed?

[Bug ipa/65059] [5 Regression] Chrome LTO: lto1: internal compiler error: in ipa_comdats, at ipa-comdats.c:360

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65059

Martin Liška marxin at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Martin Liška marxin at gcc dot gnu.org ---
Fixed in 5.0.

[Bug ipa/65059] [5 Regression] Chrome LTO: lto1: internal compiler error: in ipa_comdats, at ipa-comdats.c:360

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65059

Richard Biener rguenth at gcc dot gnu.org changed:

   What|Removed |Added

   Priority|P3  |P1
   Target Milestone|--- |5.0

[Bug ipa/65059] [5 Regression] Chrome LTO: lto1: internal compiler error: in ipa_comdats, at ipa-comdats.c:360

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65059

--- Comment #2 from Martin Liška marxin at gcc dot gnu.org ---
Thank you Honza, patch works for.

Martin

[Bug ipa/65059] [5 Regression] Chrome LTO: lto1: internal compiler error: in ipa_comdats, at ipa-comdats.c:360

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65059

--- Comment #1 from Jan Hubicka hubicka at gcc dot gnu.org ---
Does the following help?
Index: ipa-comdats.c
===
--- ipa-comdats.c   (revision 220606)
+++ ipa-comdats.c   (working copy)
@@ -328,9 +328,14 @@ ipa_comdats (void)

   FOR_EACH_DEFINED_SYMBOL (symbol)
 {
+  struct cgraph_node *fun;
   symbol-aux = NULL; 
   if (!symbol-get_comdat_group ()
   !symbol-alias
+ /* Thunks to external functions do not need to be categorized.  */
+  (!(fun = dyn_cast cgraph_node * (symbol))
+ || !fun-thunk.thunk_p
+ || fun-function_symbol ()-definition)
   symbol-real_symbol_p ())
{
  tree *val = map.get (symbol);