[Bug ipa/65972] ICE after applying a patch to enable verify_ssa with auto-pgo

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

Martin Liška  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Martin Liška  ---
Fixed on all active branches.

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa with auto-pgo

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

--- Comment #14 from Martin Liška  ---
Author: marxin
Date: Mon May 29 09:13:20 2017
New Revision: 248568

URL: https://gcc.gnu.org/viewcvs?rev=248568=gcc=rev
Log:
Backport r246996

2017-05-29  Martin Liska  

Backport from mainline
2017-04-19  Richard Biener  

PR ipa/65972
* auto-profile.c (afdo_vpt_for_early_inline): Update SSA
when needed by AutoPGO.

Modified:
branches/gcc-5-branch/gcc/ChangeLog
branches/gcc-5-branch/gcc/auto-profile.c

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa with auto-pgo

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

--- Comment #13 from Martin Liška  ---
Author: marxin
Date: Fri May 26 11:31:52 2017
New Revision: 248503

URL: https://gcc.gnu.org/viewcvs?rev=248503=gcc=rev
Log:
Backport r246996

2017-05-26  Martin Liska  

Backport from mainline
2017-04-19  Richard Biener  

PR ipa/65972
* auto-profile.c (afdo_vpt_for_early_inline): Update SSA
when needed by AutoPGO.

Modified:
branches/gcc-6-branch/gcc/ChangeLog
branches/gcc-6-branch/gcc/auto-profile.c

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa with auto-pgo

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

Martin Liška  changed:

   What|Removed |Added

  Known to work||7.0.1
  Known to fail||5.4.0, 6.3.0

--- Comment #12 from Martin Liška  ---
Fixed on trunk, queued for active branches.

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa with auto-pgo

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

--- Comment #11 from Martin Liška  ---
Author: marxin
Date: Wed Apr 19 12:06:35 2017
New Revision: 246996

URL: https://gcc.gnu.org/viewcvs?rev=246996=gcc=rev
Log:
Update SSA after AutoPGO early inlining (PR ipa/65972).

2017-04-19  Richard Biener  

PR ipa/65972
* auto-profile.c (afdo_vpt_for_early_inline): Update SSA
when needed by AutoPGO.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/auto-profile.c

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa with auto-pgo

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

Martin Liška  changed:

   What|Removed |Added

   Assignee|unassigned at gcc dot gnu.org  |marxin at gcc dot 
gnu.org

--- Comment #10 from Martin Liška  ---
I'm testing the suggested patch.

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa with auto-pgo

[spop at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

--- Comment #9 from Sebastian Pop  ---
In the link in the previous comment, Richi has a similar patch as suggested by
Dehao pending review/test/commit: let's close this bug when Richi's patch lands
in trunk.

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa with auto-pgo

[spop at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

--- Comment #8 from Sebastian Pop  ---
Yes please!
This patch also solves the problem I was chasing a week or so ago:

https://gcc.gnu.org/ml/gcc-patches/2017-04/msg00067.html

I also know that this is ICE-ing on a large proprietary project when I compile
it with autoFDO on gcc-5.x and 6.x releases.

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa with auto-pgo

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

Martin Liška  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2017-04-18
 CC||marxin at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #7 from Martin Liška  ---
Looks the patch hasn't been applied to trunk. Should I test it and send to ML?

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa

[hiraditya at msn dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

--- Comment #6 from AK hiraditya at msn dot com ---
Your patch did fix the problem. Thanks!

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa

[dehao at google dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

--- Comment #5 from Dehao Chen dehao at google dot com ---
Could you try if the following patch fixes the bug?

Thanks,
Dehao

Index: gcc/auto-profile.c
===
--- gcc/auto-profile.c  (revision 223204)
+++ gcc/auto-profile.c  (working copy)
@@ -1470,6 +1470,7 @@ afdo_vpt_for_early_inline (stmt_set *promoted_stmt
   if (has_vpt)
 {
   optimize_inline_calls (current_function_decl);
+  update_ssa (TODO_update_ssa);
   return true;
 }

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa

[spop at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

Sebastian Pop spop at gcc dot gnu.org changed:

   What|Removed |Added

 CC||dehao at gcc dot gnu.org,
   ||dehao at google dot com

--- Comment #4 from Sebastian Pop spop at gcc dot gnu.org ---
This patch seems to fix the problem:

diff --git a/gcc/auto-profile.c b/gcc/auto-profile.c
index ba2d5ab..6bd296a 100644
--- a/gcc/auto-profile.c
+++ b/gcc/auto-profile.c
@@ -1547,6 +1547,9 @@ afdo_annotate_cfg (const stmt_set promoted_stmts)
 static void
 early_inline ()
 {
+  /* compute_inline_parameters needs an up to date SSA form.  */
+  update_ssa (TODO_update_ssa);
+
   compute_inline_parameters (cgraph_node::get (current_function_decl), true);
   unsigned todo = early_inliner (cfun);
   if (todo  TODO_update_ssa_any)


We have not verified yet which other pass is causing the SSA to be in an
inconsistent state: instead of adding a call to update_ssa() at this place, we
should have a verify_ssa(), and fix the other pass.

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

Richard Biener rguenth at gcc dot gnu.org changed:

   What|Removed |Added

 CC||rguenth at gcc dot gnu.org

--- Comment #2 from Richard Biener rguenth at gcc dot gnu.org ---
Can you attach preprocessed source for unwind-arm.c?

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa

[hiraditya at msn dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

--- Comment #3 from AK hiraditya at msn dot com ---
Created attachment 35457
  -- https://gcc.gnu.org/bugzilla/attachment.cgi?id=35457action=edit
Preprocesed unwind-arm.i

[Bug ipa/65972] ICE after applying a patch to enable verify_ssa

[hiraditya at msn dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65972

--- Comment #1 from AK hiraditya at msn dot com ---
PS: The bootstrap fails after applying this patch and emits the error reported
above.