[Bug libfortran/45165] unix.c:fallback_access() leaks file descriptors

[fxcoudert at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45165

--- Comment #2 from Francois-Xavier Coudert fxcoudert at gcc dot gnu.org 
2011-02-26 15:21:51 UTC ---
Author: fxcoudert
Date: Sat Feb 26 15:21:45 2011
New Revision: 170517

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=170517
Log:
PR libfortran/45165
* unix.c (fallback_access): Fix file descriptor leaks.

Modified:
trunk/libgfortran/ChangeLog
trunk/libgfortran/io/unix.c

[Bug libfortran/45165] unix.c:fallback_access() leaks file descriptors

[fxcoudert at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45165

Francois-Xavier Coudert fxcoudert at gcc dot gnu.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED
   Target Milestone|--- |4.6.0

--- Comment #3 from Francois-Xavier Coudert fxcoudert at gcc dot gnu.org 
2011-02-26 15:22:35 UTC ---
Fixed on trunk.

[Bug libfortran/45165] unix.c:fallback_access() leaks file descriptors

[fxcoudert at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45165

Francois-Xavier Coudert fxcoudert at gcc dot gnu.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|unassigned at gcc dot   |fxcoudert at gcc dot
   |gnu.org |gnu.org

[Bug libfortran/45165] unix.c:fallback_access() leaks file descriptors

[fxcoudert at gcc dot gnu dot org]

--- Comment #1 from fxcoudert at gcc dot gnu dot org  2010-08-23 08:39 
---
Index: io/unix.c
===
--- io/unix.c   (revision 163225)
+++ io/unix.c   (working copy)
@@ -151,11 +151,15 @@
 static int
 fallback_access (const char *path, int mode)
 {
-  if ((mode  R_OK)  open (path, O_RDONLY)  0)
+  int fd;
+
+  if ((mode  R_OK)  (fd = open (path, O_RDONLY))  0)
 return -1;
+  close (fd);

-  if ((mode  W_OK)  open (path, O_WRONLY)  0)
+  if ((mode  W_OK)  (fd = open (path, O_WRONLY))  0)
 return -1;
+  close (fd);

   if (mode == F_OK)
 {


-- 

fxcoudert at gcc dot gnu dot org changed:

   What|Removed |Added

 CC||fxcoudert at gcc dot gnu dot
   ||org
 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2010-08-23 08:39:57
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45165