[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[pinskia at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

Andrew Pinski  changed:

   What|Removed |Added

   Target Milestone|--- |9.0
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Andrew Pinski  ---
Fixed in GCC 9 as all earlier branches are no longer supported.

[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

Martin Liška  changed:

   What|Removed |Added

  Known to work||9.0

--- Comment #8 from Martin Liška  ---
If you are planning backport, then please close the PR as soon as you'll
install backport to all active branches. Thanks.
Update of Known to fail would be appreciated.

[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

--- Comment #7 from Andreas Tobler  ---
I can do a backport w/o an open PR' right? If so, then the PR can be set to
resolved.

[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

Martin Liška  changed:

   What|Removed |Added

 CC||marxin at gcc dot gnu.org

--- Comment #6 from Martin Liška  ---
Andreas: Can the bug be marked as resolved?

[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

--- Comment #5 from Andreas Tobler  ---
Author: andreast
Date: Fri Apr 27 19:14:05 2018
New Revision: 259722

URL: https://gcc.gnu.org/viewcvs?rev=259722=gcc=rev
Log:
2018-04-27  Andreas Tobler  
Maryse Levavasseur 

PR libgcc/84292
* config/arm/freebsd-atomic.c (SYNC_OP_AND_FETCH_N): Fix the
op_and_fetch to return the right result.

Modified:
trunk/libgcc/ChangeLog
trunk/libgcc/config/arm/freebsd-atomic.c

[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[maryse.levavasseur at stormshield dot eu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

--- Comment #4 from Maryse LEVAVASSEUR  ---
Hi Andreas,
No problem for the delay, thanks for all !

[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

Andreas Tobler  changed:

   What|Removed |Added

   Last reconfirmed|2018-02-08 00:00:00 |2018-4-1

--- Comment #3 from Andreas Tobler  ---
I could reproduce the issue and I can confirm that the attached patch fixes the
issue.
Once the long awaited gcc-8.x gets released I'll commit the fix to all active
branches and I'll take care that we update the FreeBSD ports tree with a fix
for all gcc versions we (FreeBSD) actively support.
Thanks a lot and sorry for the delay. It took a while to get my arm board back
to live and it took also a while to build a native gcc on it.

[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

Richard Biener  changed:

   What|Removed |Added

 Target||arm
 Status|NEW |ASSIGNED

[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[andreast at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

Andreas Tobler  changed:

   What|Removed |Added

   Assignee|unassigned at gcc dot gnu.org  |andreast at gcc dot 
gnu.org

--- Comment #2 from Andreas Tobler  ---
Might be, it's a few days since :)

I'll take it. Thanks!

[Bug libgcc/84292] __sync_add_and_fetch returns the old value instead of the new value

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84292

ktkachov at gcc dot gnu.org changed:

   What|Removed |Added

   Keywords||wrong-code
 Status|UNCONFIRMED |NEW
   Last reconfirmed||2018-02-08
 CC||andreast at gcc dot gnu.org,
   ||ktkachov at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #1 from ktkachov at gcc dot gnu.org ---
Hmm, GCC 5 is not maintained anymore, however I agree with your observation
that
the code for __sync_##NAME##_and_fetch_##N and __sync_fetch_and_##NAME##_##N is
identical in libgcc/config/arm/freebsd-atomic.c.

Andreas, could you please confirm this bug?