[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-11-26 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

Jonathan Wakely  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #10 from Jonathan Wakely  ---
Fixed for 11.3 and 10.4

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-11-26 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

--- Comment #9 from CVS Commits  ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
:

https://gcc.gnu.org/g:b3f135a50c3dd7fc04252e17d7fbb08ca95aa9a5

commit r10-10307-gb3f135a50c3dd7fc04252e17d7fbb08ca95aa9a5
Author: Jonathan Wakely 
Date:   Wed Sep 15 21:53:35 2021 +0100

libstdc++: Add missing 'constexpr' to std::tuple [PR102270]

This backport to gcc-10 also includes r12-3637.

Signed-off-by: Jonathan Wakely 

libstdc++-v3/ChangeLog:

PR libstdc++/102270
* include/std/tuple (_Head_base, _Tuple_impl): Add
_GLIBCXX20_CONSTEXPR to allocator-extended constructors.
(tuple<>::swap(tuple&)): Add _GLIBCXX20_CONSTEXPR.
* testsuite/20_util/tuple/cons/102270.cc: New test.
* testsuite/util/testsuite_allocator.h (SimpleAllocator): Add
constexpr to constructor so it can be used for C++20 tests.

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-10-12 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

--- Comment #8 from CVS Commits  ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
:

https://gcc.gnu.org/g:9c2eea2841aa2ca165b9055763fffcee5008bf83

commit r11-9105-g9c2eea2841aa2ca165b9055763fffcee5008bf83
Author: Jonathan Wakely 
Date:   Fri Sep 17 12:27:02 2021 +0100

libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]

Also rename the test so it actually runs.

Signed-off-by: Jonathan Wakely 

libstdc++-v3/ChangeLog:

PR libstdc++/102270
* include/std/tuple (_Tuple_impl): Add constexpr to constructor
missed in previous patch.
* testsuite/20_util/tuple/cons/102270.C: Moved to...
* testsuite/20_util/tuple/cons/102270.cc: ...here.
* testsuite/util/testsuite_allocator.h (SimpleAllocator): Add
constexpr to constructor so it can be used for C++20 tests.

(cherry picked from commit 1fa2c5a695bb962ffcf8abed49f69cdcc59d0e61)

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-10-12 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

--- Comment #7 from CVS Commits  ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
:

https://gcc.gnu.org/g:63d91069ba8a9f1dc8bfa56ebfc10903a999f1cb

commit r11-9104-g63d91069ba8a9f1dc8bfa56ebfc10903a999f1cb
Author: Jonathan Wakely 
Date:   Wed Sep 15 21:53:35 2021 +0100

libstdc++: Add missing 'constexpr' to std::tuple [PR102270]

Signed-off-by: Jonathan Wakely 

libstdc++-v3/ChangeLog:

PR libstdc++/102270
* include/std/tuple (_Head_base, _Tuple_impl): Add
_GLIBCXX20_CONSTEXPR to allocator-extended constructors.
(tuple<>::swap(tuple&)): Add _GLIBCXX20_CONSTEXPR.
* testsuite/20_util/tuple/cons/102270.C: New test.

(cherry picked from commit 734b2c2eedca50d966e22540fc136158c3633393)

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-09-18 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

--- Comment #6 from Jonathan Wakely  ---
I think that constructor could just be deleted, but it's fixed now. Thanks.

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-09-17 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

--- Comment #5 from CVS Commits  ---
The master branch has been updated by Jonathan Wakely :

https://gcc.gnu.org/g:1fa2c5a695bb962ffcf8abed49f69cdcc59d0e61

commit r12-3637-g1fa2c5a695bb962ffcf8abed49f69cdcc59d0e61
Author: Jonathan Wakely 
Date:   Fri Sep 17 12:27:02 2021 +0100

libstdc++: Fix last std::tuple constructor missing 'constexpr' [PR102270]

Also rename the test so it actually runs.

Signed-off-by: Jonathan Wakely 

libstdc++-v3/ChangeLog:

PR libstdc++/102270
* include/std/tuple (_Tuple_impl): Add constexpr to constructor
missed in previous patch.
* testsuite/20_util/tuple/cons/102270.C: Moved to...
* testsuite/20_util/tuple/cons/102270.cc: ...here.
* testsuite/util/testsuite_allocator.h (SimpleAllocator): Add
constexpr to constructor so it can be used for C++20 tests.

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-09-16 Thread hewillk at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

--- Comment #4 from 康桓瑋  ---
(In reply to CVS Commits from comment #3)
> The master branch has been updated by Jonathan Wakely :
> 
> https://gcc.gnu.org/g:734b2c2eedca50d966e22540fc136158c3633393
> 
> commit r12-3592-g734b2c2eedca50d966e22540fc136158c3633393
> Author: Jonathan Wakely 
> Date:   Wed Sep 15 21:53:35 2021 +0100
> 
> libstdc++: Add missing 'constexpr' to std::tuple [PR102270]
> 
> Signed-off-by: Jonathan Wakely 
> 
> libstdc++-v3/ChangeLog:
> 
> PR libstdc++/102270
> * include/std/tuple (_Head_base, _Tuple_impl): Add
> _GLIBCXX20_CONSTEXPR to allocator-extended constructors.
> (tuple<>::swap(tuple&)): Add _GLIBCXX20_CONSTEXPR.
> * testsuite/20_util/tuple/cons/102270.C: New test.

tuple#L332:

template
  _Tuple_impl(allocator_arg_t __tag, const _Alloc& __a,
const _Head& __head, const _Tail&... __tail)
  : _Inherited(__tag, __a, __tail...),
  _Base(__use_alloc<_Head, _Alloc, _Head>(__a), __head)
  { }

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-09-16 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

Jonathan Wakely  changed:

   What|Removed |Added

   Target Milestone|--- |10.4

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-09-16 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

--- Comment #3 from CVS Commits  ---
The master branch has been updated by Jonathan Wakely :

https://gcc.gnu.org/g:734b2c2eedca50d966e22540fc136158c3633393

commit r12-3592-g734b2c2eedca50d966e22540fc136158c3633393
Author: Jonathan Wakely 
Date:   Wed Sep 15 21:53:35 2021 +0100

libstdc++: Add missing 'constexpr' to std::tuple [PR102270]

Signed-off-by: Jonathan Wakely 

libstdc++-v3/ChangeLog:

PR libstdc++/102270
* include/std/tuple (_Head_base, _Tuple_impl): Add
_GLIBCXX20_CONSTEXPR to allocator-extended constructors.
(tuple<>::swap(tuple&)): Add _GLIBCXX20_CONSTEXPR.
* testsuite/20_util/tuple/cons/102270.C: New test.

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-09-10 Thread hewillk at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

--- Comment #2 from 康桓瑋  ---
In addition, the uses-allocator construction version also missing constexpr
specifier, but I don't know if this is intentional.

#include 
#include 

struct O {
  using allocator_type = std::allocator;
  O() = default;
  constexpr O(const allocator_type&) {}
};

constexpr std::allocator a;
constexpr std::tuple t(std::allocator_arg, a);

https://godbolt.org/z/ba61nWhYx

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-09-10 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

Jonathan Wakely  changed:

   What|Removed |Added

   Last reconfirmed||2021-09-10
   Assignee|unassigned at gcc dot gnu.org  |redi at gcc dot gnu.org
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

[Bug libstdc++/102270] std::tuple<>::swap missing constexpr specifier

2021-09-10 Thread hewillk at gmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102270

--- Comment #1 from 康桓瑋  ---
This is missing from r278331.