[Bug libstdc++/108260] __cpp_lib_ranges_zip feature test macro not defined while std::views::zip is supported

2023-01-06 Thread ppalka at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108260

Patrick Palka  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Patrick Palka  ---
Fixed, thanks for the report.

[Bug libstdc++/108260] __cpp_lib_ranges_zip feature test macro not defined while std::views::zip is supported

2023-01-06 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108260

--- Comment #5 from CVS Commits  ---
The master branch has been updated by Patrick Palka :

https://gcc.gnu.org/g:f7bd48c6bbd3d7a479943b248b973aaf6c59463b

commit r13-5049-gf7bd48c6bbd3d7a479943b248b973aaf6c59463b
Author: Patrick Palka 
Date:   Fri Jan 6 10:32:10 2023 -0500

libstdc++: Add feature-test macros for implemented C++23 views [PR108260]

PR libstdc++/108260

libstdc++-v3/ChangeLog:

* include/bits/utility.h (__cpp_lib_ranges_zip): Define for C++23.
* include/std/ranges (__cpp_lib_ranges_zip): Likewise.
(__cpp_lib_ranges_chunk): Likewise.
(__cpp_lib_ranges_slide): Likewise.
(__cpp_lib_ranges_chunk_by): Likewise.
(__cpp_lib_ranges_join_with): Likewise.
(__cpp_lib_ranges_repeat): Likewise.
(__cpp_lib_ranges_stride): Likewise.
(__cpp_lib_ranges_cartesian_product): Likewise.
(__cpp_lib_ranges_as_rvalue): Likewise.
* include/std/version: Ditto.
* testsuite/20_util/tuple/p2321r2.cc: Verify value of
feature-test macro.
* testsuite/std/ranges/adaptors/as_rvalue/1.cc: Likewise.
* testsuite/std/ranges/adaptors/chunk/1.cc: Likewise.
* testsuite/std/ranges/adaptors/chunk_by/1.cc: Likewise.
* testsuite/std/ranges/adaptors/join_with/1.cc: Likewise.
* testsuite/std/ranges/adaptors/slide/1.cc: Likewise.
* testsuite/std/ranges/adaptors/stride/1.cc: Likewise.
* testsuite/std/ranges/cartesian_product/1.cc: Likewise.
* testsuite/std/ranges/repeat/1.cc: Likewise.
* testsuite/std/ranges/zip/1.cc: Likewise.
* testsuite/std/ranges/version_c++23.cc: New test.

[Bug libstdc++/108260] __cpp_lib_ranges_zip feature test macro not defined while std::views::zip is supported

2023-01-04 Thread ppalka at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108260

Patrick Palka  changed:

   What|Removed |Added

   Last reconfirmed||2023-01-04
   Target Milestone|--- |13.0
   Assignee|unassigned at gcc dot gnu.org  |ppalka at gcc dot 
gnu.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED

--- Comment #4 from Patrick Palka  ---
Yes, views::zip should be fully implemented as well as the other C++23 views
(except views::as_const).  For no good reason I had planned to add feature test
macros for the implemented C++23 views in bulk once all of them were
implemented, but that's inconvenient for early adopters.  Apologies for that,
I'll add them now.

[Bug libstdc++/108260] __cpp_lib_ranges_zip feature test macro not defined while std::views::zip is supported

2023-01-04 Thread de34 at live dot cn via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108260

--- Comment #3 from Jiang An  ---
__cpp_lib_ranges_as_rvalue is also missing... (together with feature test
macros for C++23 views?)

[Bug libstdc++/108260] __cpp_lib_ranges_zip feature test macro not defined while std::views::zip is supported

2023-01-03 Thread de34 at live dot cn via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108260

Jiang An  changed:

   What|Removed |Added

 CC||de34 at live dot cn

--- Comment #2 from Jiang An  ---
> I'm not sure if the feature is actually complete yet. It wasn't all done in a 
> single patch.

I think the changes in P2321R2 are all done (except for the missing feature
test macro).

---
Changes of pair, tuple, vector::reference:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=72886fcc6269531bbf3d9a09b3d64644963bff0d

zip_view:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=49e25d3e29aa1b56e6e82654de1a452a6cedc265

zip_transform_view:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=1a93a84b9e01d0dd5156be8d686e8666a6fc45a8

adjacent_view:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=f956cadc292aec42ceeba1e4835ad795c9aab5c2

adjacent_transform_view:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=0cb8d96157a95b7619ef1ccf28051181415fe989

LWG3692 & LWG3702:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=d0fd62d0ff4d1e0648e11b650b4f449772663990


Clarifications in "Conversion and common type for integer-class types" are
superseded by P2393R1 and perhaps don't require changes.


Fixes for testsuites:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=f46f58e61db3b1e71beb21443c0ca9387bc836e2

PR106766:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=718a6d475b3d17759618c68331c85f55c58ec9a3

PR106798:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=e469506b7fdd1bf2c958ca3140573a474fcba3b8

PR106803:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=8298427f6b546cabb853edd45c009cd1967b9d38

[Bug libstdc++/108260] __cpp_lib_ranges_zip feature test macro not defined while std::views::zip is supported

2023-01-02 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108260

--- Comment #1 from Jonathan Wakely  ---
(In reply to rhalbersma from comment #0)
> I'm a happy user of std::views::zip in gcc-latest but AFAICS the feature
> test macro __cpp_lib_ranges_zip is not yet defined, neither in ,
> , , nor in . This makes it hard #ifdedf my code on
> this feature. 

I'm not sure if the feature is actually complete yet. It wasn't all done in a
single patch.


> Just for my curiosity: is it generally the case that feature test macros are
> being added along with the feature completeness? Or should I condition my
> mixed C++20/C++23 code in another way?

This should be pretty obvious from looking at . GCC has always led the
way in defining feature test macros.