[Bug libstdc++/113320] libstdc++ accepts std::format(std::move(runtime_fmt), 42);

2024-01-12 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113320

Jonathan Wakely  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Target Milestone|--- |14.0
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Jonathan Wakely  ---
Fixed, thanks for checking it

[Bug libstdc++/113320] libstdc++ accepts std::format(std::move(runtime_fmt), 42);

2024-01-12 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113320

--- Comment #3 from GCC Commits  ---
The master branch has been updated by Jonathan Wakely :

https://gcc.gnu.org/g:5fbc1b2e7c1bdf11f64765b278f477310c0f3436

commit r14-7174-g5fbc1b2e7c1bdf11f64765b278f477310c0f3436
Author: Jonathan Wakely 
Date:   Wed Jan 10 20:54:11 2024 +

libstdc++: Fix std::runtime_format deviations from the spec [PR113320]

I seem to have implemented this feature based on the P2918R0 revision,
not the final P2918R2 one that was approved for C++26. This commit fixes
it.

The runtime-format-string type should not have a publicly accessible
data member, so add a constructor and make it a friend of
basic_format_string. It should also be non-copyable, so that it can only
be constructed from a prvalue via temporary materialization. Change the
basic_format_string constructor parameter to pass by value. Also add
noexcept to the constructors and runtime_format generator functions.

libstdc++-v3/ChangeLog:

PR libstdc++/113320
* include/std/format (__format::_Runtime_format_string): Add
constructor and disable copy operations.
(basic_format_string(_Runtime_format_string)): Add noexcept and
take parameter by value not rvalue reference.
(runtime_format): Add noexcept.
* testsuite/std/format/runtime_format.cc: Check noexcept. Check
that construction is only possible from prvalues, not xvalues.

Reviewed-by: Daniel Krügler 

[Bug libstdc++/113320] libstdc++ accepts std::format(std::move(runtime_fmt), 42);

2024-01-11 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113320

--- Comment #2 from Jonathan Wakely  ---
Patch posted:
https://gcc.gnu.org/pipermail/gcc-patches/2024-January/642741.html

[Bug libstdc++/113320] libstdc++ accepts std::format(std::move(runtime_fmt), 42);

2024-01-11 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113320

Jonathan Wakely  changed:

   What|Removed |Added

   Assignee|unassigned at gcc dot gnu.org  |redi at gcc dot gnu.org
 Status|UNCONFIRMED |ASSIGNED
   Last reconfirmed||2024-01-11
 Ever confirmed|0   |1

--- Comment #1 from Jonathan Wakely  ---
I implemented the R0 paper, not the final spec. I already have a patch to fix
this.