[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #24 from pinskia at gcc dot gnu dot org 2006-07-13 01:11 --- Fixed. -- pinskia at gcc dot gnu dot org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
-- pinskia at gcc dot gnu dot org changed: What|Removed |Added Severity|critical|blocker http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #16 from pinskia at gcc dot gnu dot org 2006-07-11 12:04 --- I am going to mark this as blocking PR 28217 though it does not officially, but fixing either one will not fix the bootstrap. -- pinskia at gcc dot gnu dot org changed: What|Removed |Added OtherBugsDependingO||28217 nThis|| Keywords|build | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #17 from gerald at pfeifer dot com 2006-07-11 12:31 --- i386-unknown-freebsd5.4 is also broken. -- gerald at pfeifer dot com changed: What|Removed |Added CC||gerald at pfeifer dot com http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #18 from pcarlini at suse dot de 2006-07-11 12:54 --- Created an attachment (id=11858) -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11858action=view) Please test! -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #19 from pcarlini at suse dot de 2006-07-11 12:55 --- Created an attachment (id=11859) -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11859action=view) ... and in case commit! -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #20 from pcarlini at suse dot de 2006-07-11 12:56 --- People affected by the breakage please carefully test the attached and, in case, commit: I'm going away for a few hours... Thanks! -- pcarlini at suse dot de changed: What|Removed |Added AssignedTo|unassigned at gcc dot gnu |pcarlini at suse dot de |dot org | Status|NEW |ASSIGNED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #21 from bkoz at gcc dot gnu dot org 2006-07-11 16:50 --- Huh. Sorry! I'm checking in Paolo's patch. -benjamin -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #22 from bkoz at gcc dot gnu dot org 2006-07-11 17:48 --- Subject: Bug 28290 Author: bkoz Date: Tue Jul 11 17:48:10 2006 New Revision: 115354 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=115354 Log: 2006-07-11 Paolo Carlini [EMAIL PROTECTED] PR libstdc++/28290 * include/ext/codecvt_specializations.h: Fix, adding missing includes and guards. Modified: trunk/libstdc++-v3/ChangeLog trunk/libstdc++-v3/include/ext/codecvt_specializations.h -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #23 from pcarlini at suse dot de 2006-07-12 00:21 --- Thanks Benjamin. FYI, I have just tweaked it back to my original version (if c++config.h is not included first, _GLIBCXX_USE_ICONV is always found undefined ;) -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #14 from ro at techfak dot uni-bielefeld dot de 2006-07-10 20:17 --- Subject: Re: [4.2 Regression] error: 'iconv_t' does not name a type pcarlini at suse dot de writes: It seemd to me that the best thing to do is adding the include on top of codecvt_specializations.h itself and removing it from the other places where it does currently appear (because a grep reveals that the iconv facilities are *not* used anywhere else (besides the testsuite), I would appreciate of you could double check...). Can you try that? The compilation errors are gone with this change, but due to PR c++/28217, I still get an ICE: Index: codecvt_specializations.h === --- codecvt_specializations.h (revision 115313) +++ codecvt_specializations.h (working copy) @@ -38,6 +38,10 @@ * This file is a GNU extension to the Standard C++ Library. */ +#if _GLIBCXX_USE_ICONV +# include iconv.h +#endif + // XXX // Define this here so codecvt.cc can have _S_max_size definition. #define _GLIBCXX_USE_ENCODING_STATE 1 Rainer -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #15 from pinskia at gcc dot gnu dot org 2006-07-10 23:17 --- This now affects powerpc-darwin: /Users/regress/tbox/native/build/./gcc/xgcc -shared-libgcc -B/Users/regress/tbox/native/build/./gcc -nostdinc++ -L/Users/regress/tbox/native/build/powerpc-apple-darwin8.5.0/libstdc++-v3/src -L/Users/regress/tbox/native/build/powerpc-apple-darwin8.5.0/libstdc++-v3/src/.libs -B/Users/regress/tbox/objs/powerpc-apple-darwin8.5.0/bin/ -B/Users/regress/tbox/objs/powerpc-apple-darwin8.5.0/lib/ -isystem /Users/regress/tbox/objs/powerpc-apple-darwin8.5.0/include -isystem /Users/regress/tbox/objs/powerpc-apple-darwin8.5.0/sys-include -Winvalid-pch -Wno-deprecated -x c++-header -g -O2 -I/Users/regress/tbox/native/build/powerpc-apple-darwin8.5.0/libstdc++-v3/include/powerpc-apple-darwin8.5.0 -I/Users/regress/tbox/native/build/powerpc-apple-darwin8.5.0/libstdc++-v3/include -I/Users/regress/tbox/svn-gcc/libstdc++-v3/libsupc++ -O2 -g /Users/regress/tbox/svn-gcc/libstdc++-v3/include/precompiled/extc++.h -o powerpc-apple-darwin8.5.0/bits/extc++.h.gch/O2g.gch /Users/regress/tbox/native/build/powerpc-apple-darwin8.5.0/libstdc++-v3/include/ext/codecvt_specializations.h:57: error: 'iconv_t' does not name a type PPC-darwin has an iconv.h also. -- pinskia at gcc dot gnu dot org changed: What|Removed |Added Target Milestone|--- |4.2.0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #11 from schwab at suse dot de 2006-07-09 16:07 --- Adjusting summary since the ICE is tracked in #28217. -- schwab at suse dot de changed: What|Removed |Added Summary|[4.2 Regression] ICE during |[4.2 Regression] error: |extc++.h pch generation |'iconv_t' does not name a ||type http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #12 from pcarlini at suse dot de 2006-07-09 17:39 --- It seemd to me that the best thing to do is adding the include on top of codecvt_specializations.h itself and removing it from the other places where it does currently appear (because a grep reveals that the iconv facilities are *not* used anywhere else (besides the testsuite), I would appreciate of you could double check...). Can you try that? -- pcarlini at suse dot de changed: What|Removed |Added CC||pcarlini at suse dot de http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
[Bug libstdc++/28290] [4.2 Regression] error: 'iconv_t' does not name a type
--- Comment #13 from pcarlini at suse dot de 2006-07-09 17:58 --- Forgot: those facilities are not always available, therefore we should probably protect the whole thing with _GLIBCXX_USE_ICONV... I'm adding Benjamin in CC. -- pcarlini at suse dot de changed: What|Removed |Added CC||bkoz at redhat dot com http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28290
