[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #15 from paolo dot carlini at oracle dot com 2008-10-03 22:56 --- *** Bug 36893 has been marked as a duplicate of this bug. *** -- paolo dot carlini at oracle dot com changed: What|Removed |Added CC||jason at gcc dot gnu dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #13 from paolo at gcc dot gnu dot org 2008-09-30 13:50 --- Subject: Bug 30085 Author: paolo Date: Tue Sep 30 13:49:15 2008 New Revision: 140787 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=140787 Log: 2008-09-30 Paolo Carlini [EMAIL PROTECTED] PR libstdc++/30085 (again) * include/debug/unordered_map (unordered_map, unordered_multimap): Do not derive from _Safe_association, derive from _GLIBCXX_STD_D:: unordered_map / unordered_multimap; add missing member functions. * include/debug/unordered_set (unordered_set, unordered_multiset): Likewise for _GLIBCXX_STD_D::unordered_set / unordered_multiset. * include/debug/safe_association.h: Remove. * include/Makefile.am: Adjust. * include/Makefile.in: Regenerate. * testsuite/23_containers/unordered_multimap/init-list.cc: Remove xfail. Modified: trunk/libstdc++-v3/ChangeLog -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #14 from paolo dot carlini at oracle dot com 2008-09-30 13:52 --- Fixed. -- paolo dot carlini at oracle dot com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #12 from paolo at gcc dot gnu dot org 2008-09-30 13:50 --- Subject: Bug 30085 Author: paolo Date: Tue Sep 30 13:48:55 2008 New Revision: 140786 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=140786 Log: 2008-09-30 Paolo Carlini [EMAIL PROTECTED] PR libstdc++/30085 (again) * include/debug/unordered_map (unordered_map, unordered_multimap): Do not derive from _Safe_association, derive from _GLIBCXX_STD_D:: unordered_map / unordered_multimap; add missing member functions. * include/debug/unordered_set (unordered_set, unordered_multiset): Likewise for _GLIBCXX_STD_D::unordered_set / unordered_multiset. * include/debug/safe_association.h: Remove. * include/Makefile.am: Adjust. * include/Makefile.in: Regenerate. * testsuite/23_containers/unordered_multimap/init-list.cc: Remove xfail. Removed: trunk/libstdc++-v3/include/debug/safe_association.h Modified: trunk/libstdc++-v3/include/Makefile.am trunk/libstdc++-v3/include/Makefile.in trunk/libstdc++-v3/include/debug/unordered_map trunk/libstdc++-v3/include/debug/unordered_set trunk/libstdc++-v3/testsuite/23_containers/unordered_multimap/init-list.cc -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #9 from paolo dot carlini at oracle dot com 2008-09-29 14:36 --- Benjamin, are you actively taking care of this issue? Otherwise, I can have a look, really we should have the unordered containers working fine in debug-mode too. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #10 from bkoz at redhat dot com 2008-09-29 17:17 --- Sorry P, I have not paid attention to this. I am not likely to work on it this week, so if you want to work on it feel free. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #11 from paolo dot carlini at oracle dot com 2008-09-29 17:24 --- Ok, no problem, thanks for your quick feedback. I'll see what I can do... -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
-- paolo dot carlini at oracle dot com changed: What|Removed |Added CC|paolo at gcc dot gnu dot org| AssignedTo|bkoz at gcc dot gnu dot org |paolo dot carlini at oracle ||dot com Status|REOPENED|ASSIGNED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #8 from paolo dot carlini at oracle dot com 2008-09-05 23:53 --- I think this is a major loss of function, we want to fix this before 4.4.0. -- paolo dot carlini at oracle dot com changed: What|Removed |Added Severity|enhancement |major Target Milestone|--- |4.4.0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #7 from paolo dot carlini at oracle dot com 2008-07-19 00:26 --- Benjamin, the problem is that _Safe_association doesn't inherit from _Safe_sequence: everything in _Safe_association having to do with safe iterator construction (eg., simply in begin()) breaks because the _Safe_iterator_base constructor wants a pointer to _Safe_sequence_base and there are no conversions from pointer to _Safe_association. At the moment, I have no idea how to fix this and keep the _Safe_association idea: under pressure I would simply rip out _Safe_association and have a bit of working redundancy (similar to debug/map/multimap/set/multiset)... Let me know... -- paolo dot carlini at oracle dot com changed: What|Removed |Added CC||paolo at gcc dot gnu dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #6 from paolo dot carlini at oracle dot com 2008-05-29 10:29 --- Benjamin, can you double check this work? In debug mode the citerators testcases, which predate it, fail for me... -- paolo dot carlini at oracle dot com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #4 from bkoz at gcc dot gnu dot org 2007-10-18 15:23 --- Subject: Bug 30085 Author: bkoz Date: Thu Oct 18 15:22:58 2007 New Revision: 129442 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=129442 Log: 2007-10-18 Benjamin Kosnik [EMAIL PROTECTED] * include/ext/hash_map: To... * include/backward/hash_map: ...here. Remove debug mode. * include/ext/hash_set: To... * include/backward/hash_set: ...here. Remove debug mode. * include/ext/hash_fun.h: To... * include/backward/hash_fun.h: ...here. * include/ext/hashtable.h: To... * include/backward/hashtable.h: ...here. * include/bits/c++config: Remove __gnu_cxx namespace from debug mode. * include/debug/debug.h: Same. * include/debug/hash_map: Remove. * include/debug/hash_multimap.h: Remove. * include/debug/hash_set.h: Remove. * include/debug/hash_set: Remove. * include/debug/hash_multiset.h: Remove. * include/debug/hash_map.h: Remove. * include/Makefile.am (ext_headers): Move hash_set, hash_map to backward. (debug_headers): Remove hash_map, hash_set, hash_map.h, hash_map.h, hash_multiset.h, hash_multimap.h. * include/Makefile.in: Regenerate. * docs/html/debug.html: Update. * docs/html/ext/howto.html: Same. * docs/html/faq/index.html: Same. * docs/doxygen/Intro.3: Same. * docs/doxygen/user.cfg.in: Adjust includes. * testsuite/ext/hash_map: Move to... * testsuite/backward/hash_map: ...here. * testsuite/ext/hash_set: Move to... * testsuite/backward/hash_set: ...here. 2007-10-18 Benjamin Kosnik [EMAIL PROTECTED] Removal of pre-ISO C++ items from include/backwards. * include/Makefile.am (backward_headers): Remove all but strstream, backward_warning.h. * include/Makefile.in: Regenerate. * include/backward/new.h: Remove. * include/backward/iterator.h: Same. * include/backward/alloc.h: Same. * include/backward/set.h: Same. * include/backward/hashtable.h: Same. * include/backward/hash_set.h: Same. * include/backward/fstream.h: Same. * include/backward/tempbuf.h: Same. * include/backward/istream.h: Same. * include/backward/bvector.h: Same. * include/backward/stack.h: Same. * include/backward/rope.h: Same. * include/backward/complex.h: Same. * include/backward/ostream.h: Same. * include/backward/heap.h: Same. * include/backward/iostream.h: Same. * include/backward/function.h: Same. * include/backward/multimap.h: Same. * include/backward/pair.h: Same. * include/backward/stream.h: Same. * include/backward/iomanip.h: Same. * include/backward/slist.h: Same. * include/backward/tree.h: Same. * include/backward/vector.h: Same. * include/backward/deque.h: Same. * include/backward/multiset.h: Same. * include/backward/defalloc.h: Same. * include/backward/list.h: Same. * include/backward/map.h: Same. * include/backward/algobase.h: Same. * include/backward/hash_map.h: Same. * include/backward/algo.h: Same. * include/backward/queue.h: Same. * include/backward/streambuf.h: Same. * testsuite/backward/header_hash_set_h.cc: Same. * testsuite/backward/header_slist_h.cc: Same. * testsuite/backward/header_hash_map_h.cc: Same. * testsuite/backward/header_tempbuf_h.cc: Same. * testsuite/backward/header_deque_h.cc: Same. * testsuite/backward/header_rope_h.cc: Same. * testsuite/backward/header_iterator_h.cc: Same. * testsuite/backward/header_hashtable_h.cc: Same. 2007-10-18 Benjamin Kosnik [EMAIL PROTECTED] PR libstdc++/30085 * include/debug/unordered_map: New. * include/debug/unordered_set: New. * include/debug/safe_association.h: New. * include/std/unordered_map: Include debug header if _GLIBCXX_DEBUG. * include/std/unordered_set: Same. * include/Makefile.am (debug_headers): Add unordered_map, unordered_set, safe_association.h. * include/Makefile.in: Regenerate. * testsuite/23_containers/unordered_map/requirements/debug.cc: New. * testsuite/23_containers/unordered_multimap/requirements/ debug.cc: New. * testsuite/23_containers/unordered_set/requirements/debug.cc: New. * testsuite/23_containers/unordered_multiset/requirements/ debug.cc: New. 2007-10-18 Benjamin Kosnik [EMAIL PROTECTED] * testsuite/util/native_type/assoc/native_hash_multimap.hpp: Remove hash_map include. Added: trunk/libstdc++-v3/include/backward/hash_fun.h - copied, changed from r129351, trunk/libstdc++-v3/include/ext/hash_fun.h
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #5 from bkoz at gcc dot gnu dot org 2007-10-18 16:04 --- Done. -- bkoz at gcc dot gnu dot org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #3 from bkoz at gcc dot gnu dot org 2007-10-12 00:11 --- Mine -- bkoz at gcc dot gnu dot org changed: What|Removed |Added AssignedTo|unassigned at gcc dot gnu |bkoz at gcc dot gnu dot org |dot org | Status|NEW |ASSIGNED Last reconfirmed|2006-12-27 00:06:38 |2007-10-12 00:11:52 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #2 from pinskia at gcc dot gnu dot org 2006-12-27 00:06 --- Confirmed. -- pinskia at gcc dot gnu dot org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Last reconfirmed|-00-00 00:00:00 |2006-12-27 00:06:38 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
[Bug libstdc++/30085] switch debug mode hash containers from ext to tr1
--- Comment #1 from pcarlini at suse dot de 2006-12-07 10:07 --- *Assuming* we keep delivering the legacy hash_* containers, probably we should also keep the corresponding debug mode version. Indeed, if we start delivering the unordered containers in namespace std we should also deliver the debug-mode version of the same. In other terms, I think we should deliver consistent pairs of normal/debug mode containers or nothing. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30085
