[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[rguenther at suse dot de]

--- Comment #10 from rguenther at suse dot de  2007-11-16 09:45 ---
Subject: Re:  [4.3 Regression] Confusing error message
 with missing #include algorithm

On Thu, 15 Nov 2007, pcarlini at suse dot de wrote:

 --- Comment #8 from pcarlini at suse dot de  2007-11-15 19:07 ---
 Fixed.

Thanks Paolo!

Richard.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105

[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[pcarlini at suse dot de]

--- Comment #1 from pcarlini at suse dot de  2007-11-15 11:59 ---
Note that the issue is unrelated to the header optimization work: is caused by
algorithmfwd.h, added in the occasion of the parallel STL work. I'm going to
look a bit into it, anyway, if a simple solution I have in mind will not work,
will forward to Benjamin.


-- 

pcarlini at suse dot de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2007-11-15 11:59:39
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105

[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[pcarlini at suse dot de]

--- Comment #5 from pcarlini at suse dot de  2007-11-15 13:10 ---
I meant bits/stl_algobase.h, of course.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105

[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[pcarlini at suse dot de]

--- Comment #3 from pcarlini at suse dot de  2007-11-15 13:06 ---
Something like the attached (lightly tested) fixed the problem for normal mode,
the error becomes:

34105.cc: In function ‘int main()’:
34105.cc:8: error: ‘find’ is not a member of ‘std’

however, it doesn't for parallel mode. I think it's better if Benjamin looks
into those headers...


-- 

pcarlini at suse dot de changed:

   What|Removed |Added

 CC||bkoz at redhat dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105

[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[pcarlini at suse dot de]

--- Comment #4 from pcarlini at suse dot de  2007-11-15 13:09 ---
By the way, while we are talking about those QoI issues, I think it's in any
case better not including something like algorithmfwd.h in algobase.h: it's
relatively big and we are doing our best to keep algobase.h, the core
algorithmic facilities optimized for internal use, as minimal as possible.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105

[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[pcarlini at suse dot de]

--- Comment #2 from pcarlini at suse dot de  2007-11-15 13:04 ---
Created an attachment (id=14555)
 -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14555action=view)
Draft patch for normal mode


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105

[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[pcarlini at suse dot de]

--- Comment #8 from pcarlini at suse dot de  2007-11-15 19:07 ---
Fixed.


-- 

pcarlini at suse dot de changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||FIXED
   Target Milestone|--- |4.3.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105

[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[paolo at gcc dot gnu dot org]

--- Comment #7 from paolo at gcc dot gnu dot org  2007-11-15 19:05 ---
Subject: Bug 34105

Author: paolo
Date: Thu Nov 15 19:05:17 2007
New Revision: 130207

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=130207
Log:
2007-11-15  Paolo Carlini  [EMAIL PROTECTED]

PR libstdc++/34105
* include/bits/stl_algobase.h: Do not include bits/algorithmfwd.h.
(lexicographical_compare(const unsigned char*, const unsigned char*,
const unsigned char*, const unsigned char*),
lexicographical_compare(const char*, const char*, const char*,
const char*)): Move to namespace (std, _GLIBCXX_STD_P).
* include/parallel/algobase.h: Do not include bits/algorithmfwd.h.
(equal): Move after mismatch.
* include/bits/stl_heap.h (is_heap, is_heap_until): Reorder.
* include/bits/char_traits.h: Include bits/stl_algobase.h instead
of bits/algorithmfwd.h.
* include/bits/stl_algo.h: Include first bits/algorithmfwd.h.
* include/bits/algorithmfwd.h (lexicographical_compare): Do not
declare overloads.
* include/parallel/partition.h: Include parallel/random_number.h.
* testsuite/util/testsuite_abi.cc: Include algorithm.

Modified:
trunk/libstdc++-v3/ChangeLog
trunk/libstdc++-v3/include/bits/algorithmfwd.h
trunk/libstdc++-v3/include/bits/char_traits.h
trunk/libstdc++-v3/include/bits/stl_algo.h
trunk/libstdc++-v3/include/bits/stl_algobase.h
trunk/libstdc++-v3/include/bits/stl_heap.h
trunk/libstdc++-v3/include/parallel/algobase.h
trunk/libstdc++-v3/include/parallel/partition.h
trunk/libstdc++-v3/testsuite/util/testsuite_abi.cc


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105

[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[pcarlini at suse dot de]

--- Comment #6 from pcarlini at suse dot de  2007-11-15 18:14 ---
I'm finishing testing a complete patch.


-- 

pcarlini at suse dot de changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |pcarlini at suse dot de
   |dot org |
 Status|NEW |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105

[Bug libstdc++/34105] [4.3 Regression] Confusing error message with missing #include algorithm

[bkoz at gcc dot gnu dot org]

--- Comment #9 from bkoz at gcc dot gnu dot org  2007-11-15 21:54 ---

Awesome. Looks good. 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34105