[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 gcc-user at riseup dot net changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #14 from gcc-user at riseup dot net --- Thanks, I applied that commit as a patch against 10.2.0 and it fixes the issue on my end too!
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #13 from CVS Commits --- The master branch has been updated by Caroline Tice : https://gcc.gnu.org/g:c2be82058fb40f3ae891c68d185ff53e07f14f45 commit r11-7678-gc2be82058fb40f3ae891c68d185ff53e07f14f45 Author: Caroline Tice Date: Fri Mar 12 07:34:36 2021 -0800 libstdc++-v3: Update VTV vars for libtool link commands [PR99172] This fixes PR 99172 Currently when GCC is configured with --enable-vtable-verify, the libstdc++-v3 Makefiles add "-fvtable-verify=std -Wl,-u_vtable_map_vars_start,-u_vtable_map_vars_end" to libtool link commands. The "-fvtable-verify=std" piece causes alternate versions of libtool (such as slibtool) to fail, unable to find "-lvtv" (GNU libtool just removes that piece). This patch updates the libstdc++-v3 Makefiles to not pass "-fvtable-verify=std" to the libtool link commands.
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #12 from Jonathan Wakely --- Comment on attachment 50360 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50360 Proposed patch to fix issue The patch looks good but please CC the libstdc++ list for libstdc++ patches, thanks.
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #11 from ctice at gcc dot gnu.org --- Created attachment 50360 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50360=edit Proposed patch to fix issue This patch fixes the issue, without breaking VTV, and is currently out for review.
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #10 from Jonathan Wakely --- (In reply to ctice from comment #7) > I thought I was maintaining it too! :-) OK, thanks. I guess I mistook "doesn't need much work" for "unmaintained".
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #9 from ctice at gcc dot gnu.org --- I will work on fixing that.
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #8 from gcc-user at riseup dot net --- > Is there something here that you want/need me to take care of? If you can make it so that -lvtv is never passed to libtool so that slibtool will also work with --enable-vtable-verify as described in this issue it would be very much appreciated.
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 ctice at gcc dot gnu.org changed: What|Removed |Added CC||ctice at gcc dot gnu.org --- Comment #7 from ctice at gcc dot gnu.org --- I thought I was maintaining it too! :-) Is there something here that you want/need me to take care of?
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 Eric Gallager changed: What|Removed |Added CC||cmtice at google dot com, ||egallager at gcc dot gnu.org --- Comment #6 from Eric Gallager --- (In reply to Jonathan Wakely from comment #3) > (In reply to gcc-user from comment #2) > > Briefly it explained that -lvtv comes from -fvtable-verify=std in a gcc spec > > file and is propogated to Makefile.in by gcc/Makefile.def. > > The -fvtable-verify=std doesn't come from the spec file, it comes from using > --enable-vtable-verify to configure gcc. That adds -fvtable-verify=std and > the spec file turns that into -lvtv. > > I don't know why you want to use --enable-vtable-verify but it's not really > maintained as far as I can see. I thought Caroline Tice was maintaining it.
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #5 from gcc-user at riseup dot net --- Starting with gcc-10 gentoo is not going to enable --enable-vtable-verify by default anymore. https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=63c16d8b5e71b5f8e6185965062cf9c836800c29
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #4 from gcc-user at riseup dot net --- Thanks for the clarification, regardless -lvtv is then passed to the libtool implementation. With GNU libtool it is silently removed hiding the bug, while slibtool actually passes it to ld which fails when its not valid. Ideally -lvtv should never reach the libtool implementation in this case since its not valid. (It is unfortunate that GNU libtool has hidden issues like this among others for so long...) > I don't know why you want to use --enable-vtable-verify but it's not really > maintained as far as I can see. I was not aware of that, it is default in gentoo. Maybe they should change that? I will add that to the gentoo issue.
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #3 from Jonathan Wakely --- (In reply to gcc-user from comment #2) > Briefly it explained that -lvtv comes from -fvtable-verify=std in a gcc spec > file and is propogated to Makefile.in by gcc/Makefile.def. The -fvtable-verify=std doesn't come from the spec file, it comes from using --enable-vtable-verify to configure gcc. That adds -fvtable-verify=std and the spec file turns that into -lvtv. I don't know why you want to use --enable-vtable-verify but it's not really maintained as far as I can see.
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 --- Comment #2 from gcc-user at riseup dot net --- > Note swapping out parts of the build system isn't tested/supported. This is both a gcc and GNU libtool bug, gcc is passing invalid flags and libtool is silently hiding the fact. I understand that slibtool may be untested in gcc, but since its actually doing the right thing here and has several benefits over GNU libtool (Maintained and readable codebase) it would be very appreciated if this can be fixed. > Can you quote where the "invalid" -lvtv is present? Honestly the gcc build system is confusing for me, but see this comment from the gentoo issue. https://bugs.gentoo.org/767706#c7 Briefly it explained that -lvtv comes from -fvtable-verify=std in a gcc spec file and is propogated to Makefile.in by gcc/Makefile.def.
[Bug libstdc++/99172] Build failure with slibtool and vtv
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99172 Richard Biener changed: What|Removed |Added Keywords||build --- Comment #1 from Richard Biener --- Note swapping out parts of the build system isn't tested/supported. Can you quote where the "invalid" -lvtv is present?
