[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[pinskia at gcc dot gnu dot org]

--- Comment #6 from pinskia at gcc dot gnu dot org  2005-10-12 00:15 ---
Is this still broken?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[dannysmith at users dot sourceforge dot net]

--- Comment #7 from dannysmith at users dot sourceforge dot net  2005-10-12 
01:01 ---
(In reply to comment #6)
 Is this still broken?


No. 
It was fixed by this:

2005-07-13  H.J. Lu  [EMAIL PROTECTED]

* config/alpha/linux.h (TARGET_HAS_F_SETLKW): Renamed to ...
(TARGET_POSIX_IO): This.
* config/darwin.h: Likewise.
* config/freebsd.h: Likewise.
* config/linux.h: Likewise.
* config/lynx.h: Likewise.
* config/netbsd.h: Likewise.
* config/rs6000/linux64.h: Likewise.
* config/rs6000/linux.h: Likewise.
* config/s390/tpf.h: Likewise.
* config/sh/embed-elf.h: Likewise.
* config/sparc/linux64.h: Likewise.
* config/sparc/linux.h: Likewise.
* config/svr4.h: Likewise.
* gcov-io.h: Likewise.

* doc/tm.texi: Updated.

* libgcov.c (create_file_directory): Defined only if
TARGET_POSIX_IO is defined.
(gcov_exit): Call create_file_directory only if TARGET_POSIX_IO
is defined.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[pinskia at gcc dot gnu dot org]

--- Comment #8 from pinskia at gcc dot gnu dot org  2005-10-12 01:02 ---
Fixed.


-- 

pinskia at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[fxcoudert at gcc dot gnu dot org]

--- Additional Comments From fxcoudert at gcc dot gnu dot org  2005-06-09 
18:48 ---
With fresh CVS GCC, I get the following errors on libgcov.c:

../../gcc/gcc/libgcov.c: In function 'create_file_directory':
../../gcc/gcc/libgcov.c:110: warning: implicit declaration of function 'access'
../../gcc/gcc/libgcov.c:110: error: 'F_OK' undeclared (first use in this 
function)
../../gcc/gcc/libgcov.c:110: error: (Each undeclared identifier is reported only
once
../../gcc/gcc/libgcov.c:110: error: for each function it appears in.)
../../gcc/gcc/libgcov.c:111: warning: implicit declaration of function 'mkdir'

All are related to the same problem: mkdir and access functions are defined in
the io.h system header, which is not included in libgcov.c (and not included
either when configure tests if MKDIR_TAKES_ONE_ARG should be defined, that's why
we can have the too many arguments to function 'mkdir' error when everything
else is fixed).

So what we need is that to test for the presence of io.h in configure.ac, and
then include in libgcov.c when it's available.

Can someone confirm whether such an approach is the right thing to do?

-- 
   What|Removed |Added

 CC||fxcoudert at gcc dot gnu dot
   ||org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[dannysmith at users dot sourceforge dot net]

--- Additional Comments From dannysmith at users dot sourceforge dot net  
2005-06-09 20:33 ---
Re; comment #4

There should be no need te test for io.h for the sake of mingw
libgcov.c already includes tsystem.h
tsystem.h includes unistd.h.
On mingw, unistd.h  includes io.h

Danny

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[pinskia at gcc dot gnu dot org]

--- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-30 
15:29 ---
(In reply to comment #2)
 Looks like MKDIR_TAKES_ONE_ARG is not defined as it should be.
Which I filed as PR 21826.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[fxcoudert at gmail dot com]

--- Additional Comments From fxcoudert at gmail dot com  2005-05-21 10:03 
---
On i386-mingw32, there is another one of those:

../../gcc/fastjar/jartool.c: In function 'extract_jar':
../../gcc/fastjar/jartool.c:1770: error: too many arguments to function 'mkdir'

Looks like MKDIR_TAKES_ONE_ARG is not defined as it should be.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597

[Bug middle-end/21597] [4.1 Regression] libgcc broken on targets with MKDIR_TAKES_ONE_ARG

[pinskia at gcc dot gnu dot org]

--- Additional Comments From pinskia at gcc dot gnu dot org  2005-05-16 
00:13 ---
Confirmed.

-- 
   What|Removed |Added

 Status|UNCONFIRMED |NEW
  Component|target  |middle-end
 Ever Confirmed||1
   Keywords||build
   Last reconfirmed|-00-00 00:00:00 |2005-05-16 00:13:54
   date||
Summary|libgcc broken on targets|[4.1 Regression] libgcc
   |with MKDIR_TAKES_ONE_ARG|broken on targets with
   ||MKDIR_TAKES_ONE_ARG
   Target Milestone|--- |4.1.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21597