[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #12 from cnstar9988 at gmail dot com 2009-01-08 09:30 --- Target Milestone: 4.3.3 But not fixed for 4.3.3 ping ... -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #13 from steven at gcc dot gnu dot org 2009-01-08 10:21 --- Reopening... -- steven at gcc dot gnu dot org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #14 from steven at gcc dot gnu dot org 2009-01-08 10:22 --- ...to unassign and avoid spam from cnstar9988 (who is free to test/submit the patch if it's so important for him/her to have this bug fixed in gcc 4.3). -- steven at gcc dot gnu dot org changed: What|Removed |Added AssignedTo|steven at gcc dot gnu dot |unassigned at gcc dot gnu |org |dot org Status|REOPENED|NEW http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #10 from cnstar9988 at gmail dot com 2009-01-07 08:55 --- ping for 4.3... -- cnstar9988 at gmail dot com changed: What|Removed |Added CC||cnstar9988 at gmail dot com http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #11 from steven at gcc dot gnu dot org 2009-01-07 09:37 --- I have no intention to fix this in 4.3. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #8 from steven at gcc dot gnu dot org 2009-01-04 00:15 --- Subject: Bug 38584 Author: steven Date: Sun Jan 4 00:15:08 2009 New Revision: 143040 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=143040 Log: PR middle-end/38584 * cfgexpand.c (estimate_stack_frame_size): Simplify the estimate: Calculate the size of all stack vars assuming no packing of stack vars will happen, replacing a quadratic algorithm with a linear one. Modified: trunk/gcc/ChangeLog trunk/gcc/cfgexpand.c -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #9 from steven at gcc dot gnu dot org 2009-01-04 00:17 --- . -- steven at gcc dot gnu dot org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #7 from stevenb dot gcc at gmail dot com 2009-01-01 13:42 --- Subject: Re: [4.3/4.4 Regression] Inline heuristics run even at -O0 Note that the compile time at, say, -O1 for 4.3 vs. 4.4 is also a huge difference for the test case (4.4 much slower, in part due to the expensive heuristic). Therefore, IMHO, this is still a 4.4 regression too. We should not be running such expensive algorithms just for inline heuristics. We need to figure out a cheaper heuristic. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #6 from jakub at gcc dot gnu dot org 2009-01-01 00:55 --- Now that inline heuristics runs only at -O1+ on the trunk, can this be changed into 4.3 only regression? If you want to make bin-packing faster, that could be covered by a separate bug (and would it be a regression)? -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #4 from steven at gcc dot gnu dot org 2008-12-30 13:36 --- Subject: Bug 38584 Author: steven Date: Tue Dec 30 13:35:00 2008 New Revision: 142963 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=142963 Log: PR middle-end/38584 * ipa-inline.c (compute_inline_parameters): When not optimizing, don't compute the inline parameters, just set them to 0 instead. Modified: trunk/gcc/ChangeLog trunk/gcc/ipa-inline.c -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #5 from steven at gcc dot gnu dot org 2008-12-30 13:37 --- We should not use the full bin-packing algorithm for any optimization level. A simpler heuristic is called for. I'll see if I can come up with something. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
-- rguenth at gcc dot gnu dot org changed: What|Removed |Added CC||hubicka at gcc dot gnu dot ||org Priority|P3 |P2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #3 from jv244 at cam dot ac dot uk 2008-12-21 08:05 --- (In reply to comment #2) Without this patch, (total 3868s). With the patch, (total 588s). Great... -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
-- steven at gcc dot gnu dot org changed: What|Removed |Added AssignedTo|unassigned at gcc dot gnu |steven at gcc dot gnu dot |dot org |org Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1 Last reconfirmed|-00-00 00:00:00 |2008-12-20 15:47:00 date|| Summary|[4.3/4.4 Regression] Inline |[4.3/4.4 Regression] Inline |heuristics |heuristics run even at -O0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
[Bug middle-end/38584] [4.3/4.4 Regression] Inline heuristics run even at -O0
--- Comment #2 from steven at gcc dot gnu dot org 2008-12-21 00:33 --- Created an attachment (id=16951) -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16951action=view) Avoid expensive inline heuristics at O0, and speed up add_alias_set_conflicts This problem is always going to be, at the core, that add_alias_set_conflicts is a quadratic problem in the number of stack variables. But we can avoid calculating this at -O0 for the inline heuristics but not for bin-packing stack variables. And we can also try hard to make the quadratic loop as cheap as possible. Without this patch, for compiling the full test case (at -O0) my ia64 host spends 952s in callgraph optimizations, 1903s in inline heuristics, and 1013s in expand (total 3868s). With the patch, the numbers are 1s in callgraph optimizations, 0s in inline heuristics, and 587s in expand (total 588s). Given the nature of this unholy test case, I think the patch is close to the final form I intend to submit, at least algorithmically. There are enough areas left where we spend a lot more time... -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38584
