[Bug middle-end/50199] [4.7/4.8 Regression] wrong code with -flto -fno-merge-constants

2013-01-14 Thread rguenther at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50199



--- Comment #14 from rguenther at suse dot de rguenther at suse dot de 
2013-01-14 14:45:48 UTC ---

On 1/11/13 5:02 PM, jakub at gcc dot gnu.org wrote:

 

 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50199

 

 Jakub Jelinek jakub at gcc dot gnu.org changed:

 

What|Removed |Added

 

  CC||jakub at gcc dot gnu.org

 

 --- Comment #13 from Jakub Jelinek jakub at gcc dot gnu.org 2013-01-11 
 16:02:24 UTC ---

 I guess it is again too late to really fix this for 4.8, can we at least error

 out on -fno-merge-constants used together with -flto ?  We'll still fail for

 targets that don't support mergeable string sections, but generally, it makes

 no sense to use -fno-merge-constants together with -flto.



We could, I suppose.  I'm not sure this isn't an issue without LTO

though (possibly way harder to trigger though).


[Bug middle-end/50199] [4.7/4.8 Regression] wrong code with -flto -fno-merge-constants

2013-01-14 Thread jakub at gcc dot gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50199



--- Comment #15 from Jakub Jelinek jakub at gcc dot gnu.org 2013-01-14 
14:55:45 UTC ---

(In reply to comment #14)

 I'm not sure this isn't an issue without LTO

 though (possibly way harder to trigger though).



I don't see how.  -fno-merge-constants doesn't say that constants aren't merged

within the same TU, they are merged always, -fno-merge-constants is about not

allowing constants to be merged between different object files.  As without LTO

we operate at the level of individual TUs, we don't have issues with that.

-fno-merge-constants is the only possible thing on targets that don't have

needed support on the assembler/linker side though.


[Bug middle-end/50199] [4.7/4.8 Regression] wrong code with -flto -fno-merge-constants

2013-01-11 Thread jakub at gcc dot gnu.org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50199



Jakub Jelinek jakub at gcc dot gnu.org changed:



   What|Removed |Added



 CC||jakub at gcc dot gnu.org



--- Comment #13 from Jakub Jelinek jakub at gcc dot gnu.org 2013-01-11 
16:02:24 UTC ---

I guess it is again too late to really fix this for 4.8, can we at least error

out on -fno-merge-constants used together with -flto ?  We'll still fail for

targets that don't support mergeable string sections, but generally, it makes

no sense to use -fno-merge-constants together with -flto.