[Bug middle-end/56483] LTO issue with expanding GIMPLE_COND

2013-03-18 Thread rguenth at gcc dot gnu.org 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56483



--- Comment #4 from Richard Biener rguenth at gcc dot gnu.org 2013-03-18 
10:29:58 UTC ---

Author: rguenth

Date: Mon Mar 18 10:29:43 2013

New Revision: 196776



URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=196776

Log:

2013-03-18  Richard Biener  rguent...@suse.de



PR middle-end/56483

* cfgexpand.c (expand_gimple_cond): Inline gimple_cond_single_var_p

and implement properly.

* gimple.h (gimple_cond_single_var_p): Remove.



Modified:

trunk/gcc/ChangeLog

trunk/gcc/cfgexpand.c

trunk/gcc/gimple.h

[Bug middle-end/56483] LTO issue with expanding GIMPLE_COND

2013-03-18 Thread rguenth at gcc dot gnu.org 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56483



Richard Biener rguenth at gcc dot gnu.org changed:



   What|Removed |Added



 Status|ASSIGNED|RESOLVED

  Known to work||4.9.0

 Resolution||FIXED



--- Comment #5 from Richard Biener rguenth at gcc dot gnu.org 2013-03-18 
10:30:40 UTC ---

Fixed.

[Bug middle-end/56483] LTO issue with expanding GIMPLE_COND

2013-03-01 Thread rguenth at gcc dot gnu.org 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56483



Richard Biener rguenth at gcc dot gnu.org changed:



   What|Removed |Added



 Status|UNCONFIRMED |ASSIGNED

   Keywords||lto, missed-optimization

   Last reconfirmed||2013-03-01

  Component|lto |middle-end

 AssignedTo|unassigned at gcc dot   |rguenth at gcc dot gnu.org

   |gnu.org |

 Ever Confirmed|0   |1



--- Comment #2 from Richard Biener rguenth at gcc dot gnu.org 2013-03-01 
11:00:18 UTC ---

gimple_cond_single_var_p should be inlined at its single caller, it isn't

any good abstraction.



integer_zerop isn't a good enough test for what the single caller tries to

assert as far as I can see.  You'd need to test whether it's precision

is 1 as well (or whether it's BOOLEAN_TYPE).



The IR reader cannot be fixed (the middle-end shouldn't use

frontend boolean_*_node) - frontends have different representation for their

boolean_{true,false,type}_nodes.



Well.  Confirmed and mine.

[Bug middle-end/56483] LTO issue with expanding GIMPLE_COND

2013-03-01 Thread rguenth at gcc dot gnu.org 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56483



--- Comment #3 from Richard Biener rguenth at gcc dot gnu.org 2013-03-01 
11:03:24 UTC ---

Created attachment 29560

  -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=29560

patch



Patch, queued for 4.9.