[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633
--- Comment #17 from Jakub Jelinek ---
Author: jakub
Date: Fri Jul 10 14:13:19 2015
New Revision: 225677
URL: https://gcc.gnu.org/viewcvs?rev=225677&root=gcc&view=rev
Log:
Backported from mainline
2015-07-09 Jakub Jelinek
PR middle-end/66633
* tree-nested.c (get_static_chain): Or in a flag into
info->static_chain_added.
(get_frame_field, get_nonlocal_debug_decl): Likewise.
(convert_nonlocal_omp_clauses, convert_local_omp_clauses): Revert
2015-07-01 changes.
(convert_tramp_reference_stmt): If a frame_decl or chain_decl
is needed newly inside of GIMPLE_OMP_{PARALLEL,TASK,TARGET} body,
add it to clauses.
* gcc.dg/gomp/pr66633-1.c: New test.
* gcc.dg/gomp/pr66633-2.c: New test.
* gcc.dg/gomp/pr66633-3.c: New test.
* gcc.dg/gomp/pr66633-4.c: New test.
Added:
branches/gcc-5-branch/gcc/testsuite/gcc.dg/gomp/pr66633-1.c
branches/gcc-5-branch/gcc/testsuite/gcc.dg/gomp/pr66633-2.c
branches/gcc-5-branch/gcc/testsuite/gcc.dg/gomp/pr66633-3.c
branches/gcc-5-branch/gcc/testsuite/gcc.dg/gomp/pr66633-4.c
Modified:
branches/gcc-5-branch/gcc/ChangeLog
branches/gcc-5-branch/gcc/testsuite/ChangeLog
branches/gcc-5-branch/gcc/tree-nested.c
[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633 Jakub Jelinek changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #18 from Jakub Jelinek --- Fixed.
[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633
--- Comment #16 from Jakub Jelinek ---
Author: jakub
Date: Thu Jul 9 21:14:11 2015
New Revision: 225638
URL: https://gcc.gnu.org/viewcvs?rev=225638&root=gcc&view=rev
Log:
PR middle-end/66633
* tree-nested.c (get_static_chain): Or in a flag into
info->static_chain_added.
(get_frame_field, get_nonlocal_debug_decl): Likewise.
(convert_nonlocal_omp_clauses, convert_local_omp_clauses): Revert
2015-07-01 changes.
(convert_tramp_reference_stmt): If a frame_decl or chain_decl
is needed newly inside of GIMPLE_OMP_{PARALLEL,TASK,TARGET} body,
add it to clauses.
* gcc.dg/gomp/pr66633-1.c: New test.
* gcc.dg/gomp/pr66633-2.c: New test.
* gcc.dg/gomp/pr66633-3.c: New test.
* gcc.dg/gomp/pr66633-4.c: New test.
Added:
trunk/gcc/testsuite/gcc.dg/gomp/pr66633-1.c
trunk/gcc/testsuite/gcc.dg/gomp/pr66633-2.c
trunk/gcc/testsuite/gcc.dg/gomp/pr66633-3.c
trunk/gcc/testsuite/gcc.dg/gomp/pr66633-4.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree-nested.c
[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633 Jakub Jelinek changed: What|Removed |Added Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org --- Comment #15 from Jakub Jelinek --- Created attachment 35944 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35944&action=edit gcc6-pr66633.patch Untested fix.
[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633 Eric Botcazou changed: What|Removed |Added Status|RESOLVED|REOPENED CC||ebotcazou at gcc dot gnu.org Resolution|FIXED |--- Assignee|ebotcazou at gcc dot gnu.org |unassigned at gcc dot gnu.org --- Comment #14 from Eric Botcazou --- > Thanks for the fix! Unfortunately, while this fixes some instances, it still > results in an ICE with optimization at -O1 or higher. Then I probably papered over a more fundamental issue which was preexisting.
[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633 --- Comment #13 from Andrew Benson --- (In reply to Eric Botcazou from comment #12) > Fixed everywhere. Thanks for the fix! Unfortunately, while this fixes some instances, it still results in an ICE with optimization at -O1 or higher. Specifically: Original test case: compiles OK with -O0; same ICE as before with -O1 or higher Test case from comment #1: compiles OK with any optimization level.
[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633 Eric Botcazou changed: What|Removed |Added Status|ASSIGNED|RESOLVED CC|ebotcazou at gcc dot gnu.org | Resolution|--- |FIXED Target Milestone|--- |5.2 --- Comment #12 from Eric Botcazou --- Fixed everywhere.
[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633 --- Comment #11 from Eric Botcazou --- Author: ebotcazou Date: Wed Jul 1 08:24:29 2015 New Revision: 225228 URL: https://gcc.gnu.org/viewcvs?rev=225228&root=gcc&view=rev Log: PR middle-end/66633 * tree-nested.c (convert_nonlocal_omp_clauses): Initialize need_chain to true if the function is nested and if not optimizing. (convert_local_omp_clauses): Initialize need_frame to true if the function contains nested functions and if not optimizing. Added: branches/gcc-5-branch/gcc/testsuite/gfortran.dg/gomp/pr66633.f90 - copied unchanged from r225227, trunk/gcc/testsuite/gfortran.dg/gomp/pr66633.f90 Modified: branches/gcc-5-branch/gcc/ChangeLog branches/gcc-5-branch/gcc/testsuite/ChangeLog branches/gcc-5-branch/gcc/tree-nested.c
[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633 --- Comment #10 from Eric Botcazou --- Author: ebotcazou Date: Wed Jul 1 08:21:40 2015 New Revision: 225227 URL: https://gcc.gnu.org/viewcvs?rev=225227&root=gcc&view=rev Log: PR middle-end/66633 * tree-nested.c (convert_nonlocal_omp_clauses): Initialize need_chain to true if the function is nested and if not optimizing. (convert_local_omp_clauses): Initialize need_frame to true if the function contains nested functions and if not optimizing. Added: trunk/gcc/testsuite/gfortran.dg/gomp/pr66633.f90 Modified: trunk/gcc/ChangeLog trunk/gcc/testsuite/ChangeLog trunk/gcc/tree-nested.c
[Bug middle-end/66633] [5/6 regression] ICE on valid "verify_gimple failed" with OpenMP
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66633 Eric Botcazou changed: What|Removed |Added Component|fortran |middle-end --- Comment #9 from Eric Botcazou --- Recategorizing.
