[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

Andrew Pinski  changed:

   What|Removed |Added

   Keywords||wrong-code
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Andrew Pinski  ---
Fixed.

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[hjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #13 from hjl at gcc dot gnu.org  ---
Author: hjl
Date: Wed Aug 10 15:03:02 2016
New Revision: 239326

URL: https://gcc.gnu.org/viewcvs?rev=239326=gcc=rev
Log:
Fix PR tree-optimization/71734

2016-08-10  Yuri Rumyantsev  

PR tree-optimization/71734
* tree-ssa-loop-im.c (ref_indep_loop_p): Add new argument
REF_LOOP, invoke ref_indep_loop_p_1.
(outermost_indep_loop): Pass LOOP argumnet where REF was defined
to ref_indep_loop_p.
(ref_indep_loop_p_1): Fix commentary, add argument REF_LOOP,
combine it with ref_indep_lopp_p_2, update SAFELEN if only REF
is inside LOOP, do not cache dpendence value for loops with
non-zero SAFELEN.
(ref_indep_loop_p_2): Delete function.
(can_sm_ref_p): Pass LOOP as additional argument to
ref_indep_loop_p.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/tree-ssa-loop-im.c

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #12 from Bill Seurer  ---
Those fail for power as well:

https://gcc.gnu.org/ml/gcc-testresults/2016-07/msg01737.html

=== libgomp tests ===


Running target unix
FAIL: libgomp.fortran/simd3.f90   -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  execution test
FAIL: libgomp.fortran/simd3.f90   -O3 -g  execution test
FAIL: libgomp.fortran/simd4.f90   -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  execution test
FAIL: libgomp.fortran/simd4.f90   -O3 -g  execution test

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[sch...@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #11 from Andreas Schwab  ---
http://gcc.gnu.org/ml/gcc-testresults/2016-07/msg01768.html

FAIL: libgomp.fortran/simd3.f90   -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  execution test
FAIL: libgomp.fortran/simd3.f90   -O3 -g  execution test
FAIL: libgomp.fortran/simd4.f90   -O3 -fomit-frame-pointer -funroll-loops
-fpeel-loops -ftracer -finline-functions  execution test
FAIL: libgomp.fortran/simd4.f90   -O3 -g  execution test

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[ienkovich at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #10 from Ilya Enkovich  ---
Author: ienkovich
Date: Thu Jul 28 14:19:18 2016
New Revision: 238817

URL: https://gcc.gnu.org/viewcvs?rev=238817=gcc=rev
Log:
gcc/

2016-07-28  Yuri Rumyantsev  

PR tree-optimization/71734
* tree-ssa-loop-im.c (ref_indep_loop_p_1): Pass value of safelen
attribute instead of REF_LOOP and use it.
(ref_indep_loop_p_2): Use SAFELEN argument instead of REF_LOOP and
set it for Loops having non-zero safelen attribute.
(ref_indep_loop_p): Pass zero as initial value for safelen.

gcc/testsuite/

2016-07-28  Yuri Rumyantsev  

PR tree-optimization/71734
* g++.dg/vect/pr70729-nest.cc: New test.

Added:
trunk/gcc/testsuite/g++.dg/vect/pr70729-nest.cc
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree-ssa-loop-im.c

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #9 from Jakub Jelinek  ---
Author: jakub
Date: Tue Jul 19 16:47:30 2016
New Revision: 238482

URL: https://gcc.gnu.org/viewcvs?rev=238482=gcc=rev
Log:
PR middle-end/71734
* g++.dg/vect/pr70729.cc: Don't include string.h or xmmintrin.h.
(my_alloc): Rewritten to use __builtin_posix_memalign and
__SIZE_TYPE__.
(my_free): Use __builtin_free instead of _mm_free.
(Vec::operator=): Use __builtin_memcpy.

Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/g++.dg/vect/pr70729.cc

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #8 from Jakub Jelinek  ---
Created attachment 38930
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=38930=edit
gcc7-pr71734.patch

The bug is of course in using (uselessly) an x86_64/i?86 specific intrinsic
headers in a generic test on all architectures.
There is no need to use that header though, it fails the same way with
__builtin_posix_memalign/__builtin_free, and as it is a compile time only test,
we don't care if the library implements it or not.

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[ysrumyan at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #7 from Yuri Rumyantsev  ---
H.J.

I've just checked this test with my local fixed compiler and got:
Running /users/ysrumyan/workspaces/71261/gcc/testsuite/g++.dg/vect/vect.exp ...
PASS: g++.dg/vect/pr70729.cc  -std=c++11  scan-tree-dump vect "LOOP VECTORIZED"
PASS: g++.dg/vect/pr70729.cc  -std=c++11 (test for excess errors)
PASS: g++.dg/vect/pr70729.cc  -std=c++14  scan-tree-dump vect "LOOP VECTORIZED"
PASS: g++.dg/vect/pr70729.cc  -std=c++14 (test for excess errors)
PASS: g++.dg/vect/pr70729.cc  -std=c++98  scan-tree-dump vect "LOOP VECTORIZED"
PASS: g++.dg/vect/pr70729.cc  -std=c++98 (test for excess errors)

So it looks like not my fault.

2016-07-18 21:38 GMT+03:00 seurer at linux dot vnet.ibm.com
:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734
>
> Bill Seurer  changed:
>
>What|Removed |Added
> 
>  CC||seurer at linux dot 
> vnet.ibm.com
>
> --- Comment #6 from Bill Seurer  ---
> Looks like the simd3/4 tests now work with this patch but
> g++.dg/vect/pr70729.cc now fails:
>
> FAIL: g++.dg/vect/pr70729.cc  -std=c++98 (test for excess errors)
> FAIL: g++.dg/vect/pr70729.cc  -std=c++11 (test for excess errors)
> FAIL: g++.dg/vect/pr70729.cc  -std=c++14 (test for excess errors)
>
> In the log I see
>
> /tmp/cc3mxFhd.s: Assembler messages:
> /tmp/cc3mxFhd.s:29: Error: unrecognized opcode: `xsxexpdp'
> compiler exited with status 1
>
> and also
>
> /home/seurer/gcc/gcc-test/gcc/testsuite/g++.dg/vect/pr70729.cc:7:10: fatal
> error: xmmintrin.h: No such file or directory
> compilation terminated.
> compiler exited with status 1
>
>
> Maybe some of the options you removed weren't really redundant?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

Bill Seurer  changed:

   What|Removed |Added

 CC||seurer at linux dot 
vnet.ibm.com

--- Comment #6 from Bill Seurer  ---
Looks like the simd3/4 tests now work with this patch but
g++.dg/vect/pr70729.cc now fails:

FAIL: g++.dg/vect/pr70729.cc  -std=c++98 (test for excess errors)
FAIL: g++.dg/vect/pr70729.cc  -std=c++11 (test for excess errors)
FAIL: g++.dg/vect/pr70729.cc  -std=c++14 (test for excess errors)

In the log I see

/tmp/cc3mxFhd.s: Assembler messages:
/tmp/cc3mxFhd.s:29: Error: unrecognized opcode: `xsxexpdp'
compiler exited with status 1

and also

/home/seurer/gcc/gcc-test/gcc/testsuite/g++.dg/vect/pr70729.cc:7:10: fatal
error: xmmintrin.h: No such file or directory
compilation terminated.
compiler exited with status 1


Maybe some of the options you removed weren't really redundant?

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[ienkovich at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #5 from Ilya Enkovich  ---
Author: ienkovich
Date: Mon Jul 18 14:30:20 2016
New Revision: 238435

URL: https://gcc.gnu.org/viewcvs?rev=238435=gcc=rev
Log:
gcc/

2016-07-18  Yuri Rumyantsev  

PR tree-optimization/71734
* tree-ssa-loop-im.c (ref_indep_loop_p_1): Add REF_LOOP argument which
contains REF, use it to check safelen, assume that safelen value
must be greater 1, fix style.
(ref_indep_loop_p_2): Add REF_LOOP argument.
(ref_indep_loop_p): Pass LOOP as additional argument to
ref_indep_loop_p_2.

gcc/testsuite/

2016-07-18  Yuri Rumyantsev  

PR tree-optimization/71734
* g++.dg/vect/pr70729.cc: Delete redundant dg options, fix style.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/g++.dg/vect/pr70729.cc
trunk/gcc/tree-ssa-loop-im.c

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

Jakub Jelinek  changed:

   What|Removed |Added

 CC||jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek  ---
See my comment in PR70729.

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[hjl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #3 from hjl at gcc dot gnu.org  ---
Author: hjl
Date: Sun Jul  3 16:40:22 2016
New Revision: 237950

URL: https://gcc.gnu.org/viewcvs?rev=237950=gcc=rev
Log:
Add 2 tests for PR middle-end/71734

simd3.f90 and simd4.f90 fail only with -msse2.  But they are compiled
with -mavx on AVX machines.  Add 2 tests to compile simd3.f90 and
simd4.f90 with -msse2 on AVX machines.

PR middle-end/71734
* testsuite/libgomp.fortran/pr71734-1.f90: New test.
* testsuite/libgomp.fortran/pr71734-2.f90: Likewise.

Added:
trunk/libgomp/testsuite/libgomp.fortran/pr71734-1.f90
trunk/libgomp/testsuite/libgomp.fortran/pr71734-2.f90
Modified:
trunk/libgomp/ChangeLog

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

--- Comment #2 from H.J. Lu  ---
Created attachment 38822
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=38822=edit
Testcases

[Bug middle-end/71734] [7 Regression] FAIL: libgomp.fortran/simd4.f90 -O3 -g execution test

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71734

H.J. Lu  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2016-07-01
   Target Milestone|--- |7.0
 Ever confirmed|0   |1

--- Comment #1 from H.J. Lu  ---
Both tests have

simd3.f90:! { dg-additional-options "-mavx" { target avx_runtime } }
simd4.f90:! { dg-additional-options "-mavx" { target avx_runtime } }

-mavx hides this regression. All those SIMD tests with

{ dg-additional-options "-mavx" { target avx_runtime } }

should also have the counter parts without it so that SSE SIMD tests will
run on AVX machines.