[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-03-01 Thread gaius at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

Gaius Mulley  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Gaius Mulley  ---
Many thanks for the bug report - I think it also helped the armv7l and aarch64
- timeout in runtests.  The calls to RegisterModule were generically wrong of
course on all targets.  Thanks for testing!

[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-03-01 Thread ro at CeBiTec dot Uni-Bielefeld.DE via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

--- Comment #7 from ro at CeBiTec dot Uni-Bielefeld.DE  ---
> --- Comment #6 from Gaius Mulley  ---
> Do the above fixes resolve this PR ?

The revised version did indeed.  I'd included it in last night's
bootstraps and everything is fine again.  Thanks for the quick fix.

[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-03-01 Thread gaius at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

--- Comment #6 from Gaius Mulley  ---
Do the above fixes resolve this PR ?

[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-02-28 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

--- Comment #5 from CVS Commits  ---
The master branch has been updated by Gaius Mulley :

https://gcc.gnu.org/g:62ed1066196c81ab1fad13b2cc5ebbfe887138f9

commit r13-6378-g62ed1066196c81ab1fad13b2cc5ebbfe887138f9
Author: Gaius Mulley 
Date:   Tue Feb 28 15:35:12 2023 +

Fix build warnings noreturn M2RTS and fix calls to RegisterModule
[PR108956]

mc needs a fix to optionally suppress the generation of the noreturn
attribute when building M2RTS.  All the hand built C++ modules calling
RegisterModule must supply the library name.  These changes require
the boot strap tools mc and pge to be rebuilt.

gcc/m2/ChangeLog:

PR modula2/108956
* Make-lang.in (m2/gm2-libs-boot/M2RTS.o): New specific rule to
add the --suppress-noreturn option.
* Make-maintainer.in (m2/gm2-ppg-boot/$(SRC_PREFIX)M2RTS.o): New
specific rule to add the --suppress-noreturn option.
(m2/gm2-pg-boot/$(SRC_PREFIX)M2RTS.o): New
specific rule to add the --suppress-noreturn option.
(m2/gm2-pg-boot/$(SRC_PREFIX)%.o): Add missing $(srcdir).
(m2/gm2-pge-boot/$(SRC_PREFIX)M2RTS.o): New
specific rule to add the --suppress-noreturn option.
(m2/gm2-pge-boot/$(SRC_PREFIX)%.o): Add missing $(srcdir).
* gm2-libs-ch/UnixArgs.cc (LIBNAME): New define.
(_M2_UnixArgs_ctor): Add LIBNAME parameter to RegisterModule.
* gm2-libs-ch/dtoa.cc (LIBNAME): New define.
(_M2_dtoa_ctor): Add LIBNAME parameter to RegisterModule.
* gm2-libs-ch/ldtoa.cc (LIBNAME): New define.
(_M2_ldtoa_ctor): Add LIBNAME parameter to RegisterModule.
* pge-boot/m2rts.h (M2RTS_RegisterModule): Add libname
parameter.
* gm2-libs-ch/m2rts.h (M2RTS_RegisterModule): Add libname
parameter.
* mc-boot-ch/GUnixArgs.cc (_M2_UnixArgs_ctor): Remove.
* pge-boot/GUnixArgs.cc (LIBNAME): New define.
(_M2_UnixArgs_ctor): Add LIBNAME parameter to RegisterModule.
* gm2-libs/RTint.def (AttachVector): Rename parameter.
* mc-boot/GDynamicStrings.c: Rebuilt.
* mc-boot/GFIO.c: Rebuilt.
* mc-boot/GIndexing.c: Rebuilt.
* mc-boot/GM2EXCEPTION.c: Rebuilt.
* mc-boot/GPushBackInput.c: Rebuilt.
* mc-boot/GRTExceptions.c: Rebuilt.
* mc-boot/GRTint.c: Rebuilt.
* mc-boot/GRTint.h: Rebuilt.
* mc-boot/GStdIO.c: Rebuilt.
* mc-boot/GStringConvert.c: Rebuilt.
* mc-boot/GSysStorage.c: Rebuilt.
* mc-boot/Gdecl.c: Rebuilt.
* mc-boot/Gkeyc.c: Rebuilt.
* mc-boot/GmcComment.c: Rebuilt.
* mc-boot/GmcComp.c: Rebuilt.
* mc-boot/GmcDebug.c: Rebuilt.
* mc-boot/GmcMetaError.c: Rebuilt.
* mc-boot/GmcOptions.c: Rebuilt.
* mc-boot/GmcOptions.h: Rebuilt.
* mc-boot/GmcStack.c: Rebuilt.
* mc-boot/GnameKey.c: Rebuilt.
* mc-boot/GsymbolKey.c: Rebuilt.
* mc/decl.mod:: Rebuilt.
* mc/mcOptions.def: Rebuilt.
* mc/mcOptions.mod:: Rebuilt.
* pge-boot/GDynamicStrings.c: Rebuilt.
* pge-boot/GFIO.c: Rebuilt.
* pge-boot/GIndexing.c: Rebuilt.
* pge-boot/GM2EXCEPTION.c: Rebuilt.
* pge-boot/GM2RTS.c: Rebuilt.
* pge-boot/GNameKey.c: Rebuilt.
* pge-boot/GPushBackInput.c: Rebuilt.
* pge-boot/GRTExceptions.c: Rebuilt.
* pge-boot/GStdIO.c: Rebuilt.
* pge-boot/GSymbolKey.c: Rebuilt.
* pge-boot/GSysStorage.c: Rebuilt.

Signed-off-by: Gaius Mulley 

[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-02-28 Thread gaius at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

Gaius Mulley  changed:

   What|Removed |Added

  Attachment #54553|0   |1
is obsolete||

--- Comment #4 from Gaius Mulley  ---
Created attachment 54556
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54556=edit
Proposed fix v3

Apologies - I mischecked the wrong UnixArgs.c.  Here is version 3 with the pge
UnixArgs.c changed to include the library name.

[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-02-28 Thread ro at CeBiTec dot Uni-Bielefeld.DE via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

--- Comment #3 from ro at CeBiTec dot Uni-Bielefeld.DE  ---
> --- Comment #2 from Gaius Mulley  ---
> The hand built modules were not changed to include the libname.  (UnixArgs,
> ldtoa, dtoa for the tool pge).  The patch corrects the hand built modules and
> also includes fixes for the attribute noreturn warnings generated when
> compiling M2RTS.cc.

Unfortunately, this didn't help: the SEGV and caller/callee mismatch
remain exactly the same.

[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-02-27 Thread gaius at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

--- Comment #2 from Gaius Mulley  ---
The hand built modules were not changed to include the libname.  (UnixArgs,
ldtoa, dtoa for the tool pge).  The patch corrects the hand built modules and
also includes fixes for the attribute noreturn warnings generated when
compiling M2RTS.cc.

[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-02-27 Thread gaius at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

Gaius Mulley  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Last reconfirmed||2023-02-28
 Status|UNCONFIRMED |ASSIGNED

[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-02-27 Thread gaius at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

Gaius Mulley  changed:

   What|Removed |Added

 CC||gaius at gcc dot gnu.org

--- Comment #1 from Gaius Mulley  ---
Created attachment 54553
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54553=edit
Proposed fix

Thanks for the bug report - here is a proposed fix.

[Bug modula2/108956] [13 regression] SEGV in M2RTS_RegisterModule

2023-02-27 Thread ro at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108956

Rainer Orth  changed:

   What|Removed |Added

   Target Milestone|--- |13.0