[Bug other/104181] [12 Regression] The redundant build.log file in the root directory

2022-01-24 Thread marxin at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104181

--- Comment #9 from Martin Liška  ---
(In reply to Jakub Jelinek from comment #6)
> I think it is only the toplevel directory.
> E.g. note also r12-6491-g49ad4d2c30387ec916b16ddc1e235bcb5e53b3b2
> which had toplevel empty Makefile.am added, had Makefile.am mentioned in the
> ChangeLog entry but really meant libgfortran/ one (and the text from it went
> to libgfortran/ one only).
> The toplevel ChangeLog has:
> 2022-01-11  Thomas Koenig  
> 
> * Makefile.am: New file.
> 
> ...
> 
> 2022-01-07  liuhongt  
> 
> * build.log: New file.
> 
> for these two.

All right, so I'll add forbidden files: './Makefile.{in,am}' and 'build.log',
ok?

[Bug other/104181] [12 Regression] The redundant build.log file in the root directory

2022-01-24 Thread marxin at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104181

--- Comment #8 from Martin Liška  ---
(In reply to Jakub Jelinek from comment #7)
> Don't we have a rule for New file. additions without ChangeLog coverage?

No.

> I thought that was supposed to be for the testsuite directories only, but
> maybe it triggers here too.

For tests we automatically generate 'New test.'. For other files: 'New file.'.

[Bug other/104181] [12 Regression] The redundant build.log file in the root directory

2022-01-24 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104181

--- Comment #7 from Jakub Jelinek  ---
Don't we have a rule for New file. additions without ChangeLog coverage?
I thought that was supposed to be for the testsuite directories only, but maybe
it triggers here too.

[Bug other/104181] [12 Regression] The redundant build.log file in the root directory

2022-01-24 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104181

Jakub Jelinek  changed:

   What|Removed |Added

 CC||jakub at gcc dot gnu.org

--- Comment #6 from Jakub Jelinek  ---
I think it is only the toplevel directory.
E.g. note also r12-6491-g49ad4d2c30387ec916b16ddc1e235bcb5e53b3b2
which had toplevel empty Makefile.am added, had Makefile.am mentioned in the
ChangeLog entry but really meant libgfortran/ one (and the text from it went to
libgfortran/ one only).
The toplevel ChangeLog has:
2022-01-11  Thomas Koenig  

* Makefile.am: New file.

...

2022-01-07  liuhongt  

* build.log: New file.

for these two.

[Bug other/104181] [12 Regression] The redundant build.log file in the root directory

2022-01-24 Thread marxin at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104181

--- Comment #5 from Martin Liška  ---
(In reply to Richard Biener from comment #4)
> Fixed, but maybe we can look to reject this in the ChangeLog verifier?

Sure, that's possible. Do we speak about build.log in root directory, or at any
path?

[Bug other/104181] [12 Regression] The redundant build.log file in the root directory

2022-01-24 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104181

Richard Biener  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
 CC||marxin at gcc dot gnu.org

--- Comment #4 from Richard Biener  ---
Fixed, but maybe we can look to reject this in the ChangeLog verifier?

[Bug other/104181] [12 Regression] The redundant build.log file in the root directory

2022-01-22 Thread egallager at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104181

Eric Gallager  changed:

   What|Removed |Added

 CC||egallager at gcc dot gnu.org
   Keywords||build
   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=103331

--- Comment #3 from Eric Gallager  ---
How does build.log even get generated, anyways? Wondering for bug 103331...

[Bug other/104181] [12 Regression] The redundant build.log file in the root directory

2022-01-22 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104181

--- Comment #2 from CVS Commits  ---
The master branch has been updated by Jakub Jelinek :

https://gcc.gnu.org/g:0f4f9c0085eb68e0546804b156aa8bb388f2d3e0

commit r12-6815-g0f4f9c0085eb68e0546804b156aa8bb388f2d3e0
Author: Jakub Jelinek 
Date:   Sat Jan 22 12:03:14 2022 +0100

toplevel: Remove accedentally checked in file

This has been added in r12-6342-ge7a7dbb5ca5dd69689f1a probably
by accident.

2022-01-22  Jakub Jelinek  

PR other/104181
* build.log: Remove.

[Bug other/104181] [12 Regression] The redundant build.log file in the root directory

2022-01-22 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104181

Jonathan Wakely  changed:

   What|Removed |Added

 CC||crazylht at gmail dot com
Summary|The redundant build.log |[12 Regression] The
   |file in the root directory  |redundant build.log file in
   ||the root directory
 Status|UNCONFIRMED |NEW
   Target Milestone|--- |12.0
 Ever confirmed|0   |1
   Last reconfirmed||2022-01-22

--- Comment #1 from Jonathan Wakely  ---
Added by g:e7a7dbb5ca5dd69689f1a462ba7620180acfe8b0

How did the commit hooks not reject this?