[Bug preprocessor/109704] #pragma {push,pop}_macro broken for identifiers that contain dollar signs at nonfirst positions

[lhyatt at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109704

Lewis Hyatt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Last reconfirmed||2024-01-13
 Status|UNCONFIRMED |NEW
   Keywords||patch
URL||https://gcc.gnu.org/piperma
   ||il/gcc-patches/2024-January
   ||/642926.html

--- Comment #4 from Lewis Hyatt  ---
Patch submitted for review at
https://gcc.gnu.org/pipermail/gcc-patches/2024-January/642926.html

[Bug preprocessor/109704] #pragma {push,pop}_macro broken for identifiers that contain dollar signs at nonfirst positions

[lhyatt at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109704

Lewis Hyatt  changed:

   What|Removed |Added

 CC||lhyatt at gcc dot gnu.org

--- Comment #3 from Lewis Hyatt  ---
We are also not handling UTF-8 identifiers for push_macro and pop_macro
pragmas. I was going to try to add this sometime, which would naturally handle
the case of $ as well.

[Bug preprocessor/109704] #pragma {push,pop}_macro broken for identifiers that contain dollar signs at nonfirst positions

[pinskia at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109704

--- Comment #2 from Andrew Pinski  ---
(In reply to Andrew Pinski from comment #1)
> Well $ is an extension and MSVC does not support $, push_macro/pop_macro
> were for compatibility for MSVC too.

Well they don't support $ in their C front-end but does in their C++ front-end.

[Bug preprocessor/109704] #pragma {push,pop}_macro broken for identifiers that contain dollar signs at nonfirst positions

[pinskia at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109704

--- Comment #1 from Andrew Pinski  ---
Well $ is an extension and MSVC does not support $, push_macro/pop_macro were
for compatibility for MSVC too.