[Bug preprocessor/62661] digit separator warning in if'ed out code

[jakub at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62661

Jakub Jelinek  changed:

   What|Removed |Added

 CC||jakub at gcc dot gnu.org

--- Comment #7 from Jakub Jelinek  ---
I think it is PR14634 that actually changed this.
The question is if we can avoid the pedwarn in system headers, or if it should
be kind of pedwarn that isn't emitted as a warning without
-pedantic/-Wpedantic.

[Bug preprocessor/62661] digit separator warning in if'ed out code

[redi at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62661

--- Comment #6 from Jonathan Wakely  ---
What's really fun is that you can't even do:

#if __cpp_digit_separators
int i = 1'000;
#else
int i = 1000;
#endif

[Bug preprocessor/62661] digit separator warning in if'ed out code

[pinskia at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62661

Andrew Pinski  changed:

   What|Removed |Added

   See Also||https://gcc.gnu.org/bugzill
   ||a/show_bug.cgi?id=11064

--- Comment #5 from Andrew Pinski  ---
Similar issue as PR 11064.

[Bug preprocessor/62661] digit separator warning in if'ed out code

[rguenth at gcc dot gnu.org via Gcc-bugs]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62661

Richard Biener  changed:

   What|Removed |Added

 CC||david.post at ohyonghao dot com

--- Comment #4 from Richard Biener  ---
*** Bug 101628 has been marked as a duplicate of this bug. ***

[Bug preprocessor/62661] digit separator warning in if'ed out code

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62661

Andrew Pinski  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Andrew Pinski  ---
(In reply to Jonathan Wakely from comment #2)
> But in C++14 tokenization should handle digit separators, see the definition
> of pp-number in 2.9 [lex.ppnumber], which allows single quotes in a
> pp-number.

Right it does not warn for C++14 and above so there is no bug and even was
mention in the original comment:
C or C++ < C++14

[Bug preprocessor/62661] digit separator warning in if'ed out code

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62661

Jonathan Wakely  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
   Last reconfirmed||2015-11-25
 Resolution|DUPLICATE   |---
 Ever confirmed|0   |1

--- Comment #2 from Jonathan Wakely  ---
(In reply to Andrew Pinski from comment #1)
> This is correct tokenization has to happen in #if code.

But in C++14 tokenization should handle digit separators, see the definition of
pp-number in 2.9 [lex.ppnumber], which allows single quotes in a pp-number.

[Bug preprocessor/62661] digit separator warning in if'ed out code

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62661

Andrew Pinski pinskia at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Component|c++ |preprocessor
 Resolution|--- |DUPLICATE

--- Comment #1 from Andrew Pinski pinskia at gcc dot gnu.org ---
This is correct tokenization has to happen in #if code.

*** This bug has been marked as a duplicate of bug 11806 ***