[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 Dominique d'Humieres changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Dominique d'Humieres --- > So fixed? AFAICT from my tests on darwin10 and 16 yes! Closing.
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 --- Comment #10 from Jakub Jelinek --- So fixed?
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 --- Comment #9 from chefmax at gcc dot gnu.org --- Author: chefmax Date: Fri Feb 3 12:17:59 2017 New Revision: 245149 URL: https://gcc.gnu.org/viewcvs?rev=245149=gcc=rev Log: PR sanitizer/78663 * sanitizer_common/sanitizer_mac.cc: Cherry-pick upstream r293992. * sanitizer_common/sanitizer_platform_interceptors.h: Likewise. Modified: trunk/libsanitizer/ChangeLog trunk/libsanitizer/sanitizer_common/sanitizer_mac.cc trunk/libsanitizer/sanitizer_common/sanitizer_platform_interceptors.h
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 --- Comment #8 from Dominique d'Humieres --- > Created attachment 40646 > --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40646=edit > Fix 2 I have tested the patch on darwin10 and 16. On darwin10 the failures are fixed as with the Iain's patch, no regression on darwin16. Thanks.
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 --- Comment #7 from Maxim Ostapenko --- Created attachment 40646 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40646=edit Fix 2 Iain, could you test the following patch? This one is likely to be applied upstream. As a side note, LLVM folks are not very happy with these patches (they lack of buildbots to test them). Thus I suspect that for future releases we'll need a) apply Darwin 10 patches locally or b) disable ASan for Darwin 10.
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 --- Comment #6 from Maxim Ostapenko --- (In reply to Maxim Ostapenko from comment #5) > (In reply to Iain Sandoe from comment #4) > > (In reply to Jakub Jelinek from comment #3) > > > Have you raised this with compiler-rt upstream already? > > > > I don't believe that upstream supports the sanitisers for Darwin < 11. > > > > However, as seen, they are quite capable of function with a little TLC. I > > don't have a chance to progress this until at least mid-Feb, if it's more > > urgent, then (a) please adopt some version of the patch locally, or (b) > > disable for Darwin < 11. > > They don't, but they can actually accept the patch for Darwin 10 (I used to > commit such patches after previous merge). > I can post attached fix upstream, but than I'll ask you (or Dominique) for > help in testing if they won't accept the patch as it is (most likely they > won't). I've initiated discussion upstream: https://reviews.llvm.org/D29287
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 Maxim Ostapenko changed: What|Removed |Added CC||m.ostapenko at samsung dot com --- Comment #5 from Maxim Ostapenko --- (In reply to Iain Sandoe from comment #4) > (In reply to Jakub Jelinek from comment #3) > > Have you raised this with compiler-rt upstream already? > > I don't believe that upstream supports the sanitisers for Darwin < 11. > > However, as seen, they are quite capable of function with a little TLC. I > don't have a chance to progress this until at least mid-Feb, if it's more > urgent, then (a) please adopt some version of the patch locally, or (b) > disable for Darwin < 11. They don't, but they can actually accept the patch for Darwin 10 (I used to commit such patches after previous merge). I can post attached fix upstream, but than I'll ask you (or Dominique) for help in testing if they won't accept the patch as it is (most likely they won't).
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 --- Comment #4 from Iain Sandoe --- (In reply to Jakub Jelinek from comment #3) > Have you raised this with compiler-rt upstream already? I don't believe that upstream supports the sanitisers for Darwin < 11. However, as seen, they are quite capable of function with a little TLC. I don't have a chance to progress this until at least mid-Feb, if it's more urgent, then (a) please adopt some version of the patch locally, or (b) disable for Darwin < 11.
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 --- Comment #3 from Jakub Jelinek --- Have you raised this with compiler-rt upstream already?
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 Richard Biener changed: What|Removed |Added Target||x86_64-apple-darwin10 Priority|P3 |P1
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 --- Comment #2 from Jakub Jelinek --- This probably needs to go to upstream compiler-rt first. Also, it would be cleaner not to define SI_MEMMEM to 1 on Windows and move the comment there.
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 Richard Biener changed: What|Removed |Added Target Milestone|--- |7.0
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 --- Comment #1 from Dominique d'Humieres --- Created attachment 40240 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40240=edit Patch from Iain Sandoe Results with the patch at https://gcc.gnu.org/ml/gcc-testresults/2016-12/msg00469.html.
[Bug sanitizer/78663] [7 Regression] Hundreds of asan failures on x86_64-apple-darwin10 at r243019
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78663 Dominique d'Humieres changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2016-12-04 Ever confirmed|0 |1
