[Bug target/112606] [14 Regression] powerpc64le-linux-gnu: 'FAIL: gcc.target/powerpc/p8vector-fp.c scan-assembler xsnabsdp'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112606 Kewen Lin changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #7 from Kewen Lin --- Should be fixed on trunk now.
[Bug target/112606] [14 Regression] powerpc64le-linux-gnu: 'FAIL: gcc.target/powerpc/p8vector-fp.c scan-assembler xsnabsdp'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112606 --- Comment #6 from GCC Commits --- The master branch has been updated by Kewen Lin : https://gcc.gnu.org/g:cf5f6a048e376ab0d2f7bc283c158605e1166061 commit r14-7090-gcf5f6a048e376ab0d2f7bc283c158605e1166061 Author: Kewen Lin Date: Tue Jan 9 23:06:12 2024 -0600 rs6000: Make copysign (x, -1) back to -abs (x) for IEEE128 float [PR112606] I noticed that commit r14-6192 can't help PR112606 #c3 as it only takes care of SF/DF but TF/KF can still suffer the issue. Similar to commit r14-6192, this patch is to take care of copysign3 with IEEE128 as well. PR target/112606 gcc/ChangeLog: * config/rs6000/rs6000.md (copysign3 IEEE128): Change predicate of the last argument from altivec_register_operand to any_operand. If operands[2] is CONST_DOUBLE, emit abs or neg abs depending on its sign otherwise if it doesn't satisfy altivec_register_operand, force it to REG using copy_to_mode_reg.
[Bug target/112606] [14 Regression] powerpc64le-linux-gnu: 'FAIL: gcc.target/powerpc/p8vector-fp.c scan-assembler xsnabsdp'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112606 Kewen Lin changed: What|Removed |Added Assignee|unassigned at gcc dot gnu.org |linkw at gcc dot gnu.org Last reconfirmed||2024-01-08 Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 --- Comment #5 from Kewen Lin --- (In reply to seurer from comment #3) > These tests also fail starting with > g:9e9279fadbd1c673c875b9d20261d2de0473f63f, r14-5542-g9e9279fadbd1c6 > > FAIL: gcc.target/powerpc/float128-hw5.c scan-assembler-not \\mxscpsgnqp\\M > FAIL: gcc.target/powerpc/float128-hw5.c scan-assembler-times \\mxsnabsqp\\M 1 > FAIL: gcc.target/powerpc/float128-hw7.c scan-assembler-not \\mxscpsgnqp\\M > FAIL: gcc.target/powerpc/float128-hw7.c scan-assembler-times \\mxsnabsqp\\M 1 These failures are related to ieee128, the #c4 only handles float/double, a similar patch was posted for ieee128: https://gcc.gnu.org/pipermail/gcc-patches/2024-January/642092.html
[Bug target/112606] [14 Regression] powerpc64le-linux-gnu: 'FAIL: gcc.target/powerpc/p8vector-fp.c scan-assembler xsnabsdp'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112606 --- Comment #4 from GCC Commits --- The master branch has been updated by Jakub Jelinek : https://gcc.gnu.org/g:58d5546af901364f85588fe668559d76f09e6df9 commit r14-6192-g58d5546af901364f85588fe668559d76f09e6df9 Author: Jakub Jelinek Date: Tue Dec 5 21:39:31 2023 +0100 rs6000: Canonicalize copysign (x, -1) back to -abs (x) in the backend [PR112606] The middle-end has been changed quite recently to canonicalize -abs (x) to copysign (x, -1) rather than the other way around. While I agree with that at GIMPLE level, since it matches the GIMPLE goal of as few operations as possible for a canonical form (-abs (x) is 2 GIMPLE statements, copysign (x, -1) is just one), I must say I don't really like that being done on RTL as well (or at least not canonicalizing (COPYSIGN x, negative) back to (NEG (ABS x))), because on most targets most of floating point constants need to be loaded from memory, there are a few exceptions but -1 is often not one of them. Anyway, the following patch fixes the rs6000 regression caused by the change in GIMPLE canonicalization (i.e. the desirable one). As rs6000 clearly prefers -abs (x) form because it has a single instruction to do that while it also has copysign instruction, but that requires loading the -1 from memory, the following patch just ensures the copysign expander can actually see the floating point constant and in that case emits the -abs (x) code (or in the hypothetical case of copysign with non-negative constant abs (x) - but there copysign (x, 1) in GIMPLE is canonicalized to abs (x)), otherwise forces the operand to be the expected gpc_reg_operand and does what it did before. 2023-12-05 Jakub Jelinek PR target/112606 * config/rs6000/rs6000.md (copysign3): Change predicate of the last argument from gpc_reg_operand to any_operand. If operands[2] is CONST_DOUBLE, emit abs or neg abs depending on its sign, otherwise if it doesn't satisfy gpc_reg_operand, force it to REG using copy_to_mode_reg.
[Bug target/112606] [14 Regression] powerpc64le-linux-gnu: 'FAIL: gcc.target/powerpc/p8vector-fp.c scan-assembler xsnabsdp'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112606 seurer at gcc dot gnu.org changed: What|Removed |Added CC||seurer at gcc dot gnu.org --- Comment #3 from seurer at gcc dot gnu.org --- These tests also fail starting with g:9e9279fadbd1c673c875b9d20261d2de0473f63f, r14-5542-g9e9279fadbd1c6 FAIL: gcc.target/powerpc/float128-hw5.c scan-assembler-not \\mxscpsgnqp\\M FAIL: gcc.target/powerpc/float128-hw5.c scan-assembler-times \\mxsnabsqp\\M 1 FAIL: gcc.target/powerpc/float128-hw7.c scan-assembler-not \\mxscpsgnqp\\M FAIL: gcc.target/powerpc/float128-hw7.c scan-assembler-times \\mxsnabsqp\\M 1
[Bug target/112606] [14 Regression] powerpc64le-linux-gnu: 'FAIL: gcc.target/powerpc/p8vector-fp.c scan-assembler xsnabsdp'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112606
Jakub Jelinek changed:
What|Removed |Added
CC||jakub at gcc dot gnu.org
--- Comment #2 from Jakub Jelinek ---
So
2023-11-24 Jakub Jelinek
PR target/112606
* config/rs6000/rs6000.md (copysign3): Change predicate
of the last argument from gpc_reg_operand to any_operand. If
operands[2] is CONST_DOUBLE, emit abs or neg abs depending on
its sign, otherwise if it doesn't satisfy gpc_reg_operand,
force it to REG using copy_to_mode_reg.
--- gcc/config/rs6000/rs6000.md.jj 2023-10-13 19:34:43.927834877 +0200
+++ gcc/config/rs6000/rs6000.md 2023-11-24 18:54:13.587876170 +0100
@@ -5358,7 +5358,7 @@ (define_expand "copysign3"
(set (match_dup 4)
(neg:SFDF (abs:SFDF (match_dup 1
(set (match_operand:SFDF 0 "gpc_reg_operand")
-(if_then_else:SFDF (ge (match_operand:SFDF 2 "gpc_reg_operand")
+ (if_then_else:SFDF (ge (match_operand:SFDF 2 "any_operand")
(match_dup 5))
(match_dup 3)
(match_dup 4)))]
@@ -5369,6 +5369,24 @@ (define_expand "copysign3"
|| TARGET_CMPB
|| VECTOR_UNIT_VSX_P (mode))"
{
+ /* Middle-end canonicalizes -fabs (x) to copysign (x, -1),
+ but PowerPC prefers -fabs (x). */
+ if (CONST_DOUBLE_AS_FLOAT_P (operands[2]))
+{
+ if (real_isneg (CONST_DOUBLE_REAL_VALUE (operands[2])))
+ {
+ operands[3] = gen_reg_rtx (mode);
+ emit_insn (gen_abs2 (operands[3], operands[1]));
+ emit_insn (gen_neg2 (operands[0], operands[3]));
+ }
+ else
+ emit_insn (gen_abs2 (operands[0], operands[1]));
+ DONE;
+}
+
+ if (!gpc_reg_operand (operands[2], mode))
+operands[2] = copy_to_mode_reg (mode, operands[2]);
+
if (TARGET_CMPB || VECTOR_UNIT_VSX_P (mode))
{
emit_insn (gen_copysign3_fcpsgn (operands[0], operands[1],
then?
[Bug target/112606] [14 Regression] powerpc64le-linux-gnu: 'FAIL: gcc.target/powerpc/p8vector-fp.c scan-assembler xsnabsdp'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112606 Andrew Pinski changed: What|Removed |Added Target Milestone|--- |14.0 Component|rtl-optimization|target Keywords||missed-optimization
