[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #14 from echristo at gcc dot gnu dot org 2006-09-10 07:09 --- Subject: Bug 28995 Author: echristo Date: Sun Sep 10 07:09:38 2006 New Revision: 116810 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=116810 Log: 2006-09-09 Eric Christopher [EMAIL PROTECTED] PR target/28995 * config/darwin.c (machopic_select_rtx_section): Add TARGET_64BIT for literal16. Modified: trunk/gcc/ChangeLog trunk/gcc/config/darwin.c -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #15 from echristo at apple dot com 2006-09-10 07:11 --- So, just committed a patch for the 32-bit problems with literal16 sections. (No, they won't be valid for 32-bit.) I'm holding on the configure patch since 2.4 seems to work fine with the patch for people and I find it reasonable to assume that people will download that. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #16 from echristo at apple dot com 2006-09-10 07:48 --- I believe this is fixed with the above change. -- echristo at apple dot com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #2 from echristo at apple dot com 2006-09-09 08:12 --- Yup. A new cctools is needed now. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
-- echristo at apple dot com changed: What|Removed |Added AssignedTo|unassigned at gcc dot gnu |echristo at apple dot com |dot org | Status|NEW |ASSIGNED Last reconfirmed|2006-09-09 04:22:58 |2006-09-09 08:40:23 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #3 from echristo at apple dot com 2006-09-09 08:53 --- FWIW I just hacked up a quick autoconf test for the feature as well if we'd prefer to have that as well... -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #4 from echristo at apple dot com 2006-09-09 08:54 --- Created an attachment (id=12212) -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12212action=view) autoconf test -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #5 from pinskia at gcc dot gnu dot org 2006-09-09 13:19 --- Even without building fortran, this gives a lot of regressions: http://gcc.gnu.org/ml/gcc-testresults/2006-09/msg00462.html -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #6 from howarth at nitro dot med dot uc dot edu 2006-09-09 17:05 --- How exactly are we supposed to cleanly add the autoconf test? I applied the patch and the ran contrib/gcc_update but the build always fails at... gcc -c -g -O2 -DIN_GCC -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wmissing-format-attribute -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc-4.2-20060909/gcc -I../../gcc-4.2-20060909/gcc/. -I../../gcc-4.2-20060909/gcc/../include -I./../intl -I../../gcc-4.2-20060909/gcc/../libcpp/include -I/sw/include -I../../gcc-4.2-20060909/gcc/../libdecnumber -I../libdecnumber -I/sw/include -I. -I. -I../../gcc-4.2-20060909/gcc -I../../gcc-4.2-20060909/gcc/. -I../../gcc-4.2-20060909/gcc/../include -I./../intl -I../../gcc-4.2-20060909/gcc/../libcpp/include -I/sw/include -I../../gcc-4.2-20060909/gcc/../libdecnumber -I../libdecnumber ../../gcc-4.2-20060909/gcc/config/darwin.c ../../gcc-4.2-20060909/gcc/config/darwin.c: In function 'machopic_select_section': ../../gcc-4.2-20060909/gcc/config/darwin.c:1140: error: 'HAVE_GAS_LITERAL16' undeclared (first use in this function) ../../gcc-4.2-20060909/gcc/config/darwin.c:1140: error: (Each undeclared identifier is reported only once ../../gcc-4.2-20060909/gcc/config/darwin.c:1140: error: for each function it appears in.) ../../gcc-4.2-20060909/gcc/config/darwin.c: In function 'machopic_select_rtx_section': ../../gcc-4.2-20060909/gcc/config/darwin.c:1244: error: 'HAVE_GAS_LITERAL16' undeclared (first use in this function) I see the same problem if I cd into gcc and run autoconf before the build as well. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #7 from echristo at apple dot com 2006-09-09 18:57 --- You run autoheader and autoconf. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #8 from howarth at nitro dot med dot uc dot edu 2006-09-09 19:44 --- Eric, I've been running autoheader and autoconf in the gcc source subdirectory. It does cause configure to run the test which results in... configure:13732: checking assembler for .literal16 configure:13745: /sw/lib/odcctools/bin/as -o conftest.o conftest.s 5 conftest.s:1:Unknown pseudo-op: .literal16 configure:13748: $? = 1 configure: failed program was .literal16 configure:13759: result: no in config.log. However the compilation of darwin.c still throws the errors I mentioned before about HAVE_GAS_LITERAL16 being undeclared. If I understand the proposed patch correctly, it will only create HAVE_GAS_LITERAL16 being set to 1 if the literal16 configure test passes but will leave it undefined otherwise. Don't we have to have it set to 0 if the configure test fails instead? Since HAVE_GAS_LITERAL16 isn't part of a preprocessor statement but is actual c code, doesn't it always have to be defined to some value? -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #9 from echristo at apple dot com 2006-09-09 19:51 --- Yeah, might be better off just bracketing the literal16 code in darwin.c with #ifdef HAVE_GAS_LITERAL16. Want to do that? -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #10 from howarth at nitro dot med dot uc dot edu 2006-09-09 19:53 --- Sure. I'll test it shortly and post. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #11 from echristo at apple dot com 2006-09-09 20:09 --- Thanks. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #12 from howarth at nitro dot med dot uc dot edu 2006-09-09 21:21 --- Created an attachment (id=12215) -- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=12215action=view) revised autoconf test Use preprocessor statements instead for darwin.c patch. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #13 from echristo at apple dot com 2006-09-09 21:27 --- Close, but I'd prefer to actually have the test for true as well in there. I'll go ahead and submit the patch similar. thanks for testing. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
[Bug target/28995] [4.2 Regression] libgfortran build now fails on Darwin PPC
--- Comment #1 from pinskia at gcc dot gnu dot org 2006-09-09 04:22 --- This is obviously caused by: * config/darwin.c (machopic_select_section): Support literal16. (machopic_select_rtx_section): Ditto. Is a new cctools needed now? -- pinskia at gcc dot gnu dot org changed: What|Removed |Added Severity|critical|blocker Status|UNCONFIRMED |NEW Component|libfortran |target Ever Confirmed|0 |1 GCC build triplet|powerpc-apple-darwin8 | GCC host triplet|powerpc-apple-darwin8 | Keywords||build Last reconfirmed|-00-00 00:00:00 |2006-09-09 04:22:58 date|| Summary|libgfortran build now fails |[4.2 Regression] libgfortran |on Darwin PPC |build now fails on Darwin ||PPC Target Milestone|--- |4.2.0 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28995
