[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #23 from Iain Sandoe iains at gcc dot gnu.org 2011-11-13 13:58:47 UTC --- Author: iains Date: Sun Nov 13 13:58:43 2011 New Revision: 181336 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=181336 Log: gcc: PR target/48108 Backport from mainline r180523 * config/darwin.c (top level): Amend comments concerning LTO output. (lto_section_num): New variable. (darwin_lto_section_e): New GTY. (LTO_SECTS_SECTION, LTO_INDEX_SECTION): New. (LTO_NAMES_SECTION): Rename. (darwin_asm_named_section): Record LTO section counts and switches in a vec of darwin_lto_section_e. (darwin_file_start): Remove unused code. (darwin_file_end): Put an LTO section termination label. Handle output of the wrapped LTO sections, index and names table. libiberty: PR target/48108 Backport from mainline r180523 * simple-object-mach-o.c (GNU_WRAPPER_SECTS, GNU_WRAPPER_INDEX, GNU_WRAPPER_NAMES): New macros. (simple_object_mach_o_segment): Handle wrapper scheme. (simple_object_mach_o_write_section_header): Allow the segment name to be supplied. (simple_object_mach_o_write_segment): Handle wrapper scheme. Ensure that the top-level segment name in the load command is empty. (simple_object_mach_o_write_to_file): Determine the number of sections during segment output, use that in writing the header. Modified: branches/gcc-4_6-branch/gcc/ChangeLog branches/gcc-4_6-branch/gcc/config/darwin.c branches/gcc-4_6-branch/libiberty/ChangeLog branches/gcc-4_6-branch/libiberty/simple-object-mach-o.c
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 Iain Sandoe iains at gcc dot gnu.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #24 from Iain Sandoe iains at gcc dot gnu.org 2011-11-13 14:00:07 UTC --- (In reply to comment #22) Can we backport r180523 to gcc-4_6-branch (perhaps even for gcc 4.6.2)? done now - Mike had approved on the mailing list. Also in gcc trunk we should also now fully revert... Author: mrs Date: Mon Mar 14 02:47:49 2011 New Revision: 170929 I don't think we can do this until PR49992 and likely PR48109 are fixed. Fixed.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #21 from Iain Sandoe iains at gcc dot gnu.org 2011-10-26 12:38:05 UTC --- Author: iains Date: Wed Oct 26 12:37:59 2011 New Revision: 180523 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=180523 Log: gcc: PR target/48108 * config/darwin.c (top level): Amend comments concerning LTO output. (lto_section_num): New variable. (darwin_lto_section_e): New GTY. (LTO_SECTS_SECTION, LTO_INDEX_SECTION): New. (LTO_NAMES_SECTION): Rename. (darwin_asm_named_section): Record LTO section counts and switches in a vec of darwin_lto_section_e. (darwin_file_start): Remove unused code. (darwin_file_end): Put an LTO section termination label. Handle output of the wrapped LTO sections, index and names table. libiberty: PR target/48108 * simple-object-mach-o.c (GNU_WRAPPER_SECTS, GNU_WRAPPER_INDEX, GNU_WRAPPER_NAMES): New macros. (simple_object_mach_o_segment): Handle wrapper scheme. (simple_object_mach_o_write_section_header): Allow the segment name to be supplied. (simple_object_mach_o_write_segment): Handle wrapper scheme. Ensure that the top-level segment name in the load command is empty. (simple_object_mach_o_write_to_file): Determine the number of sections during segment output, use that in writing the header. Modified: trunk/gcc/ChangeLog trunk/gcc/config/darwin.c trunk/libiberty/ChangeLog trunk/libiberty/simple-object-mach-o.c
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #22 from Jack Howarth howarth at nitro dot med.uc.edu 2011-10-26 13:28:20 UTC --- Can we backport r180523 to gcc-4_6-branch (perhaps even for gcc 4.6.2)? Also in gcc trunk we should also now fully revert... Author: mrs Date: Mon Mar 14 02:47:49 2011 New Revision: 170929 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=170929 Log: 2011-03-13 Jack Howarth howa...@bromo.med.uc.edu PR lto/48086 * configure.ac: Disable LTO on darwin due to an assembler change in Xcode 3.2.6/4.0 that limits the total number of sections/segments to under 256. * configure: Regenerate. Modified: trunk/ChangeLog trunk/configure trunk/configure.ac since PR48086 is solved by r180523.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 Jack Howarth howarth at nitro dot med.uc.edu changed: What|Removed |Added Severity|enhancement |normal
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 Iain Sandoe iains at gcc dot gnu.org changed: What|Removed |Added Attachment #24958|0 |1 is obsolete|| --- Comment #19 from Iain Sandoe iains at gcc dot gnu.org 2011-09-25 09:49:04 UTC --- Created attachment 25359 -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=25359 wip 3 The new attachment implements the 'wrapper' in simple-object read and write and darwin.c Modulo checking comments/white space it's a candidate for fixing the bug. I am not sure why this has been labelled 'enhancement' - we are generating badly-formed mach-o (according to the vendor) - the fact that we don't see a reported error with earlier vendor tool-chains doesn't seem to make it an 'enhancement' to get it right ;) --- I've done --with-build-config='bootstrap-lto bootstrap-debug' (no Ada on trunk because of unrelated issues) on: trunk *-darwin9 (less Ada) 4.6 i686-darwin9 (incl. Ada) 4.6 powerpc-darwin9 is running. trunk x86_64-darwin10 (less Ada) 4.6 x86_64-darwin10 (incl. Ada) So - darwin 11 needs checking. The patch applies cleanly to both 4.6 and trunk as of this time.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #20 from Jack Howarth howarth at nitro dot med.uc.edu 2011-09-26 00:47:32 UTC --- (In reply to comment #19) Created attachment 25359 [details] wip 3 Regtest on darwin11 at http://gcc.gnu.org/ml/gcc-testresults/2011-09/msg02611.html.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 Iain Sandoe iains at gcc dot gnu.org changed: What|Removed |Added Attachment #24712|0 |1 is obsolete|| --- Comment #18 from Iain Sandoe iains at gcc dot gnu.org 2011-08-09 12:56:50 UTC --- Created attachment 24958 -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=24958 update WIP 2 testing lto bootstraps together with compare debug, revealed that the $gnu$lto... symbols used to determine the sizes etc. should have been made local (i.e. L$gnu$lto..). still need to fix simple-object output to DTRT.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #17 from Jack Howarth howarth at nitro dot med.uc.edu 2011-08-05 18:52:05 UTC --- (In reply to comment #12) (In reply to comment #11) Created attachment 24397 [details] Iain's work in progress for LTO containerization Sorry that I can't commit any time to GCC right now. The main outstanding issue with this patch is that the intermediate files created by GCC are still unbounded in the number of sections. So long as the only consumer of those files is GCC, no problem (since the arrangement has been made to ensure that relocatable sections come first). However, those intermediate files are still technically 'wrong' and therefore the writer should be updated to do the same encapsulation. Once that is done there will be no need to retain the ability to recognize GCC vs 'normal' objects. Should we really be so hung up on the intermediate file issue? After all, why would anyone try to use object files generated with -flto with a compiler that doesn't support -flto. I would argue that this prevents users from accidentally disabling the -flto in that case (where they erroneously use a non-LTO aware compiler). This could simply be marked as a TODO.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #16 from David Fang fang at csl dot cornell.edu 2011-07-10 04:41:14 UTC --- This current patch yields excellent results on powerpc-darwin8 now: http://gcc.gnu.org/ml/gcc-testresults/2011-07/msg01092.html
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 Iain Sandoe iains at gcc dot gnu.org changed: What|Removed |Added Attachment #24705|0 |1 is obsolete|| --- Comment #14 from Iain Sandoe iains at gcc dot gnu.org 2011-07-08 10:33:47 UTC --- Created attachment 24712 -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=24712 updated work in progress there were a couple of hunks in the previous from another LTO patch, that reportedly gave problems on x86-64-darwin11. The attached is OK AFAICT, on 4.6, trunk x86-64-darwin10, *-darwin9. (still incomplete).
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #15 from Jack Howarth howarth at nitro dot med.uc.edu 2011-07-08 11:18:25 UTC --- (In reply to comment #14) Created attachment 24712 [details] updated work in progress there were a couple of hunks in the previous from another LTO patch, that reportedly gave problems on x86-64-darwin11. The attached is OK AFAICT, on 4.6, trunk x86-64-darwin10, *-darwin9. (still incomplete). http://gcc.gnu.org/ml/gcc-testresults/2011-07/msg00877.html No serious regressions other than objc and friends when applied to gcc 4.6.1.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 Iain Sandoe iains at gcc dot gnu.org changed: What|Removed |Added Attachment #24397|0 |1 is obsolete|| --- Comment #13 from Iain Sandoe iains at gcc dot gnu.org 2011-07-07 10:23:06 UTC --- Created attachment 24705 -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=24705 updated Work In Progress - ppc asm fix NOTE: this is still very much a work in progress and is neither complete, nor really ready for extensive testing... ... However, this minor mod fixes the issue noted with powerpc (comment introducers at the end of asm statements). Patch against trunk - but should be similar for 4.6.x.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 vincenzo Innocente vincenzo.innocente at cern dot ch changed: What|Removed |Added CC||vincenzo.innocente at cern ||dot ch --- Comment #6 from vincenzo Innocente vincenzo.innocente at cern dot ch 2011-05-30 12:01:11 UTC --- this is actually a follow up of http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49228 that has been identified as a duplicate of this bug. I applied the patch now stops here /bin/sh ./libtool --tag=CC --mode=compile /Users/innocent/RealStuff/gcc-4.7-20110528/host-x86_64-apple-darwin10.7.0/gcc/xgcc -B/Users/innocent/RealStuff/gcc-4.7-20110528/host-x86_64-apple-darwin10.7.0/gcc/ -B/usr/local/x86_64-apple-darwin10.7.0/bin/ -B/usr/local/x86_64-apple-darwin10.7.0/lib/ -isystem /usr/local/x86_64-apple-darwin10.7.0/include -isystem /usr/local/x86_64-apple-darwin10.7.0/sys-include-DHAVE_CONFIG_H -I. -I../.././libgfortran -iquote../.././libgfortran/io -I../.././libgfortran/../gcc -I../.././libgfortran/../gcc/config -I../.././libgfortran/../libquadmath -I../../host-x86_64-apple-darwin10.7.0/gcc -std=gnu99 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wextra -Wwrite-strings -fcx-fortran-rules -ffunction-sections -fdata-sections -g -O2 -ftree-vectorize -fPIC -MT fmain.lo -MD -MP -MF .deps/fmain.Tpo -c -o fmain.lo ../.././libgfortran/fmain.c libtool: compile: /Users/innocent/RealStuff/gcc-4.7-20110528/host-x86_64-apple-darwin10.7.0/gcc/xgcc -B/Users/innocent/RealStuff/gcc-4.7-20110528/host-x86_64-apple-darwin10.7.0/gcc/ -B/usr/local/x86_64-apple-darwin10.7.0/bin/ -B/usr/local/x86_64-apple-darwin10.7.0/lib/ -isystem /usr/local/x86_64-apple-darwin10.7.0/include -isystem /usr/local/x86_64-apple-darwin10.7.0/sys-include -DHAVE_CONFIG_H -I. -I../.././libgfortran -iquote../.././libgfortran/io -I../.././libgfortran/../gcc -I../.././libgfortran/../gcc/config -I../.././libgfortran/../libquadmath -I../../host-x86_64-apple-darwin10.7.0/gcc -std=gnu99 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -Wextra -Wwrite-strings -fcx-fortran-rules -ffunction-sections -fdata-sections -g -O2 -ftree-vectorize -fPIC -MT fmain.lo -MD -MP -MF .deps/fmain.Tpo -c ../.././libgfortran/fmain.c -fno-common -DPIC -o .libs/fmain.o In file included from ../.././libgfortran/libgfortran.h:53:0, from ../.././libgfortran/fmain.c:4: ../.././libgfortran/../libquadmath/quadmath_weak.h:39:1: internal compiler error: tree check: expected tree that contains ‘common’ structure, have ‘identifier_node’ in assemble_alias, at varasm.c:5789 Please submit a full bug report, with preprocessed source if appropriate. See http://gcc.gnu.org/bugs.html for instructions.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #7 from Dominique d'Humieres dominiq at lps dot ens.fr 2011-05-30 12:19:45 UTC --- This is pr49190. If you want to proceed, you need to revert revision 174286 (or to wait for a fix). BTW which version of Xcode are you using?
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #8 from vincenzo Innocente vincenzo.innocente at cern dot ch 2011-05-30 12:26:37 UTC --- On 30 May, 2011, at 2:20 PM, dominiq at lps dot ens.fr wrote: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #7 from Dominique d'Humieres dominiq at lps dot ens.fr 2011-05-30 12:19:45 UTC --- This is pr49190. If you want to proceed, you need to revert revision 174286 (or to wait for a fix). ok, I will wait for a fix it built g++ and that's enough for let me going for a while :-) BTW which version of Xcode are you using? apparently Version 3.2.6 thanks for the quick reply v.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #9 from Dominique d'Humieres dominiq at lps dot ens.fr 2011-05-30 13:04:29 UTC --- ok, I will wait for a fix Meanwhile you can also configure with --enable-checking=release.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #11 from Jack Howarth howarth at nitro dot med.uc.edu 2011-05-30 15:16:25 UTC --- Created attachment 24397 -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=24397 Iain's work in progress for LTO containerization
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #10 from Jack Howarth howarth at nitro dot med.uc.edu 2011-05-30 15:15:31 UTC --- I have been using Iain's last work in progress patch and it works fine with both gcc 4.6 branch and gcc trunk. Hopefully he can get back to polishing it or someone else can pick up the patch and complete it.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 Iain Sandoe iains at gcc dot gnu.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2011.05.30 15:30:05 Ever Confirmed|0 |1 --- Comment #12 from Iain Sandoe iains at gcc dot gnu.org 2011-05-30 15:30:05 UTC --- (In reply to comment #11) Created attachment 24397 [details] Iain's work in progress for LTO containerization Sorry that I can't commit any time to GCC right now. The main outstanding issue with this patch is that the intermediate files created by GCC are still unbounded in the number of sections. So long as the only consumer of those files is GCC, no problem (since the arrangement has been made to ensure that relocatable sections come first). However, those intermediate files are still technically 'wrong' and therefore the writer should be updated to do the same encapsulation. Once that is done there will be no need to retain the ability to recognize GCC vs 'normal' objects.
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #5 from Jack Howarth howarth at nitro dot med.uc.edu 2011-03-17 12:02:02 UTC --- Testresults for gcc-4_6-branch built under Xcode 4.0 using lto-bootstrap/profiledbootstrap with Iain's first attempt at containerization. http://gcc.gnu.org/ml/gcc-testresults/2011-03/msg01695.html
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 Richard Guenther rguenth at gcc dot gnu.org changed: What|Removed |Added Keywords||lto Component|lto |target Severity|normal |enhancement
[Bug target/48108] lto should be containerized in a single mach-o section on darwin
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48108 --- Comment #4 from Mike Stump mikestump at comcast dot net 2011-03-14 23:34:38 UTC --- WDYT? Sounds fine to me.
