[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

Ramana Radhakrishnan  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Target Milestone|--- |7.0

--- Comment #10 from Ramana Radhakrishnan  ---
Fixed for GCC 7.

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

Martin Liška  changed:

   What|Removed |Added

 CC||marxin at gcc dot gnu.org

--- Comment #9 from Martin Liška  ---
Can the bug be marked as resolved?

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

--- Comment #8 from Ramana Radhakrishnan  ---
Author: ramana
Date: Fri May 13 09:32:29 2016
New Revision: 236198

URL: https://gcc.gnu.org/viewcvs?rev=236198=gcc=rev
Log:
Fix PR target/53440 - handle generic thunks better for TARGET_32BIT.


This partially fixes PR target/53440 atleast in ARM and
Thumb2 state. I haven't yet managed to get my head around
rewriting the Thumb1 support yet.

Tested on armhf with a bootstrap and regression test
with no regressions.

Queued for stage1 now as it isn't technically a regression.

regards
Ramana


2016-05-13  Ramana Radhakrishnan  

PR target/53440
* config/arm/arm.c (arm32_output_mi_thunk): New.
(arm_output_mi_thunk): Rename to arm_thumb1_mi_thunk. Rework
to split Thumb1 vs TARGET_32BIT functionality.
(arm_thumb1_mi_thunk): New.


* g++.dg/inherit/thunk1.C: Support arm / aarch64.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/arm/arm.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/g++.dg/inherit/thunk1.C

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

--- Comment #7 from Ramana Radhakrishnan  ---
A patch to fix this for TARGET_32BIT is here.

https://gcc.gnu.org/ml/gcc-patches/2016-04/msg00060.html

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[bernd.edlinger at hotmail dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

Bernd Edlinger  changed:

   What|Removed |Added

 CC||bernd.edlinger at hotmail dot 
de

--- Comment #6 from Bernd Edlinger  ---
Created attachment 37575
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=37575=edit
untested patch for virtual thunk code

This patch does not handle every possible vcall_offset but
usually vcall_offset is either -12 or 0, so a simple approach
should be sufficient.

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

Ramana Radhakrishnan  changed:

   What|Removed |Added

 CC||jgreenhalgh at gcc dot gnu.org

--- Comment #5 from Ramana Radhakrishnan  ---
*** Bug 66755 has been marked as a duplicate of this bug. ***

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[ramana at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

Ramana Radhakrishnan ramana at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2012-05-22
 CC||ramana at gcc dot gnu.org
 Ever Confirmed|0   |1

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[rearnsha at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

--- Comment #3 from Richard Earnshaw rearnsha at gcc dot gnu.org 2012-05-22 
16:36:56 UTC ---
(In reply to comment #2)
 Someone needs to implement the thunk functionality for arm.

The ARM port does have MI thunk support.  The question is why isn't it being
used?

R.

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[rmansfield at qnx dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

--- Comment #4 from Ryan Mansfield rmansfield at qnx dot com 2012-05-23 
00:12:59 UTC ---
(In reply to comment #3)
 (In reply to comment #2)
  Someone needs to implement the thunk functionality for arm.
 
 The ARM port does have MI thunk support.  The question is why isn't it being
 used?

I may be answering the question too directly but it's using the
default_can_output_mi_thunk_no_vcall and vcall_offset is non-zero. The ARM MI
thunk code doesn't do any vcall offset adjustment.

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[rmansfield at qnx dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

--- Comment #1 from Ryan Mansfield rmansfield at qnx dot com 2012-05-21 
18:04:03 UTC ---
Created attachment 27463
  -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=27463
test case

[Bug target/53440] [arm] generic thunk code fails for method which uses '...'

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53440

--- Comment #2 from Andrew Pinski pinskia at gcc dot gnu.org 2012-05-21 
18:55:04 UTC ---
Someone needs to implement the thunk functionality for arm.