[Bug target/54746] config/s390/s390.c:1583: possible missing break in switch ?

[krebbel at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746

Andreas Krebbel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Andreas Krebbel  ---
Fixed.

[Bug target/54746] config/s390/s390.c:1583: possible missing break in switch ?

[krebbel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746



--- Comment #2 from Andreas Krebbel krebbel at gcc dot gnu.org 2012-10-01 
07:23:21 UTC ---

Author: krebbel

Date: Mon Oct  1 07:23:12 2012

New Revision: 191885



URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=191885

Log:

2012-10-01  Andreas Krebbel  andreas.kreb...@de.ibm.com



PR target/54746

* config/s390/s390.c (s390_option_override): Add missing break.





Modified:

trunk/gcc/ChangeLog

trunk/gcc/config/s390/s390.c

[Bug target/54746] config/s390/s390.c:1583: possible missing break in switch ?

[krebbel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746



--- Comment #3 from Andreas Krebbel krebbel at gcc dot gnu.org 2012-10-01 
07:33:17 UTC ---

(In reply to comment #0)

 break;

 case PROCESSOR_2097_Z10:

   s390_cost = z10_cost;

 case PROCESSOR_2817_Z196:

   s390_cost = z196_cost;

 

 Looks like a missing break to me. The wrong cost gets picked up.



You are right. I'll commit a patch to mainline and 4.7 branch. Thanks!

[Bug target/54746] config/s390/s390.c:1583: possible missing break in switch ?

[krebbel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746



--- Comment #4 from Andreas Krebbel krebbel at gcc dot gnu.org 2012-10-01 
07:51:26 UTC ---

Author: krebbel

Date: Mon Oct  1 07:51:20 2012

New Revision: 191888



URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=191888

Log:

2012-10-01  Andreas Krebbel  andreas.kreb...@de.ibm.com



PR target/54746

* config/s390/s390.c (s390_option_override): Add missing break.





Modified:

branches/gcc-4_7-branch/gcc/ChangeLog

branches/gcc-4_7-branch/gcc/config/s390/s390.c

[Bug target/54746] config/s390/s390.c:1583: possible missing break in switch ?

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54746



Paolo Carlini paolo.carlini at oracle dot com changed:



   What|Removed |Added



 CC||krebbel at gcc dot gnu.org



--- Comment #1 from Paolo Carlini paolo.carlini at oracle dot com 2012-09-29 
10:43:35 UTC ---

Andreas, can you have a look?