[Bug target/65342] [7/8 Regression] powerpc-darwin9 m64 code-gen error exposed by r210201
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65342 Iain Sandoe changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #35 from Iain Sandoe --- fixed on open branches
[Bug target/65342] [7/8 Regression] powerpc-darwin9 m64 code-gen error exposed by r210201
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65342 --- Comment #34 from Iain Sandoe --- Author: iains Date: Tue Oct 29 20:20:23 2019 New Revision: 277590 URL: https://gcc.gnu.org/viewcvs?rev=277590=gcc=rev Log: [Darwin, PPC] Fix PR 65342. The current Darwin load/store lo_sum patterns have neither predicate nor constraint. This means that most parts of the backend, which rely on recog() to validate the rtx, can produce invalid combinations/selections. For 32bit cases this isn't a problem since we can load/store to unaligned addresses using D-mode insns. Conversely, for 64bit instructions that use DS mode, this can manifest as assemble errors (for an assembler that checks the LO14 relocations), or as crashes caused by wrong offsets (or worse, wrong content for the two LSBs). What we want to check for Y on Darwin is: - that the alignment of the Symbols' target is sufficient for DS mode - that the offset is suitable for DS mode. (while looking through the Mach-O PIC unspecs). So, the patch removes the Darwin-specific lo_sum patterns (we begin using the movdi_internal64 patterns). We also we need to extend the handling of the mem_operand_gpr constraint to allow looking through Mach-O PIC UNSPECs in the lo_sum cases. 2019-10-29 Iain Sandoe Backport from mainline 2019-10-17 Iain Sandoe PR target/65342 * config/rs6000/darwin.md (movdi_low, movsi_low_st): Delete. (movdi_low_st): Delete. * config/rs6000/rs6000.c (darwin_rs6000_legitimate_lo_sum_const_p): New. (mem_operand_gpr): Validate Mach-O LO_SUM cases separately. * config/rs6000/rs6000.md (movsi_low): Delete. Modified: branches/gcc-7-branch/gcc/ChangeLog branches/gcc-7-branch/gcc/config/rs6000/darwin.md branches/gcc-7-branch/gcc/config/rs6000/rs6000.c branches/gcc-7-branch/gcc/config/rs6000/rs6000.md
[Bug target/65342] [7/8 Regression] powerpc-darwin9 m64 code-gen error exposed by r210201
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65342 --- Comment #33 from Iain Sandoe --- Author: iains Date: Mon Oct 28 20:02:01 2019 New Revision: 277543 URL: https://gcc.gnu.org/viewcvs?rev=277543=gcc=rev Log: [Darwin, PPC] Fix PR 65342. The current Darwin load/store lo_sum patterns have neither predicate nor constraint. This means that most parts of the backend, which rely on recog() to validate the rtx, can produce invalid combinations/selections. For 32bit cases this isn't a problem since we can load/store to unaligned addresses using D-mode insns. Conversely, for 64bit instructions that use DS mode, this can manifest as assemble errors (for an assembler that checks the LO14 relocations), or as crashes caused by wrong offsets (or worse, wrong content for the two LSBs). What we want to check for Y on Darwin is: - that the alignment of the Symbols' target is sufficient for DS mode - that the offset is suitable for DS mode. (while looking through the Mach-O PIC unspecs). So, the patch removes the Darwin-specific lo_sum patterns (we begin using the movdi_internal64 patterns). We also we need to extend the handling of the mem_operand_gpr constraint to allow looking through Mach-O PIC UNSPECs in the lo_sum cases. 2019-10-28 Iain Sandoe Backport from mainline 2019-10-17 Iain Sandoe PR target/65342 * config/rs6000/darwin.md (movdi_low, movsi_low_st): Delete. (movdi_low_st): Delete. * config/rs6000/rs6000.c (darwin_rs6000_legitimate_lo_sum_const_p): New. (mem_operand_gpr): Validate Mach-O LO_SUM cases separately. * config/rs6000/rs6000.md (movsi_low): Delete. Modified: branches/gcc-8-branch/gcc/ChangeLog branches/gcc-8-branch/gcc/config/rs6000/darwin.md branches/gcc-8-branch/gcc/config/rs6000/rs6000.c branches/gcc-8-branch/gcc/config/rs6000/rs6000.md
[Bug target/65342] [7/8 Regression] powerpc-darwin9 m64 code-gen error exposed by r210201
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65342 Iain Sandoe changed: What|Removed |Added Keywords||wrong-code Summary|[7/8/9/10 Regression] FAIL: |[7/8 Regression] |gfortran.dg/intrinsic_(un)? |powerpc-darwin9 m64 |pack_1.f90 -O1 execution |code-gen error exposed by |test on |r210201 |powerpc-apple-darwin9/10| |after r210201 | --- Comment #32 from Iain Sandoe --- fixed for trunk and 9 so far.
