[Bug target/65624] ICE in aarch64-builtins.c when expanding 4-argument aarch64 intrinsic.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65624

--- Comment #9 from Jakub Jelinek  ---
Author: jakub
Date: Wed Feb 10 18:40:54 2016
New Revision: 233296

URL: https://gcc.gnu.org/viewcvs?rev=233296=gcc=rev
Log:
Backported from mainline
2016-01-21  Stefan Sørensen  
Jakub Jelinek  

PR target/69187
PR target/65624
* config/arm/arm-builtins.c (arm_expand_neon_builtin): Increase
args array size by one to avoid buffer overflow.

* gcc.target/arm/pr69187.c: New test.

Added:
branches/gcc-5-branch/gcc/testsuite/gcc.target/arm/pr69187.c
Modified:
branches/gcc-5-branch/gcc/ChangeLog
branches/gcc-5-branch/gcc/config/arm/arm-builtins.c
branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug target/65624] ICE in aarch64-builtins.c when expanding 4-argument aarch64 intrinsic.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65624

--- Comment #8 from Jakub Jelinek  ---
Author: jakub
Date: Thu Jan 21 09:52:46 2016
New Revision: 232668

URL: https://gcc.gnu.org/viewcvs?rev=232668=gcc=rev
Log:
PR target/69187
PR target/65624
* config/arm/arm-builtins.c (arm_expand_neon_builtin): Increase
args array size by one to avoid buffer overflow.

* gcc.target/arm/pr69187.c: New test.

Added:
trunk/gcc/testsuite/gcc.target/arm/pr69187.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/arm/arm-builtins.c
trunk/gcc/testsuite/ChangeLog

[Bug target/65624] ICE in aarch64-builtins.c when expanding 4-argument aarch64 intrinsic.

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65624

--- Comment #6 from Maxim Ostapenko chefmax at gcc dot gnu.org ---
Author: chefmax
Date: Wed Apr  1 11:18:03 2015
New Revision: 221807

URL: https://gcc.gnu.org/viewcvs?rev=221807root=gccview=rev
Log:
2015-04-01  Max Ostapenko  m.ostape...@partner.samsung.com

PR target/65624

gcc/
* config/aarch64/aarch64-builtins.c (aarch64_simd_expand_builtin): Increase
args array size by one to avoid buffer overflow.

gcc/testsuite/
* gcc.target/aarch64/pr65624.c: New test.

Added:
trunk/gcc/testsuite/gcc.target/aarch64/pr65624.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/aarch64/aarch64-builtins.c
trunk/gcc/testsuite/ChangeLog

[Bug target/65624] ICE in aarch64-builtins.c when expanding 4-argument aarch64 intrinsic.

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65624

Maxim Ostapenko chefmax at gcc dot gnu.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Maxim Ostapenko chefmax at gcc dot gnu.org ---
Fixed.

[Bug target/65624] ICE in aarch64-builtins.c when expanding 4-argument aarch64 intrinsic.

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65624

--- Comment #1 from Maxim Ostapenko chefmax at gcc dot gnu.org ---
Created attachment 35179
  -- https://gcc.gnu.org/bugzilla/attachment.cgi?id=35179action=edit
Trivial fix

Trivial fix.

[Bug target/65624] ICE in aarch64-builtins.c when expanding 4-argument aarch64 intrinsic.

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65624

ktkachov at gcc dot gnu.org changed:

   What|Removed |Added

 Status|WAITING |NEW

--- Comment #5 from ktkachov at gcc dot gnu.org ---
Ok, reproduced. Can you test the patch and send it to gcc-patches please?

[Bug target/65624] ICE in aarch64-builtins.c when expanding 4-argument aarch64 intrinsic.

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65624

ktkachov at gcc dot gnu.org changed:

   What|Removed |Added

 Status|RESOLVED|WAITING
   Last reconfirmed||2015-03-30
 Resolution|FIXED   |---
 Ever confirmed|0   |1

--- Comment #3 from ktkachov at gcc dot gnu.org ---
Actually, r218021 touches the argument expansion rather than builtin expansion
functions, so I'm not sure that would fix it. But still, I can't reproduce this
on current trunk with aarch64-none-linux-gnu

[Bug target/65624] ICE in aarch64-builtins.c when expanding 4-argument aarch64 intrinsic.

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65624

--- Comment #4 from Maxim Ostapenko chefmax at gcc dot gnu.org ---
(In reply to ktkachov from comment #3)
 Actually, r218021 touches the argument expansion rather than builtin
 expansion functions, so I'm not sure that would fix it. But still, I can't
 reproduce this on current trunk with aarch64-none-linux-gnu

I'm sorry, but did you try to reproduce on i686 host? This is the only host I
can reproduce this on, for x86_64 everything is fine.

When aarch64_simd_expand_builtin fills args array for 4-argument intrinsic with
return value, it feels it with values like this:

1070  args[k] = SIMD_ARG_STOP;
(gdb) p args
$4 = {SIMD_ARG_COPY_TO_REG, SIMD_ARG_COPY_TO_REG, SIMD_ARG_COPY_TO_REG,
SIMD_ARG_COPY_TO_REG, SIMD_ARG_LANE_INDEX}
(gdb) p args[5]
$6 = SIMD_ARG_STOP

Note, that SIMD_ARG_STOP was written right after args array, since it's size is
5. Isn't it a UB here?

[Bug target/65624] ICE in aarch64-builtins.c when expanding 4-argument aarch64 intrinsic.

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65624

ktkachov at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from ktkachov at gcc dot gnu.org ---
This should have been fixed with r218021.
Works for me with current trunk. Unless this occurs on a release branch as
well, I'm closing this.