[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

Eric Botcazou  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Target Milestone|7.0 |6.4

--- Comment #14 from Eric Botcazou  ---
Fixed everywhere.

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

--- Comment #13 from Eric Botcazou  ---
Author: ebotcazou
Date: Fri Apr  7 16:26:52 2017
New Revision: 246767

URL: https://gcc.gnu.org/viewcvs?rev=246767=gcc=rev
Log:
Backport from mainline
2017-04-05  Eric Botcazou  

PR target/78002
* config/aarch64/aarch64.c (aarch64_emit_probe_stack_range): Replace
ptr_mode with Pmode throughout.
* config/aarch64/aarch64.md (probe_stack_range_

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

--- Comment #12 from Eric Botcazou  ---
Author: ebotcazou
Date: Wed Apr  5 11:48:02 2017
New Revision: 246702

URL: https://gcc.gnu.org/viewcvs?rev=246702=gcc=rev
Log:
PR target/78002
* config/aarch64/aarch64.c (aarch64_emit_probe_stack_range): Replace
ptr_mode with Pmode throughout.
* config/aarch64/aarch64.md (probe_stack_range_

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[sch...@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

--- Comment #11 from Andreas Schwab  ---
It appears that there is indeed some problem with unwinding.

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

--- Comment #10 from Eric Botcazou  ---
> No, it's call by descriptor that doesn't work for ilp32, which breaks
> tasking.

I see, it's indeed totally untested in this configuration, although I don't
think there is any fundamental issue which cannot be solved.

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[sch...@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

--- Comment #9 from Andreas Schwab  ---
No, it's call by descriptor that doesn't work for ilp32, which breaks tasking.

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

--- Comment #8 from Eric Botcazou  ---
> The ICE is gone, but gnat.dg/stack_check[12].adb fail execution test.

That gnat.dg/null_pointer_deref2.adb also fails would point to unwinding.

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[sch...@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

--- Comment #7 from Andreas Schwab  ---
http://gcc.gnu.org/ml/gcc-testresults/2017-04/msg00082.html

The ICE is gone, but gnat.dg/stack_check[12].adb fail execution test.

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

Eric Botcazou  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|unassigned at gcc dot gnu.org  |ebotcazou at gcc dot 
gnu.org

--- Comment #6 from Eric Botcazou  ---
Created attachment 41095
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41095=edit
Tentative fix

Tested in LP64 mode, needs to be tested in ILP32 mode.

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

--- Comment #5 from Eric Botcazou  ---
So the proper thing to do might be to restore Pmode as in the first version:
  https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01988.html

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[sch...@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

Andreas Schwab  changed:

   What|Removed |Added

   Target Milestone|--- |7.0

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[jiwang at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

Jiong Wang  changed:

   What|Removed |Added

 CC||sch...@linux-m68k.org

--- Comment #4 from Jiong Wang  ---
*** Bug 80252 has been marked as a duplicate of this bug. ***

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

--- Comment #3 from Andrew Pinski  ---
(In reply to hs.naveen2u from comment #2)
> Could not reproduce the issue on latest FSF source:-
> 
> Tried using the following command:-
> -gcc -fstack-check gcc/testsuite/gcc.target/aarch64/stack-checking.c 
> -mabi=ilp32

I can though:
FAIL: gcc.target/aarch64/stack-checking.c (internal compiler error)
FAIL: gcc.target/aarch64/stack-checking.c (test for excess errors)

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[hs.naveen2u at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

hs.naveen2u at gmail dot com changed:

   What|Removed |Added

 CC||hs.naveen2u at gmail dot com

--- Comment #2 from hs.naveen2u at gmail dot com ---
Could not reproduce the issue on latest FSF source:-

Tried using the following command:-
-gcc -fstack-check gcc/testsuite/gcc.target/aarch64/stack-checking.c 
-mabi=ilp32

[Bug target/78002] gcc.target/aarch64/stack-checking.c ICEs with -mabi=ilp32

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78002

Eric Botcazou  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2016-10-16
 CC||ebotcazou at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #1 from Eric Botcazou  ---
So ptr_mode vs Pmode mismatch?  If so, the irony is that the implementation as
submitted initially was using Pmode, but was changed upon explicit request:
  https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00418.html